From: Michal Marek <mmarek@suse.cz>
To: Fernando Luis Vazquez Cao <fernando_b1@lab.ntt.co.jp>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] scripts/mod: add device table offsets file to list of files to clean
Date: Mon, 08 Apr 2013 16:34:10 +0200 [thread overview]
Message-ID: <5162D562.1090104@suse.cz> (raw)
In-Reply-To: <51480D07.5060505@lab.ntt.co.jp>
On 19.3.2013 08:00, Fernando Luis Vazquez Cao wrote:
> Hi Michal,
>
> On 2013/03/04 18:57, Fernando Luis Vázquez Cao wrote:
>> From: Fernando Luis Vázquez Cao <fernando@oss.ntt.co.jp>
>>
>> This file is generated so it does not get cleaned automagically. In
>> other words
>> we need to added to the clean-files list.
>>
>> Signed-off-by: Fernando Luis Vázquez Cao <fernando@oss.ntt.co.jp>
>> ---
>>
>> diff -urNp linux-3.9-rc1-orig/scripts/mod/Makefile
>> linux-3.9-rc1/scripts/mod/Makefile
>> --- linux-3.9-rc1-orig/scripts/mod/Makefile 2013-03-04
>> 16:09:29.297904000 +0900
>> +++ linux-3.9-rc1/scripts/mod/Makefile 2013-03-04
>> 18:06:16.359389000 +0900
>> @@ -49,3 +49,5 @@ $(obj)/elfconfig.h: $(obj)/empty.o $(obj
>> $(call if_changed,elfconfig)
>> targets += elfconfig.h
>> +
>> +clean-files := $(devicetable-offsets-file)
>
> Do you see any problem with this patch?
Yes, it does not work, at least not on top of 3.9-rc1. You need to add
'scripts' to the $(clean-dirs) list in the main Makefile, so that make
clean descends into scripts/mod.
Michal
prev parent reply other threads:[~2013-04-08 14:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-04 9:57 [PATCH] scripts/mod: add device table offsets file to list of files to clean Fernando Luis Vázquez Cao
2013-03-19 7:00 ` Fernando Luis Vazquez Cao
2013-04-08 14:34 ` Michal Marek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5162D562.1090104@suse.cz \
--to=mmarek@suse.cz \
--cc=fernando_b1@lab.ntt.co.jp \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.