All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] scripts/mod: add device table offsets file to list of files to clean
@ 2013-03-04  9:57 Fernando Luis Vázquez Cao
  2013-03-19  7:00 ` Fernando Luis Vazquez Cao
  0 siblings, 1 reply; 3+ messages in thread
From: Fernando Luis Vázquez Cao @ 2013-03-04  9:57 UTC (permalink / raw)
  To: Michal Marek; +Cc: linux-kernel

From: Fernando Luis Vázquez Cao <fernando@oss.ntt.co.jp>

This file is generated so it does not get cleaned automagically. In other words
we need to added to the clean-files list.

Signed-off-by: Fernando Luis Vázquez Cao <fernando@oss.ntt.co.jp>
---

diff -urNp linux-3.9-rc1-orig/scripts/mod/Makefile linux-3.9-rc1/scripts/mod/Makefile
--- linux-3.9-rc1-orig/scripts/mod/Makefile	2013-03-04 16:09:29.297904000 +0900
+++ linux-3.9-rc1/scripts/mod/Makefile	2013-03-04 18:06:16.359389000 +0900
@@ -49,3 +49,5 @@ $(obj)/elfconfig.h: $(obj)/empty.o $(obj
 	$(call if_changed,elfconfig)
 
 targets += elfconfig.h
+
+clean-files	:= $(devicetable-offsets-file)



^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] scripts/mod: add device table offsets file to list of files to clean
  2013-03-04  9:57 [PATCH] scripts/mod: add device table offsets file to list of files to clean Fernando Luis Vázquez Cao
@ 2013-03-19  7:00 ` Fernando Luis Vazquez Cao
  2013-04-08 14:34   ` Michal Marek
  0 siblings, 1 reply; 3+ messages in thread
From: Fernando Luis Vazquez Cao @ 2013-03-19  7:00 UTC (permalink / raw)
  To: Michal Marek; +Cc: linux-kernel

Hi Michal,

On 2013/03/04 18:57, Fernando Luis Vázquez Cao wrote:
> From: Fernando Luis Vázquez Cao <fernando@oss.ntt.co.jp>
>
> This file is generated so it does not get cleaned automagically. In other words
> we need to added to the clean-files list.
>
> Signed-off-by: Fernando Luis Vázquez Cao <fernando@oss.ntt.co.jp>
> ---
>
> diff -urNp linux-3.9-rc1-orig/scripts/mod/Makefile linux-3.9-rc1/scripts/mod/Makefile
> --- linux-3.9-rc1-orig/scripts/mod/Makefile	2013-03-04 16:09:29.297904000 +0900
> +++ linux-3.9-rc1/scripts/mod/Makefile	2013-03-04 18:06:16.359389000 +0900
> @@ -49,3 +49,5 @@ $(obj)/elfconfig.h: $(obj)/empty.o $(obj
>   	$(call if_changed,elfconfig)
>   
>   targets += elfconfig.h
> +
> +clean-files	:= $(devicetable-offsets-file)

Do you see any problem with this patch?

Thanks,
Fernando

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] scripts/mod: add device table offsets file to list of files to clean
  2013-03-19  7:00 ` Fernando Luis Vazquez Cao
@ 2013-04-08 14:34   ` Michal Marek
  0 siblings, 0 replies; 3+ messages in thread
From: Michal Marek @ 2013-04-08 14:34 UTC (permalink / raw)
  To: Fernando Luis Vazquez Cao; +Cc: linux-kernel

On 19.3.2013 08:00, Fernando Luis Vazquez Cao wrote:
> Hi Michal,
> 
> On 2013/03/04 18:57, Fernando Luis Vázquez Cao wrote:
>> From: Fernando Luis Vázquez Cao <fernando@oss.ntt.co.jp>
>>
>> This file is generated so it does not get cleaned automagically. In
>> other words
>> we need to added to the clean-files list.
>>
>> Signed-off-by: Fernando Luis Vázquez Cao <fernando@oss.ntt.co.jp>
>> ---
>>
>> diff -urNp linux-3.9-rc1-orig/scripts/mod/Makefile
>> linux-3.9-rc1/scripts/mod/Makefile
>> --- linux-3.9-rc1-orig/scripts/mod/Makefile    2013-03-04
>> 16:09:29.297904000 +0900
>> +++ linux-3.9-rc1/scripts/mod/Makefile    2013-03-04
>> 18:06:16.359389000 +0900
>> @@ -49,3 +49,5 @@ $(obj)/elfconfig.h: $(obj)/empty.o $(obj
>>       $(call if_changed,elfconfig)
>>     targets += elfconfig.h
>> +
>> +clean-files    := $(devicetable-offsets-file)
> 
> Do you see any problem with this patch?

Yes, it does not work, at least not on top of 3.9-rc1. You need to add
'scripts' to the $(clean-dirs) list in the main Makefile, so that make
clean descends into scripts/mod.

Michal


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2013-04-08 14:34 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-03-04  9:57 [PATCH] scripts/mod: add device table offsets file to list of files to clean Fernando Luis Vázquez Cao
2013-03-19  7:00 ` Fernando Luis Vazquez Cao
2013-04-08 14:34   ` Michal Marek

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.