From: Sylwester Nawrocki <s.nawrocki@samsung.com>
To: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
Cc: Sylwester Nawrocki <sylvester.nawrocki@gmail.com>,
linux-media@vger.kernel.org,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Hans Verkuil <hverkuil@xs4all.nl>,
Sylwester Nawrocki <s.nawrocki@samsung.com>,
linux-sh@vger.kernel.org, Magnus Damm <magnus.damm@gmail.com>,
Sakari Ailus <sakari.ailus@iki.fi>,
Prabhakar Lad <prabhakar.lad@ti.com>
Subject: Re: [PATCH v6 1/7] media: V4L2: add temporary clock helpers
Date: Mon, 08 Apr 2013 15:20:35 +0000 [thread overview]
Message-ID: <5162E043.9050103@samsung.com> (raw)
In-Reply-To: <Pine.LNX.4.64.1304081234050.29945@axis700.grange>
On 04/08/2013 12:36 PM, Guennadi Liakhovetski wrote:
> On Mon, 18 Mar 2013, Sylwester Nawrocki wrote:
>
> [snip]
>
>>> +unsigned long v4l2_clk_get_rate(struct v4l2_clk *clk)
>>> +{
>>> + if (!clk->ops->get_rate)
>>> + return -ENOSYS;
>>
>> I guess we should just WARN if this callback is null and return 0
>> or return value type of this function needs to be 'long'. Otherwise
>> we'll get insanely large frequency value by casting this error code
>> to unsigned long.
>
> Comparing to the CCF: AFAICS, they do the same, you're supposed to use
> IS_ERR_VALUE() on the clock rate, obtained from clk_get_rate().
Hmm, that might work. Nevertheless I consider that a pretty horrible
pattern. I couldn't find any references to IS_ERR_VALUE in the clock
code though. Only that 0 is returned when clk is NULL.
Regards,
Sylwester
WARNING: multiple messages have this Message-ID (diff)
From: Sylwester Nawrocki <s.nawrocki@samsung.com>
To: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
Cc: Sylwester Nawrocki <sylvester.nawrocki@gmail.com>,
linux-media@vger.kernel.org,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Hans Verkuil <hverkuil@xs4all.nl>,
Sylwester Nawrocki <s.nawrocki@samsung.com>,
linux-sh@vger.kernel.org, Magnus Damm <magnus.damm@gmail.com>,
Sakari Ailus <sakari.ailus@iki.fi>,
Prabhakar Lad <prabhakar.lad@ti.com>
Subject: Re: [PATCH v6 1/7] media: V4L2: add temporary clock helpers
Date: Mon, 08 Apr 2013 17:20:35 +0200 [thread overview]
Message-ID: <5162E043.9050103@samsung.com> (raw)
In-Reply-To: <Pine.LNX.4.64.1304081234050.29945@axis700.grange>
On 04/08/2013 12:36 PM, Guennadi Liakhovetski wrote:
> On Mon, 18 Mar 2013, Sylwester Nawrocki wrote:
>
> [snip]
>
>>> +unsigned long v4l2_clk_get_rate(struct v4l2_clk *clk)
>>> +{
>>> + if (!clk->ops->get_rate)
>>> + return -ENOSYS;
>>
>> I guess we should just WARN if this callback is null and return 0
>> or return value type of this function needs to be 'long'. Otherwise
>> we'll get insanely large frequency value by casting this error code
>> to unsigned long.
>
> Comparing to the CCF: AFAICS, they do the same, you're supposed to use
> IS_ERR_VALUE() on the clock rate, obtained from clk_get_rate().
Hmm, that might work. Nevertheless I consider that a pretty horrible
pattern. I couldn't find any references to IS_ERR_VALUE in the clock
code though. Only that 0 is returned when clk is NULL.
Regards,
Sylwester
next prev parent reply other threads:[~2013-04-08 15:20 UTC|newest]
Thread overview: 54+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-15 21:27 [PATCH v6 0/7] V4L2 clock and async patches and soc-camera example Guennadi Liakhovetski
2013-03-15 21:27 ` Guennadi Liakhovetski
2013-03-15 21:27 ` [PATCH v6 1/7] media: V4L2: add temporary clock helpers Guennadi Liakhovetski
2013-03-15 21:27 ` Guennadi Liakhovetski
2013-03-18 22:21 ` Sylwester Nawrocki
2013-03-18 22:21 ` Sylwester Nawrocki
2013-03-19 7:32 ` Guennadi Liakhovetski
2013-03-19 7:32 ` Guennadi Liakhovetski
2013-03-19 9:52 ` Sylwester Nawrocki
2013-03-19 9:52 ` Sylwester Nawrocki
2013-03-19 10:27 ` Guennadi Liakhovetski
2013-03-19 10:27 ` Guennadi Liakhovetski
2013-03-26 23:09 ` Laurent Pinchart
2013-03-26 23:09 ` Laurent Pinchart
2013-03-26 23:08 ` Laurent Pinchart
2013-03-26 23:08 ` Laurent Pinchart
2013-04-08 10:36 ` Guennadi Liakhovetski
2013-04-08 10:36 ` Guennadi Liakhovetski
2013-04-08 15:20 ` Sylwester Nawrocki [this message]
2013-04-08 15:20 ` Sylwester Nawrocki
2013-03-21 8:19 ` Prabhakar Lad
2013-03-21 8:31 ` Prabhakar Lad
2013-03-21 9:10 ` Anatolij Gustschin
2013-03-21 9:10 ` Anatolij Gustschin
2013-03-21 9:13 ` Prabhakar Lad
2013-03-21 9:25 ` Prabhakar Lad
2013-03-15 21:27 ` [PATCH v6 2/7] media: V4L2: support asynchronous subdevice registration Guennadi Liakhovetski
2013-03-15 21:27 ` Guennadi Liakhovetski
2013-03-26 23:41 ` Laurent Pinchart
2013-03-26 23:41 ` Laurent Pinchart
2013-03-15 21:27 ` [PATCH v6 3/7] media: soc-camera: switch I2C subdevice drivers to use v4l2-clk Guennadi Liakhovetski
2013-03-15 21:27 ` Guennadi Liakhovetski
2013-03-18 7:47 ` Hans Verkuil
2013-03-18 7:47 ` Hans Verkuil
2013-03-18 10:08 ` Guennadi Liakhovetski
2013-03-18 10:08 ` Guennadi Liakhovetski
2013-03-18 10:23 ` Hans Verkuil
2013-03-18 10:23 ` Hans Verkuil
2013-03-18 22:48 ` Sylwester Nawrocki
2013-03-18 22:48 ` Sylwester Nawrocki
2013-03-26 23:54 ` Laurent Pinchart
2013-03-26 23:54 ` Laurent Pinchart
2013-04-08 10:53 ` Guennadi Liakhovetski
2013-04-08 10:53 ` Guennadi Liakhovetski
2013-03-15 21:27 ` [PATCH v6 4/7] soc-camera: add V4L2-async support Guennadi Liakhovetski
2013-03-15 21:27 ` Guennadi Liakhovetski
2013-03-15 21:27 ` [PATCH v6 5/7] sh_mobile_ceu_camera: add asynchronous subdevice probing support Guennadi Liakhovetski
2013-03-15 21:27 ` Guennadi Liakhovetski
2013-03-15 21:27 ` [PATCH v6 6/7] imx074: support asynchronous probing Guennadi Liakhovetski
2013-03-15 21:27 ` Guennadi Liakhovetski
2013-03-15 21:27 ` [PATCH v6 7/7] ARM: shmobile: convert ap4evb to asynchronously register camera subdevices Guennadi Liakhovetski
2013-03-15 21:27 ` Guennadi Liakhovetski
2013-03-19 3:36 ` Simon Horman
2013-03-19 3:36 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5162E043.9050103@samsung.com \
--to=s.nawrocki@samsung.com \
--cc=g.liakhovetski@gmx.de \
--cc=hverkuil@xs4all.nl \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-media@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=magnus.damm@gmail.com \
--cc=prabhakar.lad@ti.com \
--cc=sakari.ailus@iki.fi \
--cc=sylvester.nawrocki@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.