All of lore.kernel.org
 help / color / mirror / Atom feed
From: linfeng@cn.fujitsu.com (Lin Feng)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/2] mm: vmemmap: arm64: add vmemmap_verify check for hot-add node case
Date: Tue, 09 Apr 2013 10:07:11 +0800	[thread overview]
Message-ID: <516377CF.2080004@cn.fujitsu.com> (raw)
In-Reply-To: <20130408105556.GB17476@mudshark.cambridge.arm.com>

Hi will,

On 04/08/2013 06:55 PM, Will Deacon wrote:
> Given that we don't have NUMA support or memory-hotplug on arm64 yet, I'm
> not sure that this change makes much sense at the moment. early_pfn_to_nid
> will always return 0 and we only ever have one node.
> 
> To be honest, I'm not sure what that vmemmap_verify check is trying to
> achieve anyway. ia64 does some funky node affinity initialisation early on
> but, for the rest of us, it looks like we always just check the distance
> from node 0.

Sorry for my noise to arm people.

Yes, not everyone cares about vmemmap_verify(), as you described it's not
necessary to arm64 at all. 

thanks,
linfeng

WARNING: multiple messages have this Message-ID (diff)
From: Lin Feng <linfeng@cn.fujitsu.com>
To: Will Deacon <will.deacon@arm.com>
Cc: "akpm@linux-foundation.org" <akpm@linux-foundation.org>,
	"cl@linux.com" <cl@linux.com>,
	"tglx@linutronix.de" <tglx@linutronix.de>,
	"mingo@redhat.com" <mingo@redhat.com>,
	"hpa@zytor.com" <hpa@zytor.com>,
	"yinghai@kernel.org" <yinghai@kernel.org>,
	Catalin Marinas <Catalin.Marinas@arm.com>,
	"arnd@arndb.de" <arnd@arndb.de>,
	"tony@atomide.com" <tony@atomide.com>,
	"ben@decadent.org.uk" <ben@decadent.org.uk>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"x86@kernel.org" <x86@kernel.org>,
	"linux-mm@kvack.org" <linux-mm@kvack.org>,
	"isimatu.yasuaki@jp.fujitsu.com" <isimatu.yasuaki@jp.fujitsu.com>
Subject: Re: [PATCH 2/2] mm: vmemmap: arm64: add vmemmap_verify check for hot-add node case
Date: Tue, 09 Apr 2013 10:07:11 +0800	[thread overview]
Message-ID: <516377CF.2080004@cn.fujitsu.com> (raw)
In-Reply-To: <20130408105556.GB17476@mudshark.cambridge.arm.com>

Hi will,

On 04/08/2013 06:55 PM, Will Deacon wrote:
> Given that we don't have NUMA support or memory-hotplug on arm64 yet, I'm
> not sure that this change makes much sense at the moment. early_pfn_to_nid
> will always return 0 and we only ever have one node.
> 
> To be honest, I'm not sure what that vmemmap_verify check is trying to
> achieve anyway. ia64 does some funky node affinity initialisation early on
> but, for the rest of us, it looks like we always just check the distance
> from node 0.

Sorry for my noise to arm people.

Yes, not everyone cares about vmemmap_verify(), as you described it's not
necessary to arm64 at all. 

thanks,
linfeng

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

WARNING: multiple messages have this Message-ID (diff)
From: Lin Feng <linfeng@cn.fujitsu.com>
To: Will Deacon <will.deacon@arm.com>
Cc: "akpm@linux-foundation.org" <akpm@linux-foundation.org>,
	"cl@linux.com" <cl@linux.com>,
	"tglx@linutronix.de" <tglx@linutronix.de>,
	"mingo@redhat.com" <mingo@redhat.com>,
	"hpa@zytor.com" <hpa@zytor.com>,
	"yinghai@kernel.org" <yinghai@kernel.org>,
	Catalin Marinas <Catalin.Marinas@arm.com>,
	"arnd@arndb.de" <arnd@arndb.de>,
	"tony@atomide.com" <tony@atomide.com>,
	"ben@decadent.org.uk" <ben@decadent.org.uk>,
	"linux-arm-kernel@lists.infradead.org" 
	<linux-arm-kernel@lists.infradead.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"x86@kernel.org" <x86@kernel.org>,
	"linux-mm@kvack.org" <linux-mm@kvack.org>,
	"isimatu.yasuaki@jp.fujitsu.com" <isimatu.yasuaki@jp.fujitsu.com>
Subject: Re: [PATCH 2/2] mm: vmemmap: arm64: add vmemmap_verify check for hot-add node case
Date: Tue, 09 Apr 2013 10:07:11 +0800	[thread overview]
Message-ID: <516377CF.2080004@cn.fujitsu.com> (raw)
In-Reply-To: <20130408105556.GB17476@mudshark.cambridge.arm.com>

Hi will,

On 04/08/2013 06:55 PM, Will Deacon wrote:
> Given that we don't have NUMA support or memory-hotplug on arm64 yet, I'm
> not sure that this change makes much sense at the moment. early_pfn_to_nid
> will always return 0 and we only ever have one node.
> 
> To be honest, I'm not sure what that vmemmap_verify check is trying to
> achieve anyway. ia64 does some funky node affinity initialisation early on
> but, for the rest of us, it looks like we always just check the distance
> from node 0.

Sorry for my noise to arm people.

Yes, not everyone cares about vmemmap_verify(), as you described it's not
necessary to arm64 at all. 

thanks,
linfeng

  reply	other threads:[~2013-04-09  2:07 UTC|newest]

Thread overview: 39+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-04-08  9:56 [PATCH 0/2] mm: vmemmap: add vmemmap_verify check for hot-add node/memory case Lin Feng
2013-04-08  9:56 ` Lin Feng
2013-04-08  9:56 ` Lin Feng
2013-04-08  9:56 ` [PATCH 1/2] mm: vmemmap: x86: add vmemmap_verify check for hot-add node case Lin Feng
2013-04-08  9:56   ` Lin Feng
2013-04-08  9:56   ` Lin Feng
2013-04-08 10:23   ` Lin Feng
2013-04-08 10:23     ` Lin Feng
2013-04-08 10:23     ` Lin Feng
2013-04-08  9:56 ` [PATCH 2/2] mm: vmemmap: arm64: " Lin Feng
2013-04-08  9:56   ` Lin Feng
2013-04-08  9:56   ` Lin Feng
2013-04-08 10:55   ` Will Deacon
2013-04-08 10:55     ` Will Deacon
2013-04-08 10:55     ` Will Deacon
2013-04-09  2:07     ` Lin Feng [this message]
2013-04-09  2:07       ` Lin Feng
2013-04-09  2:07       ` Lin Feng
2013-04-08 18:40 ` [PATCH 0/2] mm: vmemmap: add vmemmap_verify check for hot-add node/memory case Yinghai Lu
2013-04-08 18:40   ` Yinghai Lu
2013-04-08 18:40   ` Yinghai Lu
2013-04-08 20:55   ` Andrew Morton
2013-04-08 20:55     ` Andrew Morton
2013-04-08 20:55     ` Andrew Morton
2013-04-09  1:58     ` Lin Feng
2013-04-09  1:58       ` Lin Feng
2013-04-09  1:58       ` Lin Feng
2013-04-09  2:02   ` Lin Feng
2013-04-09  2:02     ` Lin Feng
2013-04-09  2:02     ` Lin Feng
2013-04-11  7:41   ` Tang Chen
2013-04-11  7:41     ` Tang Chen
2013-04-11  7:41     ` Tang Chen
2013-04-11 15:10     ` Yinghai Lu
2013-04-11 15:10       ` Yinghai Lu
2013-04-11 15:10       ` Yinghai Lu
2013-04-12  1:13       ` Tang Chen
2013-04-12  1:13         ` Tang Chen
2013-04-12  1:13         ` Tang Chen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=516377CF.2080004@cn.fujitsu.com \
    --to=linfeng@cn.fujitsu.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.