From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: phil.edworthy@renesas.com
Cc: Simon Horman <horms@verge.net.au>,
linux-sh@vger.kernel.org, netdev@vger.kernel.org,
nobuhiro.iwamatsu.yj@renesas.com
Subject: Re: [PATCH 2/2] sh_eth: add R-Car support for real
Date: Tue, 09 Apr 2013 13:08:46 +0000 [thread overview]
Message-ID: <516412DE.8020007@cogentembedded.com> (raw)
In-Reply-To: <OF927F8D41.407FE3E6-ON80257B47.004FDFDA-80257B47.005090A7@eu.necel.com>
Hello.
On 08-04-2013 18:40, phil.edworthy@renesas.com wrote:
> Thanks for the patch. When I added r8a7779 support, I had a rather poor
> manual with a lot of information missing. I submitted the patch once I got
> the driver working on a Marzen board, with an REE Expansion Board.
That must be 3rd type of the expansion board even. I have documentation on
some Y-R-CAR-H1-BOARD-EXP board, and I have the R0P7779A00020S board mounted
below Marzen. They seem very different as the latter don't have any switches
on it.
> One of the main changes you have made is adjusting the offset of the
> control registers. When I did this work originally, I just assumed that
> the base address start at 0x1DE00200, i.e. it included the 0x200 offset.
> This made sense as the registers are then identically positioned to sh4a.
Yes, but not all SH4 registers exist on R-Car and the Ether base is
0xFDE00000 according to the datasheet.
> Regards
> Phil
WBR, Sergei
WARNING: multiple messages have this Message-ID (diff)
From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: phil.edworthy@renesas.com
Cc: Simon Horman <horms@verge.net.au>,
linux-sh@vger.kernel.org, netdev@vger.kernel.org,
nobuhiro.iwamatsu.yj@renesas.com
Subject: Re: [PATCH 2/2] sh_eth: add R-Car support for real
Date: Tue, 09 Apr 2013 17:08:46 +0400 [thread overview]
Message-ID: <516412DE.8020007@cogentembedded.com> (raw)
In-Reply-To: <OF927F8D41.407FE3E6-ON80257B47.004FDFDA-80257B47.005090A7@eu.necel.com>
Hello.
On 08-04-2013 18:40, phil.edworthy@renesas.com wrote:
> Thanks for the patch. When I added r8a7779 support, I had a rather poor
> manual with a lot of information missing. I submitted the patch once I got
> the driver working on a Marzen board, with an REE Expansion Board.
That must be 3rd type of the expansion board even. I have documentation on
some Y-R-CAR-H1-BOARD-EXP board, and I have the R0P7779A00020S board mounted
below Marzen. They seem very different as the latter don't have any switches
on it.
> One of the main changes you have made is adjusting the offset of the
> control registers. When I did this work originally, I just assumed that
> the base address start at 0x1DE00200, i.e. it included the 0x200 offset.
> This made sense as the registers are then identically positioned to sh4a.
Yes, but not all SH4 registers exist on R-Car and the Ether base is
0xFDE00000 according to the datasheet.
> Regards
> Phil
WBR, Sergei
next prev parent reply other threads:[~2013-04-09 13:08 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-28 20:50 [PATCH 2/2] sh_eth: add R-Car support for real Sergei Shtylyov
2013-03-28 21:51 ` Sergei Shtylyov
2013-03-29 19:31 ` David Miller
2013-03-29 19:31 ` David Miller
2013-04-08 2:39 ` Simon Horman
2013-04-08 2:39 ` Simon Horman
2013-04-08 9:04 ` Simon Horman
2013-04-08 9:04 ` Simon Horman
2013-04-08 13:45 ` Sergei Shtylyov
2013-04-08 13:45 ` Sergei Shtylyov
2013-04-08 14:40 ` phil.edworthy
2013-04-08 14:40 ` phil.edworthy
2013-04-09 13:08 ` Sergei Shtylyov [this message]
2013-04-09 13:08 ` Sergei Shtylyov
2013-04-08 13:34 ` Sergei Shtylyov
2013-04-08 13:34 ` Sergei Shtylyov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=516412DE.8020007@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=horms@verge.net.au \
--cc=linux-sh@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nobuhiro.iwamatsu.yj@renesas.com \
--cc=phil.edworthy@renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.