From: Eduardo Valentin <eduardo.valentin@ti.com>
To: Andrew Bresticker <abrestic@google.com>
Cc: Eduardo Valentin <eduardo.valentin@ti.com>,
Zhang Rui <rui.zhang@intel.com>,
linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] thermal: fix frequency table lookup bugs
Date: Tue, 9 Apr 2013 14:33:14 -0400 [thread overview]
Message-ID: <51645EEA.4070907@ti.com> (raw)
In-Reply-To: <CAL1qeaEbakXL1wpURSGDJ=_FojoJ7DO4CJtj+pwPh32fufwjDQ@mail.gmail.com>
On 09-04-2013 14:27, Andrew Bresticker wrote:
>> You do two things in this change on cpu_cooling.c: (1) fix the case where
>> the loop is kept running indefinitely. (2) Reserve a specific role for each
>> index in this function.
>
> So the issue is that the changes are not independent. With just the
> fix for the infinite loop, get_cpu_frequency() is still completely
> broken because it is not interpreting the level correctly and will
> return the wrong frequency (and thus not throttling correctly, which
> is bad). Perhaps the commit should be more general, like "fix
> handling of invalid frequency table entries"? What do you think?
It fits better. I am OK if we improve the commit title and description,
providing better explanation of what is the issue (you have done
already) and how what needed to be done to fix it.
>
> Thanks,
> Andrew
>
>
WARNING: multiple messages have this Message-ID (diff)
From: Eduardo Valentin <eduardo.valentin@ti.com>
To: Andrew Bresticker <abrestic@google.com>
Cc: Eduardo Valentin <eduardo.valentin@ti.com>,
Zhang Rui <rui.zhang@intel.com>, <linux-pm@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] thermal: fix frequency table lookup bugs
Date: Tue, 9 Apr 2013 14:33:14 -0400 [thread overview]
Message-ID: <51645EEA.4070907@ti.com> (raw)
In-Reply-To: <CAL1qeaEbakXL1wpURSGDJ=_FojoJ7DO4CJtj+pwPh32fufwjDQ@mail.gmail.com>
On 09-04-2013 14:27, Andrew Bresticker wrote:
>> You do two things in this change on cpu_cooling.c: (1) fix the case where
>> the loop is kept running indefinitely. (2) Reserve a specific role for each
>> index in this function.
>
> So the issue is that the changes are not independent. With just the
> fix for the infinite loop, get_cpu_frequency() is still completely
> broken because it is not interpreting the level correctly and will
> return the wrong frequency (and thus not throttling correctly, which
> is bad). Perhaps the commit should be more general, like "fix
> handling of invalid frequency table entries"? What do you think?
It fits better. I am OK if we improve the commit title and description,
providing better explanation of what is the issue (you have done
already) and how what needed to be done to fix it.
>
> Thanks,
> Andrew
>
>
next prev parent reply other threads:[~2013-04-09 18:33 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-08 23:54 [PATCH] thermal: fix frequency table lookup bugs Andrew Bresticker
2013-04-09 14:55 ` Eduardo Valentin
2013-04-09 14:55 ` Eduardo Valentin
2013-04-09 17:02 ` Andrew Bresticker
2013-04-09 17:21 ` Eduardo Valentin
2013-04-09 17:21 ` Eduardo Valentin
2013-04-09 18:27 ` Andrew Bresticker
2013-04-09 18:33 ` Eduardo Valentin [this message]
2013-04-09 18:33 ` Eduardo Valentin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51645EEA.4070907@ti.com \
--to=eduardo.valentin@ti.com \
--cc=abrestic@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rui.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.