From: Jon Hunter <jon-hunter@ti.com>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: Grant Likely <grant.likely@secretlab.ca>,
Santosh Shilimkar <santosh.shilimkar@ti.com>,
Kevin Hilman <khilman@linaro.org>,
device-tree <devicetree-discuss@lists.ozlabs.org>,
linux-omap <linux-omap@vger.kernel.org>,
linux-arm <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH 1/5] gpio/omap: free irq domain in probe() failure paths
Date: Wed, 10 Apr 2013 14:48:17 -0500 [thread overview]
Message-ID: <5165C201.8010500@ti.com> (raw)
In-Reply-To: <CACRpkdbGw8_eL2KbXU2FxSrDof=O_5tA+siZDLvTqERqa650wA@mail.gmail.com>
On 04/10/2013 02:33 PM, Linus Walleij wrote:
> On Thu, Apr 4, 2013 at 10:16 PM, Jon Hunter <jon-hunter@ti.com> wrote:
>
>> Currently the IRQ domain is not freed once allocated, in the case where
>> omap_gpio_probe() fails. Therefore, ensure we free the domain if the
>> probe does fail. Furthermore, the local variable "ret" is not needed
>> and so remove this.
>>
>> Signed-off-by: Jon Hunter <jon-hunter@ti.com>
>
> Hm Kevin is still listed as maintainer on this driver but on a mail
> address that bounces, can you send a patch replacing him in MAINTAINERS
> with yourself if you're willing to pick it up?
>
> Anyway, patch applied.
Thanks. There is a patch to fix this queued for v3.10 [1].
Cheers
Jon
[1]
http://git.kernel.org/cgit/linux/kernel/git/arm/arm-soc.git/commit/MAINTAINERS?h=for-next&id=c69d72aec52eb5234f433259ac5dcc3b68f1480d
WARNING: multiple messages have this Message-ID (diff)
From: jon-hunter@ti.com (Jon Hunter)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/5] gpio/omap: free irq domain in probe() failure paths
Date: Wed, 10 Apr 2013 14:48:17 -0500 [thread overview]
Message-ID: <5165C201.8010500@ti.com> (raw)
In-Reply-To: <CACRpkdbGw8_eL2KbXU2FxSrDof=O_5tA+siZDLvTqERqa650wA@mail.gmail.com>
On 04/10/2013 02:33 PM, Linus Walleij wrote:
> On Thu, Apr 4, 2013 at 10:16 PM, Jon Hunter <jon-hunter@ti.com> wrote:
>
>> Currently the IRQ domain is not freed once allocated, in the case where
>> omap_gpio_probe() fails. Therefore, ensure we free the domain if the
>> probe does fail. Furthermore, the local variable "ret" is not needed
>> and so remove this.
>>
>> Signed-off-by: Jon Hunter <jon-hunter@ti.com>
>
> Hm Kevin is still listed as maintainer on this driver but on a mail
> address that bounces, can you send a patch replacing him in MAINTAINERS
> with yourself if you're willing to pick it up?
>
> Anyway, patch applied.
Thanks. There is a patch to fix this queued for v3.10 [1].
Cheers
Jon
[1]
http://git.kernel.org/cgit/linux/kernel/git/arm/arm-soc.git/commit/MAINTAINERS?h=for-next&id=c69d72aec52eb5234f433259ac5dcc3b68f1480d
next prev parent reply other threads:[~2013-04-10 19:48 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-04 20:16 [PATCH 0/5] gpio/omap: 2nd batch of updates for v3.10 Jon Hunter
2013-04-04 20:16 ` Jon Hunter
2013-04-04 20:16 ` [PATCH 1/5] gpio/omap: free irq domain in probe() failure paths Jon Hunter
2013-04-04 20:16 ` Jon Hunter
2013-04-10 19:33 ` Linus Walleij
2013-04-10 19:33 ` Linus Walleij
2013-04-10 19:48 ` Jon Hunter [this message]
2013-04-10 19:48 ` Jon Hunter
2013-04-15 22:06 ` Kevin Hilman
2013-04-15 22:06 ` Kevin Hilman
2013-04-04 20:16 ` [PATCH 2/5] gpio/omap: remove extra context restores in *_runtime_resume() Jon Hunter
2013-04-04 20:16 ` Jon Hunter
2013-04-10 19:34 ` Linus Walleij
2013-04-10 19:34 ` Linus Walleij
2013-04-04 20:16 ` [PATCH 3/5] gpio/omap: optimise interrupt service routine Jon Hunter
2013-04-04 20:16 ` Jon Hunter
2013-04-05 9:19 ` Felipe Balbi
2013-04-05 9:19 ` Felipe Balbi
2013-04-10 19:37 ` Linus Walleij
2013-04-10 19:37 ` Linus Walleij
2013-04-04 20:16 ` [PATCH 4/5] gpio/omap: force restore if context loss is not detectable Jon Hunter
2013-04-04 20:16 ` Jon Hunter
2013-04-10 19:39 ` Linus Walleij
2013-04-10 19:39 ` Linus Walleij
[not found] ` <CACRpkdbeABuFXr0Gt6gRto3Pmo0m88AFn_xKJq14VonGg7Doww-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2013-04-10 19:41 ` Jon Hunter
2013-04-10 19:41 ` Jon Hunter
2013-04-10 19:44 ` Linus Walleij
2013-04-10 19:44 ` Linus Walleij
2013-04-10 19:50 ` Jon Hunter
2013-04-10 19:50 ` Jon Hunter
2013-04-10 20:47 ` Linus Walleij
2013-04-10 20:47 ` Linus Walleij
2013-04-04 20:16 ` [PATCH 5/5] ARM: dts: OMAP2+: Identify GPIO banks that are always powered Jon Hunter
2013-04-04 20:16 ` Jon Hunter
2013-04-04 20:35 ` Tony Lindgren
2013-04-04 20:35 ` Tony Lindgren
2013-04-04 21:01 ` Jon Hunter
2013-04-04 21:01 ` Jon Hunter
2013-04-04 21:08 ` Tony Lindgren
2013-04-04 21:08 ` Tony Lindgren
2013-04-05 6:35 ` [PATCH 0/5] gpio/omap: 2nd batch of updates for v3.10 Santosh Shilimkar
2013-04-05 6:35 ` Santosh Shilimkar
2013-04-05 12:18 ` Jon Hunter
2013-04-05 12:18 ` Jon Hunter
2013-04-05 17:56 ` Kevin Hilman
2013-04-05 17:56 ` Kevin Hilman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5165C201.8010500@ti.com \
--to=jon-hunter@ti.com \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=grant.likely@secretlab.ca \
--cc=khilman@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=santosh.shilimkar@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.