All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jeremy Linton <jlinton@tributary.com>
To: "Ewan D. Milne" <emilne@redhat.com>
Cc: "linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>
Subject: Re: [PATCH v2 0/8] [SCSI] Enhanced sense and Unit Attention handling
Date: Thu, 11 Apr 2013 16:52:33 -0500	[thread overview]
Message-ID: <516730A1.4090302@tributary.com> (raw)
In-Reply-To: <1359741195-2641-1-git-send-email-emilne@redhat.com>

On 2/1/2013 11:53 AM, Ewan D. Milne wrote:
> The mechanism used is to flag when certain UA ASC/ASCQ codes are received 
> that report asynchronous changes to the storage device configuration. An
> appropriate uevent is then generated for the scsi_device or scsi_target 
> object.  An aggregation mechanism is used to avoid generating uevents at 
> too high a rate, and to coalesce multiple UAs reported by LUNs on the same
> target for a REPORTED LUNS DATA HAS CHANGED sense code.


	What happened to this patch? The trail of suggested fixes for the REPORT LUNS
DATA HAS CHANGED check condition is getting pretty long. The number of devices
(our product included) in the field that have the ability to on the fly modify
the luns on an I_T nexus is not decreasing.

	Is it because these patches are trying to fix more than one thing?

	What is the preferred way to fix this?

	Why not simply add a couple sdev_evt_send_simple()'s and an event coalesce
function to collapse this event when its received from multiple LUNs on the
I_T? A couple extra uevents isn't going to kill udev right? A really fancy
patch could attempt to clear the check conditions from LUNs that share the I_T.

	





  parent reply	other threads:[~2013-04-11 21:52 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-02-01 17:53 [PATCH v2 0/8] [SCSI] Enhanced sense and Unit Attention handling Ewan D. Milne
2013-02-01 17:53 ` [PATCH v2 1/8] [SCSI] Generate uevent on sd capacity change Ewan D. Milne
2013-02-01 17:53 ` [PATCH v2 2/8] [SCSI] Add a kernel config option for enhanced Unit Attention support Ewan D. Milne
2013-02-01 17:53 ` [PATCH v2 3/8] [SCSI] Rename scsi_evt_xxx to sdev_evt_xxx and scsi_event to sdev_event Ewan D. Milne
2013-02-01 17:53 ` [PATCH v2 4/8] [SCSI] Add support for scsi_target events Ewan D. Milne
2013-02-01 17:53 ` [PATCH v2 5/8] [SCSI] Generate uevents for certain Unit Attention codes Ewan D. Milne
2013-02-01 17:53 ` [PATCH v2 6/8] [SCSI] Add sysfs support for enhanced Unit Attention handling Ewan D. Milne
2013-02-01 17:53 ` [PATCH v2 7/8] [SCSI] Add sense and Unit Attention generation to scsi_debug Ewan D. Milne
2013-02-01 17:53 ` [PATCH v2 8/8] [SCSI] Streamline detection of FM/EOM/ILI status Ewan D. Milne
2013-04-11 21:52 ` Jeremy Linton [this message]
2013-04-15 14:13   ` [PATCH v2 0/8] [SCSI] Enhanced sense and Unit Attention handling Ewan Milne
2013-04-15 16:20     ` Jeremy Linton
2013-04-15 16:51       ` Ewan Milne

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=516730A1.4090302@tributary.com \
    --to=jlinton@tributary.com \
    --cc=emilne@redhat.com \
    --cc=linux-scsi@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.