From: Gabor Juhos <juhosg@openwrt.org>
To: John Crispin <blogic@openwrt.org>
Cc: Ralf Baechle <ralf@linux-mips.org>, linux-mips@linux-mips.org
Subject: Re: [PATCH V2 06/16] MIPS: ralink: extend RT3050 dtsi file
Date: Fri, 12 Apr 2013 11:22:36 +0200 [thread overview]
Message-ID: <5167D25C.7060406@openwrt.org> (raw)
In-Reply-To: <1365751663-5725-6-git-send-email-blogic@openwrt.org>
2013.04.12. 9:27 keltezéssel, John Crispin írta:
> Add some additional properties to the dtsi file for ethernet and wifi.
Apart from the changes described here, you are doing various other changes as
well. See below.
>
> Signed-off-by: John Crispin <blogic@openwrt.org>
> ---
> arch/mips/ralink/dts/rt3050.dtsi | 96 ++++++++++++++++++++++++++++------
> arch/mips/ralink/dts/rt3052_eval.dts | 2 +-
> 2 files changed, 82 insertions(+), 16 deletions(-)
>
> diff --git a/arch/mips/ralink/dts/rt3050.dtsi b/arch/mips/ralink/dts/rt3050.dtsi
> index 069d066..5aede8d 100644
> --- a/arch/mips/ralink/dts/rt3050.dtsi
> +++ b/arch/mips/ralink/dts/rt3050.dtsi
> @@ -1,7 +1,7 @@
> / {
> #address-cells = <1>;
> #size-cells = <1>;
> - compatible = "ralink,rt3050-soc", "ralink,rt3052-soc";
> + compatible = "ralink,rt3050-soc", "ralink,rt3052-soc", "ralink,rt3350-soc";
This adds a new compatible property but the binding documentation is missing.
>
> cpus {
> cpu@0 {
> @@ -23,7 +23,7 @@
> palmbus@10000000 {
> compatible = "palmbus";
> reg = <0x10000000 0x200000>;
> - ranges = <0x0 0x10000000 0x1FFFFF>;
> + ranges = <0x0 0x10000000 0x1FFFFF>;
This is a whitespace change.
>
> #address-cells = <1>;
> #size-cells = <1>;
> @@ -34,8 +34,18 @@
> };
>
> timer@100 {
> + compatible = "ralink,rt3052-timer", "ralink,rt2880-timer";
Another compatible properties without documentation, and we don't even have
driver for this. You should add this only when the driver and the binding
documentation is ready.
Additionally, the hunk is not related to ethernet and wifi at all.
> + reg = <0x100 0x20>;
> +
> + interrupt-parent = <&intc>;
> + interrupts = <1>;
> +
> + status = "disabled";
> + };
> +
> + watchdog@120 {
> compatible = "ralink,rt3052-wdt", "ralink,rt2880-wdt";
> - reg = <0x100 0x100>;
> + reg = <0x120 0x10>;
> };
>
> intc: intc@200 {
> @@ -61,10 +71,12 @@
> gpio-controller;
> #gpio-cells = <2>;
>
> - ralink,ngpio = <24>;
> - ralink,regs = [ 00 04 08 0c
> - 20 24 28 2c
> - 30 34 ];
> + ralink,num-gpios = <24>;
> + ralink,register-map = [ 00 04 08 0c
> + 20 24 28 2c
> + 30 34 ];
> +
You are lucky here because we don't not have binding documentation for these
properties. Otherwise it would not be allowed to blindly change the names. And
again, this is not related to the subject. Fix the property names once the GPIO
driver is accepted, or fix it in the GPIO driver patch itself.
> + status = "disabled";
> };
>
> gpio1: gpio@638 {
> @@ -74,10 +86,12 @@
> gpio-controller;
> #gpio-cells = <2>;
>
> - ralink,ngpio = <16>;
> - ralink,regs = [ 00 04 08 0c
> - 10 14 18 1c
> - 20 24 ];
> + ralink,num-gpios = <16>;
> + ralink,register-map = [ 00 04 08 0c
> + 10 14 18 1c
> + 20 24 ];
> +
> + status = "disabled";
> };
>
> gpio2: gpio@660 {
> @@ -87,10 +101,21 @@
> gpio-controller;
> #gpio-cells = <2>;
>
> - ralink,ngpio = <12>;
> - ralink,regs = [ 00 04 08 0c
> - 10 14 18 1c
> - 20 24 ];
> + ralink,num-gpios = <12>;
> + ralink,register-map = [ 00 04 08 0c
> + 10 14 18 1c
> + 20 24 ];
> +
> + status = "disabled";
> + };
> +
> + spi@b00 {
> + compatible = "ralink,rt3050-spi", "ralink,rt2880-spi";
-ENODOCUMENTATION & -ENODRIVER.
> + reg = <0xb00 0x100>;
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + status = "disabled";
> };
>
> uartlite@c00 {
> @@ -102,5 +127,46 @@
>
> reg-shift = <2>;
> };
> +
> + };
> +
> + ethernet@10100000 {
> + compatible = "ralink,rt3050-eth";
-ENODOCUMENTATION & -ENODRIVER.
> + reg = <0x10100000 10000>;
> +
> + interrupt-parent = <&cpuintc>;
> + interrupts = <5>;
> +
> + status = "disabled";
> + };
> +
> + esw@10110000 {
> + compatible = "ralink,rt3050-esw";
-ENODOCUMENTATION & -ENODRIVER.
> + reg = <0x10110000 8000>;
> +
> + interrupt-parent = <&intc>;
> + interrupts = <17>;
> +
> + status = "disabled";
> + };
> +
> + wmac@10180000 {
> + compatible = "ralink,rt3050-wmac", "ralink,rt2880-wmac";
-ENODOCUMENTATION & -ENODRIVER.
> + reg = <0x10180000 40000>;
> +
> + interrupt-parent = <&cpuintc>;
> + interrupts = <6>;
> +
> + status = "disabled";
> + };
> +
> + otg@101c0000 {
> + compatible = "ralink,rt3050-otg";
-ENODOCUMENTATION & -ENODRIVER.
> + reg = <0x101c0000 40000>;
> +
> + interrupt-parent = <&intc>;
> + interrupts = <18>;
> +
> + status = "disabled";
> };
> };
> diff --git a/arch/mips/ralink/dts/rt3052_eval.dts b/arch/mips/ralink/dts/rt3052_eval.dts
> index 148a590..dc56e58 100644
> --- a/arch/mips/ralink/dts/rt3052_eval.dts
> +++ b/arch/mips/ralink/dts/rt3052_eval.dts
> @@ -14,7 +14,7 @@
>
> palmbus@10000000 {
> sysc@0 {
> - ralink,pinmmux = "uartlite", "spi";
> + ralink,pinmux = "uartlite", "spi";
This fixes a typo. Additionally, this change is not related to the RT3050.dtsi
file at all.
> ralink,uartmux = "gpio";
> ralink,wdtmux = <0>;
> };
>
And a final note, the devicetree-discuss list should be added to CC in case of
any DT specific patch.
-Gabor
next prev parent reply other threads:[~2013-04-12 9:22 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-12 7:27 [PATCH V2 01/16] MIPS: ralink: add PCI IRQ handling John Crispin
2013-04-12 7:27 ` [PATCH V2 02/16] MIPS: ralink: fix RT305x clock setup John Crispin
2013-04-12 8:22 ` Gabor Juhos
2013-04-12 8:21 ` John Crispin
2013-04-12 13:00 ` Sergei Shtylyov
2013-04-12 7:27 ` [PATCH V2 03/16] MIPS: ralink: add missing comment in irq driver John Crispin
2013-04-12 8:24 ` Gabor Juhos
2013-04-12 7:27 ` [PATCH V2 04/16] MIPS: ralink: add RT5350 sdram register defines John Crispin
2013-04-12 8:29 ` Gabor Juhos
2013-04-12 7:27 ` [PATCH V2 05/16] MIPS: ralink: add RT3352 usb " John Crispin
2013-04-12 8:47 ` Gabor Juhos
2013-04-12 7:27 ` [PATCH V2 06/16] MIPS: ralink: extend RT3050 dtsi file John Crispin
2013-04-12 9:22 ` Gabor Juhos [this message]
2013-04-12 7:27 ` [PATCH V2 07/16] MIPS: ralink: add RT5350 " John Crispin
2013-04-12 9:25 ` Gabor Juhos
2013-04-12 7:27 ` [PATCH V2 08/16] MIPS: ralink: make early_printk work on RT2880 John Crispin
2013-04-12 9:28 ` Gabor Juhos
2013-04-12 7:27 ` [PATCH V2 09/16] MIPS: ralink: adds support for RT2880 SoC family John Crispin
2013-04-12 11:12 ` Gabor Juhos
2013-04-12 11:19 ` John Crispin
2013-04-12 17:03 ` Gabor Juhos
2013-04-12 7:27 ` [PATCH V2 10/16] MIPS: ralink: add rt2880 dts files John Crispin
2013-04-12 7:27 ` [PATCH V2 11/16] MIPS: ralink: adds support for RT3883 SoC family John Crispin
2013-04-12 11:13 ` Gabor Juhos
2013-04-12 7:27 ` [PATCH V2 12/16] MIPS: ralink: add rt3883 dts files John Crispin
2013-04-12 7:27 ` [PATCH V2 13/16] MIPS: ralink: adds support for MT7620 SoC family John Crispin
2013-04-12 7:27 ` [PATCH V2 14/16] MIPS: ralink: add MT7620 dts files John Crispin
2013-04-12 7:27 ` [PATCH V2 15/16] MIPS: ralink: add support for periodic timer irq John Crispin
2013-04-12 16:35 ` Gabor Juhos
2013-04-12 7:27 ` [PATCH V2 16/16] MIPS: ralink: add cpu-feature-overrides.h John Crispin
2013-04-12 17:20 ` Gabor Juhos
2013-04-12 8:21 ` [PATCH V2 01/16] MIPS: ralink: add PCI IRQ handling Gabor Juhos
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5167D25C.7060406@openwrt.org \
--to=juhosg@openwrt.org \
--cc=blogic@openwrt.org \
--cc=linux-mips@linux-mips.org \
--cc=ralf@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.