From: "Gabriel M. Beddingfield" <gabrbedd@gmail.com>
To: Stas Sergeev <stsp@list.ru>
Cc: ALSA devel <alsa-devel@alsa-project.org>,
Mark Brown <broonie@opensource.wolfsonmicro.com>,
Lars-Peter Clausen <lars@metafoo.de>,
stsp@users.sourceforge.net
Subject: Re: [PATCH] ASoC: define playback and capture streams in dummy codec
Date: Fri, 12 Apr 2013 08:24:55 -0700 [thread overview]
Message-ID: <51682747.9070300@gmail.com> (raw)
In-Reply-To: <51682633.70008@list.ru>
On 04/12/2013 08:20 AM, Stas Sergeev wrote:
>> He means that the commit message. Your commit message says what the
>> patch does. It does not say why the patch is needed.
> Yes.
> But what should I add to the commit message, if the
> only thing I know about this patch, is that I am not getting
> any sound without it? :) The reason should be obvious for
> whoever is familiar with that subsystem, but its not me.
>
Yep, just formalize the "I am not getting any sound with it" statement.
:-) Maybe something like: "Because snd-soc-dummy didn't declare any
DAI, it was unable to be used for any audio streams."
-gabriel
next prev parent reply other threads:[~2013-04-12 15:25 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-12 10:53 [PATCH] ASoC: define playback and capture streams in dummy codec Stas Sergeev
2013-04-12 10:59 ` Mark Brown
2013-04-12 14:19 ` Stas Sergeev
2013-04-12 15:13 ` Gabriel M. Beddingfield
2013-04-12 15:20 ` Stas Sergeev
2013-04-12 15:24 ` Gabriel M. Beddingfield [this message]
2013-04-16 16:34 ` Stas Sergeev
2013-04-12 15:31 ` Lars-Peter Clausen
2013-04-12 16:37 ` Stas Sergeev
2013-04-12 16:55 ` Lars-Peter Clausen
2013-04-12 19:19 ` Stas Sergeev
2013-04-17 12:34 ` Stas Sergeev
2013-04-17 13:31 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51682747.9070300@gmail.com \
--to=gabrbedd@gmail.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=lars@metafoo.de \
--cc=stsp@list.ru \
--cc=stsp@users.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.