Re: [PATCH] ASoC: define playback and capture streams in dummy codec

[Stas Sergeev <stsp@list.ru>]

[-- Attachment #1: Type: text/plain, Size: 1004 bytes --]

12.04.2013 19:24, Gabriel M. Beddingfield пишет:
> On 04/12/2013 08:20 AM, Stas Sergeev wrote:
>>> He means that the commit message. Your commit message says what the
>>> patch does. It does not say why the patch is needed.
>> Yes.
>> But what should I add to the commit message, if the
>> only thing I know about this patch, is that I am not getting
>> any sound without it? :) The reason should be obvious for
>> whoever is familiar with that subsystem, but its not me.
>>
>
> Yep, just formalize the "I am not getting any sound with it"
> statement. :-)
Hi, Would something like the attached patch be good to
help formalizing this? With that patch I am getting:
---
[    2.800190] asoc: no playback or capture streams
available                  
[    2.805158] asoc: can't create pcm
Pri_Dai                                  
[    2.809241] asoc: failed to instantiate card I2S: -22
---
which is much better than before.
If I get any ACKs on this one, I'll submit it too.

[-- Attachment #2: a.diff --]
[-- Type: text/x-patch, Size: 568 bytes --]

diff --git a/sound/soc/soc-core.c b/sound/soc/soc-core.c
index 394fb3b..fb3a401 100644
--- a/sound/soc/soc-core.c
+++ b/sound/soc/soc-core.c
@@ -2140,6 +2140,11 @@ static int soc_new_pcm(struct snd_soc_pcm_runtime *rtd, int num)
 	if (codec_dai->driver->capture.channels_min)
 		capture = 1;
 
+	if (playback + capture == 0) {
+		pr_err("asoc: no playback or capture streams available\n");
+		return -EINVAL;
+	}
+
 	dev_dbg(rtd->card->dev, "registered pcm #%d %s\n",num,new_name);
 	ret = snd_pcm_new(rtd->card->snd_card, new_name,
 			num, playback, capture, &pcm);

[-- Attachment #3: Type: text/plain, Size: 0 bytes --]