All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tony Prisk <linux@prisktech.co.nz>
To: scott.liu@emc.com.tw
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
	Benjamin Tissoires <benjamin.tissoires@gmail.com>,
	Jesse <jesse@emc.com.tw>, Vincent Wang <vincent.wang@emc.com.tw>,
	Paul <paul.liang@emc.com.tw>,
	linux-input@vger.kernel.org, linux-i2c@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: [v3] Support Elan Touchscreen eKTF product.
Date: Sat, 13 Apr 2013 11:29:02 +1200	[thread overview]
Message-ID: <516898BE.8040209@prisktech.co.nz> (raw)

Hi Scott,

Not sure what is happening with the patch - seems to have been sitting 
for quite a while. Is it still being worked on?
I integrated it into our arm/arch-vt8500 testing tree (based on 3.9-rc6) 
as we have tablets with eKTF2127 controllers and noticed a few problems.

1) __devxxxx attributes cause unused function warnings because they are 
deprecated.

2) elants_get_power_state() is only called from elants_resume() which is 
contained within a #ifdef CONFIG_PM_SLEEP. You should also move the 
elants_get_power_state() inside the #ifdef to remove the unused_function 
warning when compiled without CONFIG_PM.

Regards
Tony Prisk

                 reply	other threads:[~2013-04-12 23:29 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=516898BE.8040209@prisktech.co.nz \
    --to=linux@prisktech.co.nz \
    --cc=benjamin.tissoires@gmail.com \
    --cc=dmitry.torokhov@gmail.com \
    --cc=jesse@emc.com.tw \
    --cc=linux-i2c@vger.kernel.org \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=paul.liang@emc.com.tw \
    --cc=scott.liu@emc.com.tw \
    --cc=vincent.wang@emc.com.tw \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.