All of lore.kernel.org
 help / color / mirror / Atom feed
* [v3] Support Elan Touchscreen eKTF product.
@ 2013-04-12 23:29 Tony Prisk
  0 siblings, 0 replies; only message in thread
From: Tony Prisk @ 2013-04-12 23:29 UTC (permalink / raw)
  To: scott.liu
  Cc: Dmitry Torokhov, Benjamin Tissoires, Jesse, Vincent Wang, Paul,
	linux-input, linux-i2c, linux-kernel

Hi Scott,

Not sure what is happening with the patch - seems to have been sitting 
for quite a while. Is it still being worked on?
I integrated it into our arm/arch-vt8500 testing tree (based on 3.9-rc6) 
as we have tablets with eKTF2127 controllers and noticed a few problems.

1) __devxxxx attributes cause unused function warnings because they are 
deprecated.

2) elants_get_power_state() is only called from elants_resume() which is 
contained within a #ifdef CONFIG_PM_SLEEP. You should also move the 
elants_get_power_state() inside the #ifdef to remove the unused_function 
warning when compiled without CONFIG_PM.

Regards
Tony Prisk

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2013-04-12 23:29 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-04-12 23:29 [v3] Support Elan Touchscreen eKTF product Tony Prisk

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.