From: Antti Palosaari <crope@iki.fi>
To: "Frank Schäfer" <fschaefer.oss@googlemail.com>
Cc: Mauro Carvalho Chehab <mchehab@redhat.com>, linux-media@vger.kernel.org
Subject: Re: [PATCH 0/3] em28xx: clean up end extend the GPIO port handling
Date: Sat, 13 Apr 2013 16:15:39 +0300 [thread overview]
Message-ID: <51695A7B.4010206@iki.fi> (raw)
In-Reply-To: <1365846521-3127-1-git-send-email-fschaefer.oss@googlemail.com>
On 04/13/2013 12:48 PM, Frank Schäfer wrote:
> Patch 1 removes the unneeded and broken gpio register caching code.
> Patch 2 adds the gpio register defintions for the em25xx/em276x/7x/8x
> and patch 3 finally adds a new helper function for gpio ports with separate
> registers for read and write access.
I have nothing to say directly about those patches - they looked good at
the quick check. But I wonder if you have any idea if it is possible to
use some existing Kernel GPIO functionality in order to provide standard
interface (interface like I2C). I did some work last summer in order to
use GPIOLIB and it is used between em28xx-dvb and cxd2820r for LNA
control. Anyhow, I was a little bit disappointed as GPIOLIB is disabled
by default and due to that there is macros to disable LNA when GPIOLIB
is not compiled.
I noticed recently there is some ongoing development for Kernel GPIO. I
haven't looked yet if it makes use of GPIO interface more common...
regards
Antti
--
http://palosaari.fi/
next prev parent reply other threads:[~2013-04-13 13:16 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-13 9:48 [PATCH 0/3] em28xx: clean up end extend the GPIO port handling Frank Schäfer
2013-04-13 9:48 ` [PATCH 1/3] em28xx: give up GPIO register tracking/caching Frank Schäfer
2013-04-13 14:41 ` Mauro Carvalho Chehab
2013-04-13 15:33 ` Frank Schäfer
2013-04-13 17:04 ` Mauro Carvalho Chehab
2013-04-13 17:46 ` Frank Schäfer
2013-04-13 18:08 ` Mauro Carvalho Chehab
2013-04-14 20:35 ` Frank Schäfer
2013-04-15 12:51 ` Mauro Carvalho Chehab
2013-04-15 14:11 ` Antti Palosaari
2013-04-15 16:26 ` Frank Schäfer
2013-04-15 23:01 ` Mauro Carvalho Chehab
2013-04-23 16:58 ` Frank Schäfer
2013-04-13 18:19 ` Frank Schäfer
2013-04-13 18:41 ` Frank Schäfer
2013-04-13 9:48 ` [PATCH 2/3] em28xx: add register defines for em25xx/em276x/7x/8x GPIO registers Frank Schäfer
2013-04-13 9:48 ` [PATCH 3/3] em28xx: add helper function for handling the GPIO registers of newer devices Frank Schäfer
2013-04-13 13:15 ` Antti Palosaari [this message]
2013-04-13 14:25 ` [PATCH 0/3] em28xx: clean up end extend the GPIO port handling Mauro Carvalho Chehab
2013-04-13 14:37 ` Antti Palosaari
2013-04-14 1:32 ` Mauro Carvalho Chehab
2013-04-14 19:32 ` Antti Palosaari
2013-04-15 14:40 ` Mauro Carvalho Chehab
2013-04-13 15:30 ` Frank Schäfer
2013-04-13 15:34 ` Devin Heitmueller
2013-04-13 16:21 ` Antti Palosaari
2013-04-13 16:54 ` Devin Heitmueller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51695A7B.4010206@iki.fi \
--to=crope@iki.fi \
--cc=fschaefer.oss@googlemail.com \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.