From: "Frank Schäfer" <fschaefer.oss@googlemail.com>
To: Mauro Carvalho Chehab <mchehab@redhat.com>
Cc: linux-media@vger.kernel.org
Subject: Re: [PATCH 1/3] em28xx: give up GPIO register tracking/caching
Date: Sat, 13 Apr 2013 20:41:36 +0200 [thread overview]
Message-ID: <5169A6E0.8060902@googlemail.com> (raw)
In-Reply-To: <5169A19F.6080407@googlemail.com>
Am 13.04.2013 20:19, schrieb Frank Schäfer:
> Am 13.04.2013 19:46, schrieb Frank Schäfer:
>> ...
>> We always write to the GPIO register. That's why these functions are
>> called em28xx_write_* ;)
>> Whether the write operation is sane or not (e.g. because it modifies the
>> bit corresponding to an input line) is not subject of these functions.
> Hmm... that's actually not true for em28xx_write_regs().
> The current/old code never writes the value to GPIO registers, it just
> saves it to the device struct.
Arghh... no ... please disregard this paragraph, I simply overlooked the
register write.
I have to stop for today, will try to get back to this tomorrow.
Regards,
Frank
next prev parent reply other threads:[~2013-04-13 18:40 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-13 9:48 [PATCH 0/3] em28xx: clean up end extend the GPIO port handling Frank Schäfer
2013-04-13 9:48 ` [PATCH 1/3] em28xx: give up GPIO register tracking/caching Frank Schäfer
2013-04-13 14:41 ` Mauro Carvalho Chehab
2013-04-13 15:33 ` Frank Schäfer
2013-04-13 17:04 ` Mauro Carvalho Chehab
2013-04-13 17:46 ` Frank Schäfer
2013-04-13 18:08 ` Mauro Carvalho Chehab
2013-04-14 20:35 ` Frank Schäfer
2013-04-15 12:51 ` Mauro Carvalho Chehab
2013-04-15 14:11 ` Antti Palosaari
2013-04-15 16:26 ` Frank Schäfer
2013-04-15 23:01 ` Mauro Carvalho Chehab
2013-04-23 16:58 ` Frank Schäfer
2013-04-13 18:19 ` Frank Schäfer
2013-04-13 18:41 ` Frank Schäfer [this message]
2013-04-13 9:48 ` [PATCH 2/3] em28xx: add register defines for em25xx/em276x/7x/8x GPIO registers Frank Schäfer
2013-04-13 9:48 ` [PATCH 3/3] em28xx: add helper function for handling the GPIO registers of newer devices Frank Schäfer
2013-04-13 13:15 ` [PATCH 0/3] em28xx: clean up end extend the GPIO port handling Antti Palosaari
2013-04-13 14:25 ` Mauro Carvalho Chehab
2013-04-13 14:37 ` Antti Palosaari
2013-04-14 1:32 ` Mauro Carvalho Chehab
2013-04-14 19:32 ` Antti Palosaari
2013-04-15 14:40 ` Mauro Carvalho Chehab
2013-04-13 15:30 ` Frank Schäfer
2013-04-13 15:34 ` Devin Heitmueller
2013-04-13 16:21 ` Antti Palosaari
2013-04-13 16:54 ` Devin Heitmueller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5169A6E0.8060902@googlemail.com \
--to=fschaefer.oss@googlemail.com \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.