All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Andreas Färber" <afaerber@suse.de>
To: fred.konrad@greensocs.com
Cc: peter.maydell@linaro.org, aliguori@us.ibm.com,
	mark.burton@greensocs.com, qemu-devel@nongnu.org,
	cornelia.huck@de.ibm.com, amit.shah@redhat.com
Subject: Re: [Qemu-devel] [PATCH v3 8/8] virtio-rng: cleanup: use QOM casts.
Date: Mon, 15 Apr 2013 15:34:22 +0200	[thread overview]
Message-ID: <516C01DE.6070309@suse.de> (raw)
In-Reply-To: <1365944470-13837-9-git-send-email-fred.konrad@greensocs.com>

Am 14.04.2013 15:01, schrieb fred.konrad@greensocs.com:
> From: KONRAD Frederic <fred.konrad@greensocs.com>
> 
> As the virtio-rng-pci and virtio-rng-s390 are switched to the new API,

and virtio-rng-ccw ;)

> we can use QOM casts.
> 
> Signed-off-by: KONRAD Frederic <fred.konrad@greensocs.com>
> ---
>  hw/virtio/virtio-rng.c         | 31 +++++++++++++++++--------------
>  include/hw/virtio/virtio-rng.h |  2 +-
>  2 files changed, 18 insertions(+), 15 deletions(-)

Thanks,

Reviewed-by: Andreas Färber <afaerber@suse.de>

I was surprised to see FOO(opaque) since we usually try to avoid it for
performance reasons, but it's not forbidden either.
Also, leaving the variable name as "s" would've spared a few lines but
so what. :)

Regards,
Andreas

-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg

  reply	other threads:[~2013-04-15 13:34 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-04-14 13:01 [Qemu-devel] [PATCH v3 0/8] virtio-rng refactoring fred.konrad
2013-04-14 13:01 ` [Qemu-devel] [PATCH v3 1/8] virtio-rng: don't use pointer for configuration fred.konrad
2013-04-14 13:01 ` [Qemu-devel] [PATCH v3 2/8] virtio-rng: add virtio-rng device fred.konrad
2013-04-14 13:01 ` [Qemu-devel] [PATCH v3 3/8] virtio-rng-pci: switch to the new API fred.konrad
2013-04-14 13:01 ` [Qemu-devel] [PATCH v3 4/8] virtio-rng-s390: " fred.konrad
2013-04-14 13:01 ` [Qemu-devel] [PATCH v3 5/8] virtio-rng-ccw: " fred.konrad
2013-04-14 13:01 ` [Qemu-devel] [PATCH v3 6/8] virtio-rng: cleanup: init and exit functions fred.konrad
2013-04-14 13:01 ` [Qemu-devel] [PATCH v3 7/8] virtio-rng: cleanup: remove qdev field fred.konrad
2013-04-14 13:01 ` [Qemu-devel] [PATCH v3 8/8] virtio-rng: cleanup: use QOM casts fred.konrad
2013-04-15 13:34   ` Andreas Färber [this message]
2013-04-15 14:33     ` KONRAD Frédéric
2013-04-15 17:06       ` Andreas Färber
2013-04-15 13:12 ` [Qemu-devel] [PATCH v3 0/8] virtio-rng refactoring Cornelia Huck
2013-04-16  9:51 ` Amit Shah

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=516C01DE.6070309@suse.de \
    --to=afaerber@suse.de \
    --cc=aliguori@us.ibm.com \
    --cc=amit.shah@redhat.com \
    --cc=cornelia.huck@de.ibm.com \
    --cc=fred.konrad@greensocs.com \
    --cc=mark.burton@greensocs.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.