From: "Andreas Färber" <afaerber@suse.de>
To: Igor Mammedov <imammedo@redhat.com>
Cc: aliguori@us.ibm.com, ehabkost@redhat.com,
claudio.fontana@huawei.com, qemu-devel@nongnu.org,
aderumier@odiso.com, lcapitulino@redhat.com,
jfrei@linux.vnet.ibm.com, yang.z.zhang@intel.com,
pbonzini@redhat.com, lig.fnst@cn.fujitsu.com, rth@twiddle.net
Subject: Re: [Qemu-devel] [PATCH 17/19] qdev: set device's parent before calling realize() down inheritance chain.
Date: Mon, 15 Apr 2013 17:48:49 +0200 [thread overview]
Message-ID: <516C2161.8040005@suse.de> (raw)
In-Reply-To: <1365691918-30594-18-git-send-email-imammedo@redhat.com>
Am 11.04.2013 16:51, schrieb Igor Mammedov:
> Currently device_set_realized() sets parent only after device was realized,
> But qdev_device_add() sets it before device is realized.
> Make behavior consistent and alter device_set_realized() to behave like
> qdev_device_add().
>
> It will allow to set link<> properties in realize() method in classes
> inherited from DEVICE.
>
> Signed-off-by: Igor Mammedov <imammedo@redhat.com>
> Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
> * Usage examples
> - conversion to CPU back-link property in APIC
> - pre-allocate link<CPU[n]> at board level, and populate them
> at realize time when CPUs are created.
> ---
> hw/core/qdev.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
Thanks, applied to qom-cpu:
https://github.com/afaerber/qemu-cpu/commits/qom-cpu
Andreas
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
next prev parent reply other threads:[~2013-04-15 15:48 UTC|newest]
Thread overview: 84+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-11 14:51 [Qemu-devel] [PATCH 00/19 v3] target-i386: CPU hot-add with cpu-add QMP command Igor Mammedov
2013-04-11 14:51 ` [Qemu-devel] [PATCH 01/19] target-i386: split out CPU creation and features parsing into cpu_x86_create() Igor Mammedov
2013-04-11 17:03 ` Eduardo Habkost
2013-04-15 15:03 ` Andreas Färber
2013-04-11 14:51 ` [Qemu-devel] [PATCH 02/19] cpu: Pass CPUState to *cpu_synchronize_post*() Igor Mammedov
2013-04-15 15:12 ` Andreas Färber
2013-04-11 14:51 ` [Qemu-devel] [PATCH 03/19] cpu: make kvm-stub.o a part of CPU library Igor Mammedov
2013-04-11 17:45 ` Eduardo Habkost
2013-04-12 11:17 ` Igor Mammedov
2013-04-12 19:25 ` Eduardo Habkost
2013-04-15 9:09 ` Igor Mammedov
2013-04-11 14:51 ` [Qemu-devel] [PATCH 04/19] cpu: call cpu_synchronize_post_init() from CPUClass.realize() if hotplugged Igor Mammedov
2013-04-11 18:33 ` Eduardo Habkost
2013-04-12 11:34 ` Igor Mammedov
2013-04-12 14:08 ` Eduardo Habkost
2013-04-15 19:57 ` Eduardo Habkost
2013-04-15 20:21 ` Igor Mammedov
2013-04-11 14:51 ` [Qemu-devel] [PATCH 05/19] cpu: resume CPU from CPUClass.cpu_common_realizefn() when it is hot-plugged Igor Mammedov
2013-04-11 18:36 ` Eduardo Habkost
2013-04-12 11:36 ` Igor Mammedov
2013-04-15 19:58 ` Eduardo Habkost
2013-04-11 14:51 ` [Qemu-devel] [PATCH 06/19] introduce CPU hot-plug notifier Igor Mammedov
2013-04-11 18:46 ` Eduardo Habkost
2013-04-12 11:00 ` Igor Mammedov
2013-04-15 20:08 ` Eduardo Habkost
2013-04-11 14:51 ` [Qemu-devel] [PATCH 07/19] rtc: update rtc_cmos on CPU hot-plug Igor Mammedov
2013-04-11 18:59 ` Eduardo Habkost
2013-04-12 10:53 ` Igor Mammedov
2013-04-12 13:35 ` Eduardo Habkost
2013-04-12 15:16 ` Igor Mammedov
2013-04-12 15:35 ` Eduardo Habkost
2013-04-12 16:24 ` Igor Mammedov
2013-04-15 9:38 ` Igor Mammedov
2013-04-15 17:53 ` Eduardo Habkost
2013-04-11 14:51 ` [Qemu-devel] [PATCH 08/19] cpu: introduce get_arch_id() method and override it for target-i386 Igor Mammedov
2013-04-11 19:04 ` Eduardo Habkost
2013-04-12 10:31 ` Igor Mammedov
2013-04-12 13:47 ` Eduardo Habkost
2013-04-15 15:24 ` Andreas Färber
2013-04-15 15:34 ` Igor Mammedov
2013-04-15 15:42 ` Andreas Färber
2013-04-15 15:47 ` Eduardo Habkost
2013-04-15 20:34 ` Igor Mammedov
2013-04-11 14:51 ` [Qemu-devel] [PATCH 09/19] cpu: add helper cpu_exists(), to check if CPU with specified id exists Igor Mammedov
2013-04-11 19:06 ` Eduardo Habkost
2013-04-12 10:14 ` Igor Mammedov
2013-04-11 14:51 ` [Qemu-devel] [PATCH 10/19] acpi_piix4: add infrastructure to send CPU hot-plug GPE to guest Igor Mammedov
2013-04-11 14:51 ` [Qemu-devel] [PATCH 11/19] target-i386: introduce apic-id property Igor Mammedov
2013-04-11 19:12 ` Eduardo Habkost
2013-04-12 10:20 ` Igor Mammedov
2013-04-12 13:13 ` Eduardo Habkost
2013-04-12 15:46 ` Igor Mammedov
2013-04-12 16:29 ` Eduardo Habkost
2013-04-15 2:30 ` li guang
2013-04-15 13:37 ` Igor Mammedov
2013-04-15 13:45 ` Eduardo Habkost
2013-04-15 14:34 ` Igor Mammedov
2013-04-15 14:49 ` Eduardo Habkost
2013-04-15 20:27 ` Igor Mammedov
2013-04-15 20:49 ` Eduardo Habkost
2013-04-15 21:13 ` Igor Mammedov
2013-04-11 14:51 ` [Qemu-devel] [PATCH 12/19] introduce ICC bus/device/bridge Igor Mammedov
2013-04-11 14:51 ` [Qemu-devel] [PATCH 13/19] target-i386: cpu: attach ICC bus to CPU on its creation Igor Mammedov
2013-04-15 15:38 ` Andreas Färber
2013-04-15 15:49 ` Igor Mammedov
2013-04-15 16:06 ` Andreas Färber
2013-04-15 16:17 ` Igor Mammedov
2013-04-11 14:51 ` [Qemu-devel] [PATCH 14/19] target-i386: replace MSI_SPACE_SIZE with APIC_SPACE_SIZE Igor Mammedov
2013-04-15 15:34 ` Andreas Färber
2013-04-15 15:47 ` Jan Kiszka
2013-04-11 14:51 ` [Qemu-devel] [PATCH 15/19] target-i386: move APIC to ICC bus Igor Mammedov
2013-04-11 14:51 ` [Qemu-devel] [PATCH 16/19] target-i386: move IOAPIC " Igor Mammedov
2013-04-11 14:51 ` [Qemu-devel] [PATCH 17/19] qdev: set device's parent before calling realize() down inheritance chain Igor Mammedov
2013-04-15 15:48 ` Andreas Färber [this message]
2013-04-11 14:51 ` [Qemu-devel] [PATCH 18/19] target-i386: expose all possible CPUs as /machine/icc-bridge/cpu[0..N] links Igor Mammedov
2013-04-11 17:19 ` Eduardo Habkost
2013-04-12 10:01 ` Igor Mammedov
2013-04-12 12:44 ` Eduardo Habkost
2013-04-15 14:15 ` Igor Mammedov
2013-04-15 14:48 ` Eduardo Habkost
2013-04-15 15:16 ` Igor Mammedov
2013-04-15 15:26 ` Eduardo Habkost
2013-04-15 20:37 ` Igor Mammedov
2013-04-11 14:51 ` [Qemu-devel] [PATCH 19/19] add cpu-add qmp command and implement CPU hot-add for target-i386 Igor Mammedov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=516C2161.8040005@suse.de \
--to=afaerber@suse.de \
--cc=aderumier@odiso.com \
--cc=aliguori@us.ibm.com \
--cc=claudio.fontana@huawei.com \
--cc=ehabkost@redhat.com \
--cc=imammedo@redhat.com \
--cc=jfrei@linux.vnet.ibm.com \
--cc=lcapitulino@redhat.com \
--cc=lig.fnst@cn.fujitsu.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
--cc=yang.z.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.