From: Paolo Bonzini <pbonzini@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 07/12] configure: fix TPM logic
Date: Mon, 15 Apr 2013 18:14:19 +0200 [thread overview]
Message-ID: <516C275B.8080502@redhat.com> (raw)
In-Reply-To: <CAFEAcA9JsJn2Ro=rhd9zRmxhYFsj7SEnV1XQ49a2tLQHLUSuxA@mail.gmail.com>
Il 15/04/2013 18:09, Peter Maydell ha scritto:
>> > +if test "$targetos" = Linux && test "$cpu" = i386 -o "$cpu" = x86_64; then
> test -o is deprecated by POSIX; better to use
> if test ... && ( test ... || test ... ); then
>
> in new code.
True, on the other hand "(.*test" has no match at all in configure; and
since we know that $cpu does not begin with a dash, it is portable in
practice.
I would agree with you, but it looks like convention trumps the
suggested practice.
Paolo
next prev parent reply other threads:[~2013-04-15 16:14 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-15 13:19 [Qemu-devel] [PULL 00/12] directory reorganization, fixes and final part Paolo Bonzini
2013-04-15 13:19 ` [Qemu-devel] [PATCH 01/12] arm: fix location of some include files Paolo Bonzini
2013-04-15 13:19 ` [Qemu-devel] [PATCH 02/12] Add linux-headers to QEMU_INCLUDES Paolo Bonzini
2013-04-15 13:19 ` [Qemu-devel] [PATCH 03/12] Fix failure to create q35 machine Paolo Bonzini
2013-04-15 13:19 ` [Qemu-devel] [PATCH 04/12] hw: Add lost ARM core again Paolo Bonzini
2013-04-15 13:19 ` [Qemu-devel] [PATCH 05/12] acpi: move declarations from pc.h to acpi.h Paolo Bonzini
2013-04-15 13:19 ` [Qemu-devel] [PATCH 06/12] acpi.h: make it self contained Paolo Bonzini
2013-04-15 13:19 ` [Qemu-devel] [PATCH 07/12] configure: fix TPM logic Paolo Bonzini
2013-04-15 16:02 ` Laszlo Ersek
2013-04-15 16:09 ` Peter Maydell
2013-04-15 16:14 ` Paolo Bonzini [this message]
2013-04-15 16:21 ` Peter Maydell
2013-04-16 8:28 ` Markus Armbruster
2013-04-16 8:42 ` Paolo Bonzini
2013-04-15 13:19 ` [Qemu-devel] [PATCH 08/12] tpm: reorganize headers and split hardware part Paolo Bonzini
2013-04-15 16:19 ` Laszlo Ersek
2013-04-15 13:19 ` [Qemu-devel] [PATCH 09/12] sysemu: avoid proliferation of include/ subdirectories Paolo Bonzini
2013-04-15 13:19 ` [Qemu-devel] [PATCH 10/12] include: avoid useless includes of exec/ headers Paolo Bonzini
2013-04-15 13:19 ` [Qemu-devel] [PATCH 11/12] memory: move core typedefs to qemu/typedefs.h Paolo Bonzini
2013-04-15 13:19 ` [Qemu-devel] [PATCH 12/12] exec: remove useless declarations from memory-internal.h Paolo Bonzini
2013-04-15 16:20 ` [Qemu-devel] [PULL 00/12] directory reorganization, fixes and final part Paolo Bonzini
2013-04-15 21:10 ` Anthony Liguori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=516C275B.8080502@redhat.com \
--to=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.