From: Xiao Guangrong <xiaoguangrong@linux.vnet.ibm.com>
To: Robin Holt <holt@sgi.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Marcelo Tosatti <mtosatti@redhat.com>,
Gleb Natapov <gleb@redhat.com>, Avi Kivity <avi.kivity@gmail.com>,
Andrea Arcangeli <aarcange@redhat.com>,
LKML <linux-kernel@vger.kernel.org>, KVM <kvm@vger.kernel.org>,
Linux Memory Management List <linux-mm@kvack.org>
Subject: Re: [PATCH] mm: mmu_notifier: re-fix freed page still mapped in secondary MMU
Date: Tue, 16 Apr 2013 21:07:20 +0800 [thread overview]
Message-ID: <516D4D08.9020602@linux.vnet.ibm.com> (raw)
In-Reply-To: <20130416114322.GN3658@sgi.com>
On 04/16/2013 07:43 PM, Robin Holt wrote:
> Argh. Taking a step back helped clear my head.
>
> For the -stable releases, I agree we should just go with your
> revert-plus-hlist_del_init_rcu patch. I will give it a test
> when I am in the office.
Okay. Wait for your test report. Thank you in advance.
>
> For the v3.10 release, we should work on making this more
> correct and completely documented.
Better document is always welcomed.
Double call ->release is not bad, like i mentioned it in the changelog:
it is really rare (e.g, can not happen on kvm since mmu-notify is unregistered
after exit_mmap()) and the later call of multiple ->release should be
fast since all the pages have already been released by the first call.
But, of course, it's great if you have a _light_ way to avoid this.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Xiao Guangrong <xiaoguangrong@linux.vnet.ibm.com>
To: Robin Holt <holt@sgi.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Marcelo Tosatti <mtosatti@redhat.com>,
Gleb Natapov <gleb@redhat.com>, Avi Kivity <avi.kivity@gmail.com>,
Andrea Arcangeli <aarcange@redhat.com>,
LKML <linux-kernel@vger.kernel.org>, KVM <kvm@vger.kernel.org>,
Linux Memory Management List <linux-mm@kvack.org>
Subject: Re: [PATCH] mm: mmu_notifier: re-fix freed page still mapped in secondary MMU
Date: Tue, 16 Apr 2013 21:07:20 +0800 [thread overview]
Message-ID: <516D4D08.9020602@linux.vnet.ibm.com> (raw)
In-Reply-To: <20130416114322.GN3658@sgi.com>
On 04/16/2013 07:43 PM, Robin Holt wrote:
> Argh. Taking a step back helped clear my head.
>
> For the -stable releases, I agree we should just go with your
> revert-plus-hlist_del_init_rcu patch. I will give it a test
> when I am in the office.
Okay. Wait for your test report. Thank you in advance.
>
> For the v3.10 release, we should work on making this more
> correct and completely documented.
Better document is always welcomed.
Double call ->release is not bad, like i mentioned it in the changelog:
it is really rare (e.g, can not happen on kvm since mmu-notify is unregistered
after exit_mmap()) and the later call of multiple ->release should be
fast since all the pages have already been released by the first call.
But, of course, it's great if you have a _light_ way to avoid this.
next prev parent reply other threads:[~2013-04-16 13:07 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-16 6:39 [PATCH] mm: mmu_notifier: re-fix freed page still mapped in secondary MMU Xiao Guangrong
2013-04-16 6:39 ` Xiao Guangrong
2013-04-16 9:31 ` Robin Holt
2013-04-16 9:31 ` Robin Holt
2013-04-16 10:26 ` Xiao Guangrong
2013-04-16 10:26 ` Xiao Guangrong
2013-04-16 11:25 ` Robin Holt
2013-04-16 11:25 ` Robin Holt
2013-04-16 11:43 ` Robin Holt
2013-04-16 11:43 ` Robin Holt
2013-04-16 13:07 ` Xiao Guangrong [this message]
2013-04-16 13:07 ` Xiao Guangrong
2013-04-16 18:08 ` Robin Holt
2013-04-16 18:08 ` Robin Holt
2013-04-17 2:55 ` Xiao Guangrong
2013-04-17 2:55 ` Xiao Guangrong
2013-04-17 14:10 ` Robin Holt
2013-04-17 14:10 ` Robin Holt
2013-04-17 18:41 ` Xiao Guangrong
2013-04-17 18:41 ` Xiao Guangrong
2013-04-17 18:45 ` Robin Holt
2013-04-17 18:45 ` Robin Holt
2013-04-17 18:52 ` Xiao Guangrong
2013-04-17 18:52 ` Xiao Guangrong
2013-05-01 9:03 ` Robin Holt
2013-05-01 9:03 ` Robin Holt
2013-04-17 23:38 ` Simon Jeons
2013-04-17 23:38 ` Simon Jeons
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=516D4D08.9020602@linux.vnet.ibm.com \
--to=xiaoguangrong@linux.vnet.ibm.com \
--cc=aarcange@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=avi.kivity@gmail.com \
--cc=gleb@redhat.com \
--cc=holt@sgi.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mtosatti@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.