From: Eric Blake <eblake@redhat.com>
To: Wenchao Xia <xiawenc@linux.vnet.ibm.com>
Cc: kwolf@redhat.com, pbonzini@redhat.com, stefanha@gmail.com,
qemu-devel@nongnu.org, dietmar@proxmox.com
Subject: Re: [Qemu-devel] [PATCH V2 1/5] block: package preparation code in qmp_transaction()
Date: Tue, 16 Apr 2013 08:56:30 -0600 [thread overview]
Message-ID: <516D669E.7000708@redhat.com> (raw)
In-Reply-To: <1365851501-3037-2-git-send-email-xiawenc@linux.vnet.ibm.com>
[-- Attachment #1: Type: text/plain, Size: 655 bytes --]
On 04/13/2013 05:11 AM, Wenchao Xia wrote:
> The code before really committing is moved into a function. Most
> code are simply moved from qmp_transaction()i, except fail handling
s/i,/,/
> label is changed from "delete_and_fail" to "fail". Other code such
> as input parsing is not touched, to make it easier in review.
>
> Signed-off-by: Wenchao Xia <xiawenc@linux.vnet.ibm.com>
> ---
> blockdev.c | 146 +++++++++++++++++++++++++++++++++--------------------------
> 1 files changed, 82 insertions(+), 64 deletions(-)
>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 621 bytes --]
next prev parent reply other threads:[~2013-04-16 15:16 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-13 11:11 [Qemu-devel] [PATCH V2 0/5] block: make qmp_transaction extendable Wenchao Xia
2013-04-13 11:11 ` [Qemu-devel] [PATCH V2 1/5] block: package preparation code in qmp_transaction() Wenchao Xia
2013-04-16 13:19 ` Kevin Wolf
2013-04-16 14:56 ` Eric Blake [this message]
2013-04-13 11:11 ` [Qemu-devel] [PATCH V2 2/5] block: move input parsing " Wenchao Xia
2013-04-16 15:15 ` Eric Blake
2013-04-13 11:11 ` [Qemu-devel] [PATCH V2 3/5] block: package committing " Wenchao Xia
2013-04-16 15:26 ` Eric Blake
2013-04-13 11:11 ` [Qemu-devel] [PATCH V2 4/5] block: package rolling back " Wenchao Xia
2013-04-16 15:27 ` Eric Blake
2013-04-13 11:11 ` [Qemu-devel] [PATCH V2 5/5] block: make all steps in qmp_transaction() as callback Wenchao Xia
2013-04-16 13:52 ` Kevin Wolf
2013-04-17 3:59 ` Wenchao Xia
2013-04-16 15:41 ` Eric Blake
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=516D669E.7000708@redhat.com \
--to=eblake@redhat.com \
--cc=dietmar@proxmox.com \
--cc=kwolf@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@gmail.com \
--cc=xiawenc@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.