All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dave Hansen <dave.hansen@linux.intel.com>
To: zhang.yi20@zte.com.cn
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org,
	Peter Zijlstra <peterz@infradead.org>,
	Darren Hart <dvhart@linux.intel.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@kernel.org>
Subject: Re: [PATCH] futex: bugfix for futex-key conflict when futex use hugepage
Date: Tue, 16 Apr 2013 11:37:40 -0700	[thread overview]
Message-ID: <516D9A74.8030109@linux.intel.com> (raw)
In-Reply-To: <OF000BBE68.EBB4E92E-ON48257B4F.0010C2E7-48257B4F.0013FB89@zte.com.cn>

Instead of bothering to store the index, why not just calculate it, like:

On 04/15/2013 08:37 PM, zhang.yi20@zte.com.cn wrote:
> +static inline int get_page_compound_index(struct page *page)
> +{
> +       if (PageHead(page))
> +               return 0;
> +       return compound_head(page) - page;
> +}

BTW, you've really got to get your mail client fixed.  Your patch is
still line-wrapped.

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

WARNING: multiple messages have this Message-ID (diff)
From: Dave Hansen <dave.hansen@linux.intel.com>
To: zhang.yi20@zte.com.cn
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org,
	Peter Zijlstra <peterz@infradead.org>,
	Darren Hart <dvhart@linux.intel.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@kernel.org>
Subject: Re: [PATCH] futex: bugfix for futex-key conflict when futex use hugepage
Date: Tue, 16 Apr 2013 11:37:40 -0700	[thread overview]
Message-ID: <516D9A74.8030109@linux.intel.com> (raw)
In-Reply-To: <OF000BBE68.EBB4E92E-ON48257B4F.0010C2E7-48257B4F.0013FB89@zte.com.cn>

Instead of bothering to store the index, why not just calculate it, like:

On 04/15/2013 08:37 PM, zhang.yi20@zte.com.cn wrote:
> +static inline int get_page_compound_index(struct page *page)
> +{
> +       if (PageHead(page))
> +               return 0;
> +       return compound_head(page) - page;
> +}

BTW, you've really got to get your mail client fixed.  Your patch is
still line-wrapped.

  parent reply	other threads:[~2013-04-16 18:37 UTC|newest]

Thread overview: 47+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-04-16  3:37 [PATCH] futex: bugfix for futex-key conflict when futex use hugepage zhang.yi20
2013-04-16  3:37 ` zhang.yi20
2013-04-16 17:57 ` Darren Hart
2013-04-16 17:57   ` Darren Hart
2013-04-17  9:55   ` zhang.yi20
2013-04-17  9:55     ` zhang.yi20
2013-04-17 14:18     ` Darren Hart
2013-04-17 14:18       ` Darren Hart
2013-04-17 15:26       ` Dave Hansen
2013-04-17 15:26         ` Dave Hansen
2013-04-17 15:51         ` Darren Hart
2013-04-17 15:51           ` Darren Hart
2013-04-18  8:05           ` zhang.yi20
2013-04-18  8:05             ` zhang.yi20
2013-04-18 14:34             ` Darren Hart
2013-04-18 14:34               ` Darren Hart
2013-04-19  2:13               ` zhang.yi20
2013-04-19  2:13                 ` zhang.yi20
2013-04-19  2:42                 ` Darren Hart
2013-04-19  2:42                   ` Darren Hart
2013-04-19  2:45                 ` Darren Hart
2013-04-19  2:45                   ` Darren Hart
2013-04-19  7:03                   ` zhang.yi20
2013-04-19  7:03                     ` zhang.yi20
2013-04-18 10:14   ` 答复: " zhang.yi20
2013-04-16 18:37 ` Dave Hansen [this message]
2013-04-16 18:37   ` Dave Hansen
2013-04-16 18:47   ` Darren Hart
2013-04-16 18:47     ` Darren Hart
2013-04-17  7:25   ` 答复: " zhang.yi20
2013-04-17  7:47   ` zhang.yi20
2013-04-17  7:47     ` zhang.yi20
  -- strict thread matches above, loose matches on Subject: below --
2013-05-15 13:57 Zhang Yi
2013-05-15 14:20 ` Mel Gorman
2013-05-16  1:16   ` zhang.yi20
2013-05-16  1:30     ` Darren Hart
2013-05-07 12:43 Zhang Yi
2013-04-26 12:13 Zhang Yi
2013-04-26 18:26 ` Thomas Gleixner
2013-05-07 12:23   ` Zhang Yi
2013-05-07 15:20     ` Mel Gorman
2013-05-07 15:24       ` Thomas Gleixner
2013-05-07 15:54         ` Mel Gorman
2013-05-07 12:34   ` Zhang Yi
2013-04-24 14:27 Zhang Yi
2013-04-24 13:58 Zhang Yi
2013-04-25 20:52 ` Thomas Gleixner
2013-04-08  6:34 jiang.biao2

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=516D9A74.8030109@linux.intel.com \
    --to=dave.hansen@linux.intel.com \
    --cc=dvhart@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mingo@kernel.org \
    --cc=peterz@infradead.org \
    --cc=tglx@linutronix.de \
    --cc=zhang.yi20@zte.com.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.