From: Timur Tabi <timur@tabi.org>
To: Tang Yuantian-B29983 <B29983@freescale.com>
Cc: devicetree-discuss <devicetree-discuss@lists.ozlabs.org>,
"linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>,
lkml <linux-kernel@vger.kernel.org>,
Rob Herring <rob.herring@calxeda.com>
Subject: Re: [PATCH v2] of/base: release the node correctly in of_parse_phandle_with_args()
Date: Tue, 16 Apr 2013 22:30:43 -0500 [thread overview]
Message-ID: <516E1763.7040206@tabi.org> (raw)
In-Reply-To: <D07C73A334FF604B95B3CBD2A545D07B0B1456B8@039-SN2MPN1-013.039d.mgd.msft.net>
Tang Yuantian-B29983 wrote:
>> >On Tue, Apr 9, 2013 at 10:36 PM,<Yuantian.Tang@freescale.com> wrote:
>>> > >
>>> > >+ /* Found it! return success */
>> >
>> >I'm pretty sure this comment is in the wrong place.
> It is not perfect, but acceptable.
Like I said, I'm pretty sure it's in the wrong place.
--
Timur Tabi
WARNING: multiple messages have this Message-ID (diff)
From: Timur Tabi <timur@tabi.org>
To: Tang Yuantian-B29983 <B29983@freescale.com>
Cc: Grant Likely <grant.likely@secretlab.ca>,
devicetree-discuss <devicetree-discuss@lists.ozlabs.org>,
"linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>,
lkml <linux-kernel@vger.kernel.org>,
Rob Herring <rob.herring@calxeda.com>
Subject: Re: [PATCH v2] of/base: release the node correctly in of_parse_phandle_with_args()
Date: Tue, 16 Apr 2013 22:30:43 -0500 [thread overview]
Message-ID: <516E1763.7040206@tabi.org> (raw)
In-Reply-To: <D07C73A334FF604B95B3CBD2A545D07B0B1456B8@039-SN2MPN1-013.039d.mgd.msft.net>
Tang Yuantian-B29983 wrote:
>> >On Tue, Apr 9, 2013 at 10:36 PM,<Yuantian.Tang@freescale.com> wrote:
>>> > >
>>> > >+ /* Found it! return success */
>> >
>> >I'm pretty sure this comment is in the wrong place.
> It is not perfect, but acceptable.
Like I said, I'm pretty sure it's in the wrong place.
--
Timur Tabi
next prev parent reply other threads:[~2013-04-17 3:30 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-10 3:36 [PATCH v2] of/base: release the node correctly in of_parse_phandle_with_args() Yuantian.Tang
2013-04-10 3:36 ` Yuantian.Tang
2013-04-10 3:36 ` Yuantian.Tang
2013-04-16 6:54 ` Tang Yuantian-B29983
2013-04-16 6:54 ` Tang Yuantian-B29983
2013-04-16 6:54 ` Tang Yuantian-B29983
2013-04-17 14:57 ` Grant Likely
2013-04-17 14:57 ` Grant Likely
2013-04-17 14:57 ` Grant Likely
2013-04-17 21:52 ` Timur Tabi
2013-04-17 22:00 ` Grant Likely
2013-04-16 11:37 ` Timur Tabi
2013-04-16 11:37 ` Timur Tabi
2013-04-17 2:44 ` Tang Yuantian-B29983
2013-04-17 2:44 ` Tang Yuantian-B29983
2013-04-17 2:44 ` Tang Yuantian-B29983
2013-04-17 3:30 ` Timur Tabi [this message]
2013-04-17 3:30 ` Timur Tabi
2013-04-17 4:49 ` Tang Yuantian-B29983
2013-04-17 4:49 ` Tang Yuantian-B29983
2013-04-17 4:49 ` Tang Yuantian-B29983
2013-04-17 11:27 ` Timur Tabi
2013-04-17 11:27 ` Timur Tabi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=516E1763.7040206@tabi.org \
--to=timur@tabi.org \
--cc=B29983@freescale.com \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=rob.herring@calxeda.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.