Re: [PATCH] Kbuild: Avoid DTB rebuilds if source files are untouched

All of lore.kernel.org
 help / color / mirror / Atom feed

From: Vineet Gupta <Vineet.Gupta1@synopsys.com>
To: James Hogan <james.hogan@imgtec.com>
Cc: Stephen Warren <swarren@wwwdotorg.org>,
	"linux-arch@vger.kernel.org" <linux-arch@vger.kernel.org>,
	linux-kernel@vger.kernel.org, Michal Marek <mmarek@suse.cz>,
	Stephen Warren <swarren@nvidia.com>,
	Grant Likely <grant.likely@secretlab.ca>,
	linux-kbuild@vger.kernel.org, Sam Ravnborg <sam@ravnborg.org>
Subject: Re: [PATCH] Kbuild: Avoid DTB rebuilds if source files are untouched
Date: Wed, 17 Apr 2013 09:43:29 +0530	[thread overview]
Message-ID: <516E2169.4020007@synopsys.com> (raw)
In-Reply-To: <516D7405.3060202@imgtec.com>

Hi James,

On 04/16/2013 09:23 PM, James Hogan wrote:
> On 12/04/13 22:52, Stephen Warren wrote:
>> +.SECONDARY: $(obj)/$(builtindtb-y).dtb.S
> Note, this may not work if you're using CONFIG_ARC_BUILTIN_DTB_NAME,
> since it'll have quotes around it, so you may instead need:
> .SECONDARY: $(obj)/$(patsubst "%",%,$(builtindtb-y)).dtb.S
>
> (at least that's what's required for the metag equivalent)
>
>> +
>>  dtbs:  $(addprefix  $(obj)/, $(builtindtb-y).dtb)
> You might find the same thing here too.

Actually in my Makefile, the quotes are stripped off in the very beginning to
avoid duplicating it in every place.

ifneq ($(CONFIG_ARC_BUILTIN_DTB_NAME),"")
    builtindtb-y    := $(patsubst "%",%,$(CONFIG_ARC_BUILTIN_DTB_NAME))
endif
....

Thus both the above are not required - redundant if at all.

-Vineet

WARNING: multiple messages have this Message-ID (diff)

From: Vineet Gupta <Vineet.Gupta1@synopsys.com>
To: James Hogan <james.hogan@imgtec.com>
Cc: Stephen Warren <swarren@wwwdotorg.org>,
	"linux-arch@vger.kernel.org" <linux-arch@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>, Michal Marek <mmarek@suse.cz>,
	Stephen Warren <swarren@nvidia.com>,
	Grant Likely <grant.likely@secretlab.ca>,
	<linux-kbuild@vger.kernel.org>, Sam Ravnborg <sam@ravnborg.org>
Subject: Re: [PATCH] Kbuild: Avoid DTB rebuilds if source files are untouched
Date: Wed, 17 Apr 2013 09:43:29 +0530	[thread overview]
Message-ID: <516E2169.4020007@synopsys.com> (raw)
In-Reply-To: <516D7405.3060202@imgtec.com>

Hi James,

On 04/16/2013 09:23 PM, James Hogan wrote:
> On 12/04/13 22:52, Stephen Warren wrote:
>> +.SECONDARY: $(obj)/$(builtindtb-y).dtb.S
> Note, this may not work if you're using CONFIG_ARC_BUILTIN_DTB_NAME,
> since it'll have quotes around it, so you may instead need:
> .SECONDARY: $(obj)/$(patsubst "%",%,$(builtindtb-y)).dtb.S
>
> (at least that's what's required for the metag equivalent)
>
>> +
>>  dtbs:  $(addprefix  $(obj)/, $(builtindtb-y).dtb)
> You might find the same thing here too.

Actually in my Makefile, the quotes are stripped off in the very beginning to
avoid duplicating it in every place.

ifneq ($(CONFIG_ARC_BUILTIN_DTB_NAME),"")
    builtindtb-y    := $(patsubst "%",%,$(CONFIG_ARC_BUILTIN_DTB_NAME))
endif
....

Thus both the above are not required - redundant if at all.

-Vineet

next prev parent reply	other threads:[~2013-04-17  4:13 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-04-03  7:12 [PATCH] Kbuild: Avoid DTB rebuilds if source files are untouched Vineet Gupta
2013-04-03  7:12 ` Vineet Gupta
2013-04-03  7:14 ` Vineet Gupta
2013-04-03  7:14   ` Vineet Gupta
2013-04-03 16:18   ` Stephen Warren
2013-04-04  5:30     ` Vineet Gupta
2013-04-04  5:30       ` Vineet Gupta
2013-04-04 17:36       ` Stephen Warren
2013-04-09 13:37         ` Vineet Gupta
2013-04-09 13:37           ` Vineet Gupta
2013-04-09 14:10         ` Vineet Gupta
2013-04-09 14:10           ` Vineet Gupta
2013-04-12  7:40           ` Vineet Gupta
2013-04-12  7:40             ` Vineet Gupta
2013-04-12 21:52             ` Stephen Warren
2013-04-15 13:59               ` Vineet Gupta
2013-04-15 13:59                 ` Vineet Gupta
2013-04-15 17:12                 ` Stephen Warren
2013-04-16 15:53               ` James Hogan
2013-04-16 15:53                 ` James Hogan
2013-04-16 16:02                 ` James Hogan
2013-04-16 16:02                   ` James Hogan
2013-04-17  4:15                   ` Vineet Gupta
2013-04-17  4:15                     ` Vineet Gupta
2013-04-17  4:13                 ` Vineet Gupta [this message]
2013-04-17  4:13                   ` Vineet Gupta
2013-04-17  9:13                   ` James Hogan
2013-04-17  9:13                     ` James Hogan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=516E2169.4020007@synopsys.com \
    --to=vineet.gupta1@synopsys.com \
    --cc=grant.likely@secretlab.ca \
    --cc=james.hogan@imgtec.com \
    --cc=linux-arch@vger.kernel.org \
    --cc=linux-kbuild@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mmarek@suse.cz \
    --cc=sam@ravnborg.org \
    --cc=swarren@nvidia.com \
    --cc=swarren@wwwdotorg.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Be sure your reply has a Subject: header at the top and a blank line before the message body.

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.