From: Yijing Wang <wangyijing@huawei.com>
To: Wanpeng Li <liwanp@linux.vnet.ibm.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
Hanjun Guo <guohanjun@huawei.com>,
jiang.liu@huawei.com, Tang Chen <tangchen@cn.fujitsu.com>,
Wen Congyang <wency@cn.fujitsu.com>
Subject: Re: [PATCH] mm: fix build warning about kernel_physical_mapping_remove()
Date: Wed, 17 Apr 2013 15:38:39 +0800 [thread overview]
Message-ID: <516E517F.5000003@huawei.com> (raw)
In-Reply-To: <20130417072214.GA25283@hacker.(null)>
On 2013/4/17 15:22, Wanpeng Li wrote:
> On Wed, Apr 17, 2013 at 03:15:58PM +0800, Yijing Wang wrote:
>> If CONFIG_MEMORY_HOTREMOVE is not set, a build warning about
>> "warning: a??kernel_physical_mapping_removea?? defined but not used"
>> report.
>>
>
> This has already been fixed by Tang Chen.
> http://marc.info/?l=linux-mm&m=136614697618243&w=2
OK, I will drop this one, thanks!
>
>> Signed-off-by: Yijing Wang <wangyijing@huawei.com>
>> Cc: Tang Chen <tangchen@cn.fujitsu.com>
>> Cc: Wen Congyang <wency@cn.fujitsu.com>
>> ---
>> arch/x86/mm/init_64.c | 2 +-
>> 1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/arch/x86/mm/init_64.c b/arch/x86/mm/init_64.c
>> index 474e28f..dafdeb2 100644
>> --- a/arch/x86/mm/init_64.c
>> +++ b/arch/x86/mm/init_64.c
>> @@ -1019,6 +1019,7 @@ void __ref vmemmap_free(struct page *memmap, unsigned long nr_pages)
>> remove_pagetable(start, end, false);
>> }
>>
>> +#ifdef CONFIG_MEMORY_HOTREMOVE
>> static void __meminit
>> kernel_physical_mapping_remove(unsigned long start, unsigned long end)
>> {
>> @@ -1028,7 +1029,6 @@ kernel_physical_mapping_remove(unsigned long start, unsigned long end)
>> remove_pagetable(start, end, true);
>> }
>>
>> -#ifdef CONFIG_MEMORY_HOTREMOVE
>> int __ref arch_remove_memory(u64 start, u64 size)
>> {
>> unsigned long start_pfn = start >> PAGE_SHIFT;
>> --
>> 1.7.1
>>
>>
>> --
>> To unsubscribe, send a message with 'unsubscribe linux-mm' in
>> the body to majordomo@kvack.org. For more info on Linux MM,
>> see: http://www.linux-mm.org/ .
>> Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
>
>
> .
>
--
Thanks!
Yijing
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Yijing Wang <wangyijing@huawei.com>
To: Wanpeng Li <liwanp@linux.vnet.ibm.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
<linux-kernel@vger.kernel.org>, <linux-mm@kvack.org>,
Hanjun Guo <guohanjun@huawei.com>, <jiang.liu@huawei.com>,
Tang Chen <tangchen@cn.fujitsu.com>,
Wen Congyang <wency@cn.fujitsu.com>
Subject: Re: [PATCH] mm: fix build warning about kernel_physical_mapping_remove()
Date: Wed, 17 Apr 2013 15:38:39 +0800 [thread overview]
Message-ID: <516E517F.5000003@huawei.com> (raw)
In-Reply-To: <20130417072214.GA25283@hacker.(null)>
On 2013/4/17 15:22, Wanpeng Li wrote:
> On Wed, Apr 17, 2013 at 03:15:58PM +0800, Yijing Wang wrote:
>> If CONFIG_MEMORY_HOTREMOVE is not set, a build warning about
>> "warning: ‘kernel_physical_mapping_remove’ defined but not used"
>> report.
>>
>
> This has already been fixed by Tang Chen.
> http://marc.info/?l=linux-mm&m=136614697618243&w=2
OK, I will drop this one, thanks!
>
>> Signed-off-by: Yijing Wang <wangyijing@huawei.com>
>> Cc: Tang Chen <tangchen@cn.fujitsu.com>
>> Cc: Wen Congyang <wency@cn.fujitsu.com>
>> ---
>> arch/x86/mm/init_64.c | 2 +-
>> 1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/arch/x86/mm/init_64.c b/arch/x86/mm/init_64.c
>> index 474e28f..dafdeb2 100644
>> --- a/arch/x86/mm/init_64.c
>> +++ b/arch/x86/mm/init_64.c
>> @@ -1019,6 +1019,7 @@ void __ref vmemmap_free(struct page *memmap, unsigned long nr_pages)
>> remove_pagetable(start, end, false);
>> }
>>
>> +#ifdef CONFIG_MEMORY_HOTREMOVE
>> static void __meminit
>> kernel_physical_mapping_remove(unsigned long start, unsigned long end)
>> {
>> @@ -1028,7 +1029,6 @@ kernel_physical_mapping_remove(unsigned long start, unsigned long end)
>> remove_pagetable(start, end, true);
>> }
>>
>> -#ifdef CONFIG_MEMORY_HOTREMOVE
>> int __ref arch_remove_memory(u64 start, u64 size)
>> {
>> unsigned long start_pfn = start >> PAGE_SHIFT;
>> --
>> 1.7.1
>>
>>
>> --
>> To unsubscribe, send a message with 'unsubscribe linux-mm' in
>> the body to majordomo@kvack.org. For more info on Linux MM,
>> see: http://www.linux-mm.org/ .
>> Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
>
>
> .
>
--
Thanks!
Yijing
next prev parent reply other threads:[~2013-04-17 7:39 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-17 7:15 [PATCH] mm: fix build warning about kernel_physical_mapping_remove() Yijing Wang
2013-04-17 7:15 ` Yijing Wang
2013-04-17 7:22 ` Wanpeng Li
2013-04-17 7:22 ` Wanpeng Li
2013-04-17 7:38 ` Yijing Wang [this message]
2013-04-17 7:38 ` Yijing Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=516E517F.5000003@huawei.com \
--to=wangyijing@huawei.com \
--cc=akpm@linux-foundation.org \
--cc=guohanjun@huawei.com \
--cc=jiang.liu@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=liwanp@linux.vnet.ibm.com \
--cc=tangchen@cn.fujitsu.com \
--cc=wency@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.