All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sylwester Nawrocki <s.nawrocki@samsung.com>
To: Sachin Kamat <sachin.kamat@linaro.org>
Cc: inki.dae@samsung.com, kyungmin.park@samsung.com,
	linux-samsung-soc@vger.kernel.org,
	dri-devel@lists.freedesktop.org,
	devicetree-discuss@lists.ozlabs.org
Subject: Re: [PATCH 2/3] drm/exynos: Rework fimc clocks handling
Date: Wed, 17 Apr 2013 10:30:01 +0200	[thread overview]
Message-ID: <516E5D89.2040305@samsung.com> (raw)
In-Reply-To: <CAK9yfHw=V+5AgM9i+Cc7cr9TJqgsYigQApSJehNFwv=cFU2bCg@mail.gmail.com>

On 04/17/2013 06:02 AM, Sachin Kamat wrote:
> Hi Sylwester,
> 
> On 16 April 2013 23:01, Sylwester Nawrocki <s.nawrocki@samsung.com> wrote:
>> @@ -1835,16 +1859,19 @@ static int fimc_probe(struct platform_device *pdev)
>>         ret = exynos_drm_ippdrv_register(ippdrv);
>>         if (ret < 0) {
>>                 dev_err(dev, "failed to register drm fimc device.\n");
>> -               goto err_ippdrv_register;
>> +               goto err_pm_dis;
>>         }
>>
>>         dev_info(&pdev->dev, "drm fimc registered successfully.\n");
>>
>>         return 0;
>>
>> -err_ippdrv_register:
>> +err_pm_dis:
>> +       devm_kfree(dev, ippdrv->prop_list);
> 
> devm_kfree was removed in patch1 of this series. Do we need it back?

Certainly not, that's a rebase error. I'll resend it fixed.
Thanks for your review.

Regards,
Sylwester

  reply	other threads:[~2013-04-17  8:30 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-04-16 17:31 [PATCH 0/3] drm/exynos: Add device tree support for IPP driver Sylwester Nawrocki
2013-04-16 17:31 ` [PATCH 1/3] drm/exynos: Remove redundant devm_kfree() Sylwester Nawrocki
2013-04-16 17:31 ` [PATCH 2/3] drm/exynos: Rework fimc clocks handling Sylwester Nawrocki
2013-04-17  4:02   ` Sachin Kamat
2013-04-17  8:30     ` Sylwester Nawrocki [this message]
2013-04-16 17:31 ` [PATCH 3/3] drm/exynos: Add device tree support for fimc ipp driver Sylwester Nawrocki
2013-04-19 11:38   ` Eunchul Kim
2013-04-22 15:57     ` Sylwester Nawrocki
     [not found]   ` <1366133486-22973-4-git-send-email-s.nawrocki-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2013-04-20 16:21     ` Inki Dae
2013-04-22 15:57       ` Sylwester Nawrocki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=516E5D89.2040305@samsung.com \
    --to=s.nawrocki@samsung.com \
    --cc=devicetree-discuss@lists.ozlabs.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=inki.dae@samsung.com \
    --cc=kyungmin.park@samsung.com \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=sachin.kamat@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.