All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Roger Pau Monné" <roger.pau@citrix.com>
To: Patrick Welche <prlw1@cam.ac.uk>
Cc: "xen-devel@lists.xen.org" <xen-devel@lists.xen.org>
Subject: Re: trivial build patch
Date: Wed, 17 Apr 2013 11:30:14 +0200	[thread overview]
Message-ID: <516E6BA6.9050103@citrix.com> (raw)
In-Reply-To: <20130416233936.GE1171@quark.inf.phy.private.cam.ac.uk>

On 17/04/13 01:39, Patrick Welche wrote:
> Trivial build fix for those of us not using bash... (xenbits.xen.org/xen)
> 
> Cheers,
> 
> Patrick
> 
> 
> 0001-test-1-uses-not-for-string-comparison.patch
> 
> 
> From f4431ab39b6056e4cceede2e8c40fc0b11b3bcc0 Mon Sep 17 00:00:00 2001
> From: Patrick Welche <prlw1@cam.ac.uk>
> Date: Wed, 10 Apr 2013 11:34:11 +0100
> Subject: [PATCH] test(1) uses = not == for string comparison

Thanks, but this patch is missing a SoB, please see:

http://wiki.xen.org/wiki/Submitting_Xen_Patches#Signing_off_a_patch

Apart from that:
Acked-by: Roger Pau Monné <roger.pau@citrix.com>

> ---
>  m4/path_or_fail.m4 | 2 +-
>  m4/python_devel.m4 | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/m4/path_or_fail.m4 b/m4/path_or_fail.m4
> index ece8cd4..04dee42 100644
> --- a/m4/path_or_fail.m4
> +++ b/m4/path_or_fail.m4
> @@ -1,6 +1,6 @@
>  AC_DEFUN([AX_PATH_PROG_OR_FAIL],
>  [AC_PATH_PROG([$1], [$2], [no])
> -if test x"${$1}" == x"no" 
> +if test x"${$1}" = x"no" 
>  then
>      AC_MSG_ERROR([Unable to find $2, please install $2])
>  fi])
> diff --git a/m4/python_devel.m4 b/m4/python_devel.m4
> index 0a2202c..659e7d4 100644
> --- a/m4/python_devel.m4
> +++ b/m4/python_devel.m4
> @@ -4,7 +4,7 @@ ac_previous_ldflags=$LDFLAGS
>  ac_python_version=`$PYTHON -c 'import distutils.sysconfig; \
>      print distutils.sysconfig.get_config_var("VERSION")'`
>  AC_PATH_PROG([pyconfig], [$PYTHON-config], [no])
> -AS_IF([test x"$pyconfig" == x"no"], [
> +AS_IF([test x"$pyconfig" = x"no"], [
>      dnl For those that don't have python-config
>      CPPFLAGS="$CFLAGS `$PYTHON -c 'import distutils.sysconfig; \
>          print "-I" + distutils.sysconfig.get_config_var("INCLUDEPY")'`"
> -- 1.8.2.1

  reply	other threads:[~2013-04-17  9:30 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-04-16 23:39 trivial build patch Patrick Welche
2013-04-17  9:30 ` Roger Pau Monné [this message]
2013-04-17 10:33   ` Patrick Welche
2013-04-17 13:00     ` George Dunlap
2013-04-17 15:01     ` Ian Campbell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=516E6BA6.9050103@citrix.com \
    --to=roger.pau@citrix.com \
    --cc=prlw1@cam.ac.uk \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.