trivial build patch

trivial build patch

[Patrick Welche]

[-- Attachment #1: Type: text/plain, Size: 92 bytes --]

Trivial build fix for those of us not using bash... (xenbits.xen.org/xen)

Cheers,

Patrick

[-- Attachment #2: 0001-test-1-uses-not-for-string-comparison.patch --]
[-- Type: text/plain, Size: 1288 bytes --]

>From f4431ab39b6056e4cceede2e8c40fc0b11b3bcc0 Mon Sep 17 00:00:00 2001
From: Patrick Welche <prlw1@cam.ac.uk>
Date: Wed, 10 Apr 2013 11:34:11 +0100
Subject: [PATCH] test(1) uses = not == for string comparison

---
 m4/path_or_fail.m4 | 2 +-
 m4/python_devel.m4 | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/m4/path_or_fail.m4 b/m4/path_or_fail.m4
index ece8cd4..04dee42 100644
--- a/m4/path_or_fail.m4
+++ b/m4/path_or_fail.m4
@@ -1,6 +1,6 @@
 AC_DEFUN([AX_PATH_PROG_OR_FAIL],
 [AC_PATH_PROG([$1], [$2], [no])
-if test x"${$1}" == x"no" 
+if test x"${$1}" = x"no" 
 then
     AC_MSG_ERROR([Unable to find $2, please install $2])
 fi])
diff --git a/m4/python_devel.m4 b/m4/python_devel.m4
index 0a2202c..659e7d4 100644
--- a/m4/python_devel.m4
+++ b/m4/python_devel.m4
@@ -4,7 +4,7 @@ ac_previous_ldflags=$LDFLAGS
 ac_python_version=`$PYTHON -c 'import distutils.sysconfig; \
     print distutils.sysconfig.get_config_var("VERSION")'`
 AC_PATH_PROG([pyconfig], [$PYTHON-config], [no])
-AS_IF([test x"$pyconfig" == x"no"], [
+AS_IF([test x"$pyconfig" = x"no"], [
     dnl For those that don't have python-config
     CPPFLAGS="$CFLAGS `$PYTHON -c 'import distutils.sysconfig; \
         print "-I" + distutils.sysconfig.get_config_var("INCLUDEPY")'`"
-- 
1.8.2.1


[-- Attachment #3: Type: text/plain, Size: 126 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

Re: trivial build patch

[Roger Pau Monné]

On 17/04/13 01:39, Patrick Welche wrote:
> Trivial build fix for those of us not using bash... (xenbits.xen.org/xen)
> 
> Cheers,
> 
> Patrick
> 
> 
> 0001-test-1-uses-not-for-string-comparison.patch
> 
> 
> From f4431ab39b6056e4cceede2e8c40fc0b11b3bcc0 Mon Sep 17 00:00:00 2001
> From: Patrick Welche <prlw1@cam.ac.uk>
> Date: Wed, 10 Apr 2013 11:34:11 +0100
> Subject: [PATCH] test(1) uses = not == for string comparison

Thanks, but this patch is missing a SoB, please see:

http://wiki.xen.org/wiki/Submitting_Xen_Patches#Signing_off_a_patch

Apart from that:
Acked-by: Roger Pau Monné <roger.pau@citrix.com>

> ---
>  m4/path_or_fail.m4 | 2 +-
>  m4/python_devel.m4 | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/m4/path_or_fail.m4 b/m4/path_or_fail.m4
> index ece8cd4..04dee42 100644
> --- a/m4/path_or_fail.m4
> +++ b/m4/path_or_fail.m4
> @@ -1,6 +1,6 @@
>  AC_DEFUN([AX_PATH_PROG_OR_FAIL],
>  [AC_PATH_PROG([$1], [$2], [no])
> -if test x"${$1}" == x"no" 
> +if test x"${$1}" = x"no" 
>  then
>      AC_MSG_ERROR([Unable to find $2, please install $2])
>  fi])
> diff --git a/m4/python_devel.m4 b/m4/python_devel.m4
> index 0a2202c..659e7d4 100644
> --- a/m4/python_devel.m4
> +++ b/m4/python_devel.m4
> @@ -4,7 +4,7 @@ ac_previous_ldflags=$LDFLAGS
>  ac_python_version=`$PYTHON -c 'import distutils.sysconfig; \
>      print distutils.sysconfig.get_config_var("VERSION")'`
>  AC_PATH_PROG([pyconfig], [$PYTHON-config], [no])
> -AS_IF([test x"$pyconfig" == x"no"], [
> +AS_IF([test x"$pyconfig" = x"no"], [
>      dnl For those that don't have python-config
>      CPPFLAGS="$CFLAGS `$PYTHON -c 'import distutils.sysconfig; \
>          print "-I" + distutils.sysconfig.get_config_var("INCLUDEPY")'`"
> -- 1.8.2.1

Re: trivial build patch

[Patrick Welche]

[-- Attachment #1: Type: text/plain, Size: 404 bytes --]

On Wed, Apr 17, 2013 at 11:30:14AM +0200, Roger Pau Monn wrote:
> On 17/04/13 01:39, Patrick Welche wrote:
> > Trivial build fix for those of us not using bash... (xenbits.xen.org/xen)

> Thanks, but this patch is missing a SoB, please see:
> 
> http://wiki.xen.org/wiki/Submitting_Xen_Patches#Signing_off_a_patch

Thanks for the note - I'll attempt git send-email in the future too...

Cheers,

Patrick

[-- Attachment #2: 0001-test-1-uses-not-for-string-comparison.patch --]
[-- Type: text/plain, Size: 1480 bytes --]

>From d2049651bd599bc7942c55eebe4da23023b6a9d2 Mon Sep 17 00:00:00 2001
From: Patrick Welche <prlw1@cam.ac.uk>
Date: Wed, 10 Apr 2013 11:34:11 +0100
Subject: [PATCH 1/2] test(1) uses = not == for string comparison
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Signed-off-by: Patrick Welche <prlw1@cam.ac.uk>
Acked-by: Roger Pau Monné <roger.pau@citrix.com>
---
 m4/path_or_fail.m4 | 2 +-
 m4/python_devel.m4 | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/m4/path_or_fail.m4 b/m4/path_or_fail.m4
index ece8cd4..04dee42 100644
--- a/m4/path_or_fail.m4
+++ b/m4/path_or_fail.m4
@@ -1,6 +1,6 @@
 AC_DEFUN([AX_PATH_PROG_OR_FAIL],
 [AC_PATH_PROG([$1], [$2], [no])
-if test x"${$1}" == x"no" 
+if test x"${$1}" = x"no" 
 then
     AC_MSG_ERROR([Unable to find $2, please install $2])
 fi])
diff --git a/m4/python_devel.m4 b/m4/python_devel.m4
index 0a2202c..659e7d4 100644
--- a/m4/python_devel.m4
+++ b/m4/python_devel.m4
@@ -4,7 +4,7 @@ ac_previous_ldflags=$LDFLAGS
 ac_python_version=`$PYTHON -c 'import distutils.sysconfig; \
     print distutils.sysconfig.get_config_var("VERSION")'`
 AC_PATH_PROG([pyconfig], [$PYTHON-config], [no])
-AS_IF([test x"$pyconfig" == x"no"], [
+AS_IF([test x"$pyconfig" = x"no"], [
     dnl For those that don't have python-config
     CPPFLAGS="$CFLAGS `$PYTHON -c 'import distutils.sysconfig; \
         print "-I" + distutils.sysconfig.get_config_var("INCLUDEPY")'`"
-- 
1.8.2.1


[-- Attachment #3: Type: text/plain, Size: 126 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

Re: trivial build patch

[George Dunlap]

On Wed, Apr 17, 2013 at 11:33 AM, Patrick Welche <prlw1@cam.ac.uk> wrote:
> On Wed, Apr 17, 2013 at 11:30:14AM +0200, Roger Pau Monn wrote:
>> On 17/04/13 01:39, Patrick Welche wrote:
>> > Trivial build fix for those of us not using bash... (xenbits.xen.org/xen)
>
>> Thanks, but this patch is missing a SoB, please see:
>>
>> http://wiki.xen.org/wiki/Submitting_Xen_Patches#Signing_off_a_patch
>
> Thanks for the note - I'll attempt git send-email in the future too...

>From a release perspective:

Acked-by: George Dunlap <george.dunlap@eu.citrix.com>

Re: trivial build patch

[Ian Campbell]

On Wed, 2013-04-17 at 11:33 +0100, Patrick Welche wrote:
> On Wed, Apr 17, 2013 at 11:30:14AM +0200, Roger Pau Monn wrote:
> > On 17/04/13 01:39, Patrick Welche wrote:
> > > Trivial build fix for those of us not using bash... (xenbits.xen.org/xen)
> 
> > Thanks, but this patch is missing a SoB, please see:
> > 
> > http://wiki.xen.org/wiki/Submitting_Xen_Patches#Signing_off_a_patch
> 
> Thanks for the note - I'll attempt git send-email in the future too...

Please.

I've applied this and rerun autogen.sh and added the phrase "Avoids a
bash-ism" to the commit message.