From: "Roger Pau Monné" <roger.pau@citrix.com>
To: Patrick Welche <prlw1@cam.ac.uk>
Cc: "xen-devel@lists.xen.org" <xen-devel@lists.xen.org>
Subject: Re: another trivial build fix
Date: Wed, 17 Apr 2013 11:33:40 +0200 [thread overview]
Message-ID: <516E6C74.6000100@citrix.com> (raw)
In-Reply-To: <20130417090333.GF1180@quark.inf.phy.private.cam.ac.uk>
On 17/04/13 11:03, Patrick Welche wrote:
> cp -d is a GNU extension, and only useful for links, which don't seem to
> exist in the directories being copied, so just remove said flag.
>
> Cheers,
>
> Patrick
>
>
> 0001-Don-t-use-non-portable-cp-d-flag-unnecessarily-no-li.patch
>
>
> From 6b274ae02e3f93709244f2af8aaa32128eca2137 Mon Sep 17 00:00:00 2001
> From: Patrick Welche <prlw1@cam.ac.uk>
> Date: Wed, 17 Apr 2013 09:59:38 +0100
> Subject: [PATCH] Don't use non-portable cp -d flag unnecessarily (no links are
> involved)
Again, the SoB is missing, also, could you include the description on
the email to the patch description?
Thanks, Roger.
>
> ---
> docs/Makefile | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/docs/Makefile b/docs/Makefile
> index fdebae8..5f319a1 100644
> --- a/docs/Makefile
> +++ b/docs/Makefile
> @@ -84,9 +84,9 @@ install: all
> $(INSTALL_DIR) $(DESTDIR)$(DOCDIR)
>
> $(INSTALL_DIR) $(DESTDIR)$(MANDIR)
> - cp -dR man1 $(DESTDIR)$(MANDIR)
> - cp -dR man5 $(DESTDIR)$(MANDIR)
> - [ ! -d html ] || cp -dR html $(DESTDIR)$(DOCDIR)
> + cp -R man1 $(DESTDIR)$(MANDIR)
> + cp -R man5 $(DESTDIR)$(MANDIR)
> + [ ! -d html ] || cp -R html $(DESTDIR)$(DOCDIR)
>
> html/index.html: $(DOC_HTML) ./gen-html-index INDEX
> perl -w -- ./gen-html-index -i INDEX html $(DOC_HTML)
> -- 1.8.2.1
next prev parent reply other threads:[~2013-04-17 9:33 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-17 9:03 another trivial build fix Patrick Welche
2013-04-17 9:33 ` Roger Pau Monné [this message]
2013-04-17 10:34 ` Patrick Welche
2013-04-17 13:00 ` George Dunlap
2013-04-17 15:01 ` Ian Campbell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=516E6C74.6000100@citrix.com \
--to=roger.pau@citrix.com \
--cc=prlw1@cam.ac.uk \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.