another trivial build fix

another trivial build fix

[Patrick Welche]

[-- Attachment #1: Type: text/plain, Size: 156 bytes --]

cp -d is a GNU extension, and only useful for links, which don't seem to
exist in the directories being copied, so just remove said flag.

Cheers,

Patrick

[-- Attachment #2: 0001-Don-t-use-non-portable-cp-d-flag-unnecessarily-no-li.patch --]
[-- Type: text/plain, Size: 899 bytes --]

>From 6b274ae02e3f93709244f2af8aaa32128eca2137 Mon Sep 17 00:00:00 2001
From: Patrick Welche <prlw1@cam.ac.uk>
Date: Wed, 17 Apr 2013 09:59:38 +0100
Subject: [PATCH] Don't use non-portable cp -d flag unnecessarily (no links are
 involved)

---
 docs/Makefile | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/docs/Makefile b/docs/Makefile
index fdebae8..5f319a1 100644
--- a/docs/Makefile
+++ b/docs/Makefile
@@ -84,9 +84,9 @@ install: all
 	$(INSTALL_DIR) $(DESTDIR)$(DOCDIR)
 
 	$(INSTALL_DIR) $(DESTDIR)$(MANDIR)
-	cp -dR man1 $(DESTDIR)$(MANDIR)
-	cp -dR man5 $(DESTDIR)$(MANDIR)
-	[ ! -d html ] || cp -dR html $(DESTDIR)$(DOCDIR)
+	cp -R man1 $(DESTDIR)$(MANDIR)
+	cp -R man5 $(DESTDIR)$(MANDIR)
+	[ ! -d html ] || cp -R html $(DESTDIR)$(DOCDIR)
 
 html/index.html: $(DOC_HTML) ./gen-html-index INDEX
 	perl -w -- ./gen-html-index -i INDEX html $(DOC_HTML)
-- 
1.8.2.1


[-- Attachment #3: Type: text/plain, Size: 126 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

Re: another trivial build fix

[Roger Pau Monné]

On 17/04/13 11:03, Patrick Welche wrote:
> cp -d is a GNU extension, and only useful for links, which don't seem to
> exist in the directories being copied, so just remove said flag.
> 
> Cheers,
> 
> Patrick
> 
> 
> 0001-Don-t-use-non-portable-cp-d-flag-unnecessarily-no-li.patch
> 
> 
> From 6b274ae02e3f93709244f2af8aaa32128eca2137 Mon Sep 17 00:00:00 2001
> From: Patrick Welche <prlw1@cam.ac.uk>
> Date: Wed, 17 Apr 2013 09:59:38 +0100
> Subject: [PATCH] Don't use non-portable cp -d flag unnecessarily (no links are
>  involved)

Again, the SoB is missing, also, could you include the description on
the email to the patch description?

Thanks, Roger.

> 
> ---
>  docs/Makefile | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/docs/Makefile b/docs/Makefile
> index fdebae8..5f319a1 100644
> --- a/docs/Makefile
> +++ b/docs/Makefile
> @@ -84,9 +84,9 @@ install: all
>  	$(INSTALL_DIR) $(DESTDIR)$(DOCDIR)
>  
>  	$(INSTALL_DIR) $(DESTDIR)$(MANDIR)
> -	cp -dR man1 $(DESTDIR)$(MANDIR)
> -	cp -dR man5 $(DESTDIR)$(MANDIR)
> -	[ ! -d html ] || cp -dR html $(DESTDIR)$(DOCDIR)
> +	cp -R man1 $(DESTDIR)$(MANDIR)
> +	cp -R man5 $(DESTDIR)$(MANDIR)
> +	[ ! -d html ] || cp -R html $(DESTDIR)$(DOCDIR)
>  
>  html/index.html: $(DOC_HTML) ./gen-html-index INDEX
>  	perl -w -- ./gen-html-index -i INDEX html $(DOC_HTML)
> -- 1.8.2.1 

Re: another trivial build fix

[Patrick Welche]

[-- Attachment #1: Type: text/plain, Size: 235 bytes --]

On Wed, Apr 17, 2013 at 11:33:40AM +0200, Roger Pau Monn wrote:
> Again, the SoB is missing, also, could you include the description on
> the email to the patch description?

OK - should I have added an Ack from you?

Cheers,

Patrick

[-- Attachment #2: 0002-Don-t-use-non-portable-cp-d-flag-unnecessarily-no-li.patch --]
[-- Type: text/plain, Size: 1090 bytes --]

>From a73c140a4e7b35735b08d41431a13e54053d3f50 Mon Sep 17 00:00:00 2001
From: Patrick Welche <prlw1@cam.ac.uk>
Date: Wed, 17 Apr 2013 09:59:38 +0100
Subject: [PATCH 2/2] Don't use non-portable cp -d flag unnecessarily (no links
 are involved)

cp -d is a GNU extension, and only useful for links, which don't seem
to exist in the directories being copied, so just remove said flag.

Signed-off-by: Patrick Welche <prlw1@cam.ac.uk>
---
 docs/Makefile | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/docs/Makefile b/docs/Makefile
index fdebae8..5f319a1 100644
--- a/docs/Makefile
+++ b/docs/Makefile
@@ -84,9 +84,9 @@ install: all
 	$(INSTALL_DIR) $(DESTDIR)$(DOCDIR)
 
 	$(INSTALL_DIR) $(DESTDIR)$(MANDIR)
-	cp -dR man1 $(DESTDIR)$(MANDIR)
-	cp -dR man5 $(DESTDIR)$(MANDIR)
-	[ ! -d html ] || cp -dR html $(DESTDIR)$(DOCDIR)
+	cp -R man1 $(DESTDIR)$(MANDIR)
+	cp -R man5 $(DESTDIR)$(MANDIR)
+	[ ! -d html ] || cp -R html $(DESTDIR)$(DOCDIR)
 
 html/index.html: $(DOC_HTML) ./gen-html-index INDEX
 	perl -w -- ./gen-html-index -i INDEX html $(DOC_HTML)
-- 
1.8.2.1


[-- Attachment #3: Type: text/plain, Size: 126 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

Re: another trivial build fix

[George Dunlap]

On Wed, Apr 17, 2013 at 11:34 AM, Patrick Welche <prlw1@cam.ac.uk> wrote:
> On Wed, Apr 17, 2013 at 11:33:40AM +0200, Roger Pau Monn wrote:
>> Again, the SoB is missing, also, could you include the description on
>> the email to the patch description?

>From a release perspective:

Acked-by: George Dunlap <george.dunlap@eu.citrix.com>

Re: another trivial build fix

[Ian Campbell]

On Wed, 2013-04-17 at 11:34 +0100, Patrick Welche wrote:
> On Wed, Apr 17, 2013 at 11:33:40AM +0200, Roger Pau Monn wrote:
> > Again, the SoB is missing, also, could you include the description on
> > the email to the patch description?

acked + Applied