From: swarren@wwwdotorg.org (Stephen Warren)
To: linux-arm-kernel@lists.infradead.org
Subject: [RFC PATCH 2/2] ARM: DT: kernel: DT cpu node bindings update
Date: Wed, 17 Apr 2013 10:23:38 -0600 [thread overview]
Message-ID: <516ECC8A.2070508@wwwdotorg.org> (raw)
In-Reply-To: <alpine.LFD.2.03.1304171146530.17375@syhkavp.arg>
On 04/17/2013 10:02 AM, Nicolas Pitre wrote:
> On Wed, 17 Apr 2013, Stephen Warren wrote:
>
>> On 04/17/2013 03:14 AM, Mark Rutland wrote:
>>> Hi Stephen,
>>>
>>>>> + - enable-method
>>>>> + Usage: required on ARM 64-bit systems, optional on ARM 32-bit
>>>>> + systems
>>>>> + Value type: <string>
>>>>> + Definition: On ARM 64-bit systems must be "spin-table" [1].
>>>>
>>>> Can that be an integer instead? with dtc+cpp support, that shouldn't
>>>> hurt the eyes too much any more.
>>>
>>> The "enable-method" property is described as a stringlist by ePAPR, and is
>>> currently in use on arm64 as such. It *must* remain a string(list) for arm64.
>>>
>>> Having it as an integer for arm is only going to cause us additional work,
>>> makes it impossible to share a common dt between 64bit and 32bit, and goes
>>> against the standard. I think it should be a stringlist for arm.
>>
>> OK, that's a great reason for this case.
>>
>> I hope we don't introduce any more standards that use strings, but that
>> may just be my personal preference...
>
> I think in any standard, strings are far easier to deal with.
> Especially with config stuff which is far from being performance
> critical. Strings are much less prone to conflicts. It is too easy to
> "extend" a standard by assigning meanings to free numerical values just
> to discover that someone else did use the same numbers for other
> meanings.
>
> In order to avoid this issue, a central authority has to be established
> to assign numbers out while strings are fine without that most of the
> time.
For DT, all strings or numbers must always be documented in the DT
binding, so there's no risk of conflict there.
WARNING: multiple messages have this Message-ID (diff)
From: Stephen Warren <swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
To: Nicolas Pitre <nicolas.pitre-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
Cc: Jon Medhurst <tixy-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
Catalin Marinas <Catalin.Marinas-5wv7dgnIgG8@public.gmane.org>,
Andrew Lunn <andrew-g2DYL2Zd6BY@public.gmane.org>,
Sekhar Nori <nsekhar-l0cyMroinI0@public.gmane.org>,
Lennert Buytenhek
<kernel-OLH4Qvv75CYX/NnBR394Jw@public.gmane.org>,
Kukjin Kim <kgene.kim-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>,
Russell King <linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org>,
Magnus Damm <magnus.damm-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
Viresh Kumar
<viresh.kumar-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
David Brown <davidb-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>,
"devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org"
<devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org>,
"rob.herring-bsGFqQB8/DxBDgjK7y7TUQ@public.gmane.org"
<rob.herring-bsGFqQB8/DxBDgjK7y7TUQ@public.gmane.org>,
Simon Horman <horms-/R6kz+dDXgpPR4JQBCEnsQ@public.gmane.org>,
Barry Song <baohua.song-kQvG35nSl+M@public.gmane.org>,
"linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org"
<linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org>,
Amit Kucheria
<amit.kucheria-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
Subject: Re: [RFC PATCH 2/2] ARM: DT: kernel: DT cpu node bindings update
Date: Wed, 17 Apr 2013 10:23:38 -0600 [thread overview]
Message-ID: <516ECC8A.2070508@wwwdotorg.org> (raw)
In-Reply-To: <alpine.LFD.2.03.1304171146530.17375-hIgblCxmbi8OMTOF05IoTw@public.gmane.org>
On 04/17/2013 10:02 AM, Nicolas Pitre wrote:
> On Wed, 17 Apr 2013, Stephen Warren wrote:
>
>> On 04/17/2013 03:14 AM, Mark Rutland wrote:
>>> Hi Stephen,
>>>
>>>>> + - enable-method
>>>>> + Usage: required on ARM 64-bit systems, optional on ARM 32-bit
>>>>> + systems
>>>>> + Value type: <string>
>>>>> + Definition: On ARM 64-bit systems must be "spin-table" [1].
>>>>
>>>> Can that be an integer instead? with dtc+cpp support, that shouldn't
>>>> hurt the eyes too much any more.
>>>
>>> The "enable-method" property is described as a stringlist by ePAPR, and is
>>> currently in use on arm64 as such. It *must* remain a string(list) for arm64.
>>>
>>> Having it as an integer for arm is only going to cause us additional work,
>>> makes it impossible to share a common dt between 64bit and 32bit, and goes
>>> against the standard. I think it should be a stringlist for arm.
>>
>> OK, that's a great reason for this case.
>>
>> I hope we don't introduce any more standards that use strings, but that
>> may just be my personal preference...
>
> I think in any standard, strings are far easier to deal with.
> Especially with config stuff which is far from being performance
> critical. Strings are much less prone to conflicts. It is too easy to
> "extend" a standard by assigning meanings to free numerical values just
> to discover that someone else did use the same numbers for other
> meanings.
>
> In order to avoid this issue, a central authority has to be established
> to assign numbers out while strings are fine without that most of the
> time.
For DT, all strings or numbers must always be documented in the DT
binding, so there's no risk of conflict there.
next prev parent reply other threads:[~2013-04-17 16:23 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-15 16:13 [RFC PATCH 0/2] ARM: DT cpu bindings updates Lorenzo Pieralisi
2013-04-15 16:13 ` Lorenzo Pieralisi
2013-04-15 16:13 ` [RFC PATCH 1/2] ARM: DT: kernel: move temporary cpu map stack array to static data Lorenzo Pieralisi
2013-04-15 16:13 ` Lorenzo Pieralisi
2013-04-15 16:13 ` [RFC PATCH 2/2] ARM: DT: kernel: DT cpu node bindings update Lorenzo Pieralisi
2013-04-15 16:13 ` Lorenzo Pieralisi
2013-04-15 19:26 ` Stephen Warren
2013-04-15 19:26 ` Stephen Warren
2013-04-16 10:45 ` Lorenzo Pieralisi
2013-04-16 10:45 ` Lorenzo Pieralisi
2013-04-16 15:57 ` Stephen Warren
2013-04-16 15:57 ` Stephen Warren
2013-04-16 16:21 ` Benjamin Herrenschmidt
2013-04-16 16:21 ` Benjamin Herrenschmidt
2013-04-16 14:30 ` Dave Martin
2013-04-16 14:30 ` Dave Martin
2013-04-17 9:14 ` Mark Rutland
2013-04-17 9:14 ` Mark Rutland
2013-04-17 15:14 ` Stephen Warren
2013-04-17 15:14 ` Stephen Warren
2013-04-17 16:02 ` Nicolas Pitre
2013-04-17 16:02 ` Nicolas Pitre
2013-04-17 16:23 ` Stephen Warren [this message]
2013-04-17 16:23 ` Stephen Warren
2013-04-17 16:36 ` Nicolas Pitre
2013-04-17 16:36 ` Nicolas Pitre
2013-04-17 16:56 ` Dave Martin
2013-04-17 16:56 ` Dave Martin
2013-04-17 16:24 ` Benjamin Herrenschmidt
2013-04-17 16:24 ` Benjamin Herrenschmidt
2013-04-18 12:40 ` Grant Likely
2013-04-18 12:40 ` Grant Likely
2013-04-16 2:41 ` Simon Horman
2013-04-16 2:41 ` Simon Horman
2013-04-16 11:00 ` Lorenzo Pieralisi
2013-04-16 11:00 ` Lorenzo Pieralisi
2013-04-17 9:35 ` Nicolas Ferre
2013-04-17 9:35 ` Nicolas Ferre
2013-04-17 11:44 ` Lorenzo Pieralisi
2013-04-17 11:44 ` Lorenzo Pieralisi
2013-04-17 9:48 ` Arnd Bergmann
2013-04-17 9:48 ` Arnd Bergmann
2013-04-17 11:02 ` Lorenzo Pieralisi
2013-04-17 11:02 ` Lorenzo Pieralisi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=516ECC8A.2070508@wwwdotorg.org \
--to=swarren@wwwdotorg.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.