All of lore.kernel.org
 help / color / mirror / Atom feed
From: "H. Peter Anvin" <hpa@zytor.com>
To: Robin Holt <holt@sgi.com>
Cc: Ingo Molnar <mingo@kernel.org>,
	"Srivatsa S. Bhat" <srivatsa.bhat@linux.vnet.ibm.com>,
	Russ Anderson <rja@sgi.com>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	the arch/x86 maintainers <x86@kernel.org>
Subject: Re: [PATCH -v5 5/5] Make reboot_cpuid a kernel parameter.
Date: Wed, 17 Apr 2013 12:59:57 -0700	[thread overview]
Message-ID: <516EFF3D.4040506@zytor.com> (raw)
In-Reply-To: <20130417194836.GK3658@sgi.com>

It is also worth noting that the documentation says reboot=s[mp]#
whereas in fact only reboot=s# parse correctly.  I consider this to be a
bug.

If we centralized the parser, we could take a string like

"reboot=bios,smp32,warm"

and parse it into:

reboot_cpu = 32
reboot_mode = "bw"

... and pass the information in that form to the arch layer.  I don't
think we can do more parsing at that in the main kernel.

	-hpa


  parent reply	other threads:[~2013-04-17 20:00 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-04-17 18:43 [PATCH -v5 0/5] Shutdown from reboot_cpuid without stopping other cpus Robin Holt
2013-04-17 18:43 ` [PATCH -v5 1/5] CPU hotplug: Provide a generic helper to disable/enable CPU hotplug Robin Holt
2013-04-17 18:43 ` [PATCH -v5 2/5] Migrate shutdown/reboot to boot cpu Robin Holt
2013-04-17 18:43 ` [PATCH -v5 3/5] Move shutdown/reboot related functions to kernel/reboot.c Robin Holt
2013-04-17 18:43 ` [PATCH -v5 4/5] checkpatch.pl the new kernel/reboot.c file Robin Holt
2013-04-17 19:13   ` Robin Holt
2013-04-17 18:43 ` [PATCH -v5 5/5] Make reboot_cpuid a kernel parameter Robin Holt
2013-04-17 19:37   ` H. Peter Anvin
2013-04-17 19:48     ` Robin Holt
2013-04-17 19:55       ` H. Peter Anvin
2013-04-17 19:59       ` H. Peter Anvin [this message]
2013-04-17 20:15         ` Robin Holt
2013-04-18  0:17           ` Robin Holt
2013-04-18  0:28             ` H. Peter Anvin
2013-04-18  0:39             ` H. Peter Anvin
2013-04-18  1:25               ` Robin Holt
2013-04-18  2:04                 ` Robin Holt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=516EFF3D.4040506@zytor.com \
    --to=hpa@zytor.com \
    --cc=holt@sgi.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=rja@sgi.com \
    --cc=srivatsa.bhat@linux.vnet.ibm.com \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.