From: Eduardo Valentin <eduardo.valentin@ti.com>
To: "Zhang, Rui" <rui.zhang@intel.com>
Cc: eduardo.valentin@ti.com,
Amit Daniel Kachhap <amit.daniel@samsung.com>,
"linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
"linux-kernel@vger.kernel.org >>
\"linux-kernel@vger.kernel.org\"" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 00/30] thermal: cpu_cooling: code improvements
Date: Wed, 17 Apr 2013 16:32:53 -0400 [thread overview]
Message-ID: <516F06F5.9060200@ti.com> (raw)
In-Reply-To: <1366218743-20841-1-git-send-email-eduardo.valentin@ti.com>
On 17-04-2013 13:11, Eduardo Valentin wrote:
> Rui,
Looks like I forgot to add the lists on patch 00. Doing so..
>
> This is a series of patches to improve the code for cpu_cooling.
> Majority of these changes are actually kernel-doc updates, as
> they required to be revised. A part from these, there are some
> changes regarding code style and readiness.
>
> Some may complain that these are a matter of taste, indeed.
> But I tried to just be unbiased and just keep the changes related
> to kernel-doc and checkpatch.pl. After this series, theses
> tools should be generating decent output ;-).
>
> The remaining changes are actually a couple of fixes for defensive
> coding. A part from updating the MAINTAINERS entry to cover cpu_cooling.
>
> This series has been tested on TI OMAP4430, together with the
> thermal driver under staging tree.
>
> All these patches are based on current linux-next/master.
>
> They are also available here:
>
> All best,
>
> Eduardo Valentin (30):
> thermal: cpu_cooling: remove unused headers
> thermal: cpu_cooling: remove trailing white spaces
> thermal: cpu_cooling: fix kernel_doc for cpufreq_cooling_device
> thermal: cpu_cooling: use EXPORT_SYMBOL_GPL
> thermal: cpu_cooling: remove compiler warning
> thermal: cpu_cooling: standardize end of function
> thermal: cpu_cooling: fix kernel doc for is_cpufreq_valid
> thermal: cpu_cooling: add documentation for get_property
> thermal: cpu_cooling: standardize comment style
> thermal: cpu_cooling: align on open parenthesis
> thermal: cpu_cooling: remove trailing blank line
> thermal: cpu_cooling: document cpufreq_get_cooling_level
> thermal: cpu_cooling: remove checkpatch.pl warning
> thermal: cpu_cooling: improve documentation for get_cpu_frequency
> thermal: cpu_cooling: update documentation for cpufreq_apply_cooling
> thermal: cpu_cooling: update documentation for
> cpufreq_thermal_notifier
> thermal: cpu_cooling: update Kconfig entry
> thermal: cpu_cooling: alignment improvements
> thermal: cpu_cooling: update documentation for cpufreq_get_max_state
> thermal: cpu_cooling: update documentation for cpufreq_get_cur_state
> thermal: cpu_cooling: update documentation for cpufreq_set_cur_state
> thermal: cpu_cooling: update kernel-doc for cpufreq_cooling_register
> thermal: cpu_cooling: update kernel-doc comment for
> cpufreq_cooling_unregister
> thermal: cpu_cooling: use snprintf instead of sprintf
> thermal: cpu_cooling: remove not needed curl brackets
> thermal: cpu_cooling: remove unused symbols
> thermal: cpu_cooling: add needed header for cpu_cooling.h
> MAINTAINERS: update thermal entry by adding file cpu_cooling.h
> thermal: cpu_cooling: remove unused symbols on cpu_cooling.h
> thermal: cpu_cooling: improve line breaking
>
> MAINTAINERS | 1 +
> drivers/thermal/Kconfig | 5 +-
> drivers/thermal/cpu_cooling.c | 156 ++++++++++++++++++++++++++++++------------
> include/linux/cpu_cooling.h | 20 +++---
> 4 files changed, 125 insertions(+), 57 deletions(-)
>
WARNING: multiple messages have this Message-ID (diff)
From: Eduardo Valentin <eduardo.valentin@ti.com>
To: "Zhang, Rui" <rui.zhang@intel.com>
Cc: <eduardo.valentin@ti.com>,
Amit Daniel Kachhap <amit.daniel@samsung.com>,
"linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
"linux-kernel@vger.kernel.org >>
\"linux-kernel@vger.kernel.org\"" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 00/30] thermal: cpu_cooling: code improvements
Date: Wed, 17 Apr 2013 16:32:53 -0400 [thread overview]
Message-ID: <516F06F5.9060200@ti.com> (raw)
In-Reply-To: <1366218743-20841-1-git-send-email-eduardo.valentin@ti.com>
On 17-04-2013 13:11, Eduardo Valentin wrote:
> Rui,
Looks like I forgot to add the lists on patch 00. Doing so..
>
> This is a series of patches to improve the code for cpu_cooling.
> Majority of these changes are actually kernel-doc updates, as
> they required to be revised. A part from these, there are some
> changes regarding code style and readiness.
>
> Some may complain that these are a matter of taste, indeed.
> But I tried to just be unbiased and just keep the changes related
> to kernel-doc and checkpatch.pl. After this series, theses
> tools should be generating decent output ;-).
>
> The remaining changes are actually a couple of fixes for defensive
> coding. A part from updating the MAINTAINERS entry to cover cpu_cooling.
>
> This series has been tested on TI OMAP4430, together with the
> thermal driver under staging tree.
>
> All these patches are based on current linux-next/master.
>
> They are also available here:
>
> All best,
>
> Eduardo Valentin (30):
> thermal: cpu_cooling: remove unused headers
> thermal: cpu_cooling: remove trailing white spaces
> thermal: cpu_cooling: fix kernel_doc for cpufreq_cooling_device
> thermal: cpu_cooling: use EXPORT_SYMBOL_GPL
> thermal: cpu_cooling: remove compiler warning
> thermal: cpu_cooling: standardize end of function
> thermal: cpu_cooling: fix kernel doc for is_cpufreq_valid
> thermal: cpu_cooling: add documentation for get_property
> thermal: cpu_cooling: standardize comment style
> thermal: cpu_cooling: align on open parenthesis
> thermal: cpu_cooling: remove trailing blank line
> thermal: cpu_cooling: document cpufreq_get_cooling_level
> thermal: cpu_cooling: remove checkpatch.pl warning
> thermal: cpu_cooling: improve documentation for get_cpu_frequency
> thermal: cpu_cooling: update documentation for cpufreq_apply_cooling
> thermal: cpu_cooling: update documentation for
> cpufreq_thermal_notifier
> thermal: cpu_cooling: update Kconfig entry
> thermal: cpu_cooling: alignment improvements
> thermal: cpu_cooling: update documentation for cpufreq_get_max_state
> thermal: cpu_cooling: update documentation for cpufreq_get_cur_state
> thermal: cpu_cooling: update documentation for cpufreq_set_cur_state
> thermal: cpu_cooling: update kernel-doc for cpufreq_cooling_register
> thermal: cpu_cooling: update kernel-doc comment for
> cpufreq_cooling_unregister
> thermal: cpu_cooling: use snprintf instead of sprintf
> thermal: cpu_cooling: remove not needed curl brackets
> thermal: cpu_cooling: remove unused symbols
> thermal: cpu_cooling: add needed header for cpu_cooling.h
> MAINTAINERS: update thermal entry by adding file cpu_cooling.h
> thermal: cpu_cooling: remove unused symbols on cpu_cooling.h
> thermal: cpu_cooling: improve line breaking
>
> MAINTAINERS | 1 +
> drivers/thermal/Kconfig | 5 +-
> drivers/thermal/cpu_cooling.c | 156 ++++++++++++++++++++++++++++++------------
> include/linux/cpu_cooling.h | 20 +++---
> 4 files changed, 125 insertions(+), 57 deletions(-)
>
next prev parent reply other threads:[~2013-04-17 20:33 UTC|newest]
Thread overview: 78+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1366218743-20841-1-git-send-email-eduardo.valentin@ti.com>
2013-04-17 17:11 ` [PATCH 01/30] thermal: cpu_cooling: remove unused headers Eduardo Valentin
2013-04-17 17:11 ` Eduardo Valentin
2013-04-22 2:16 ` amit daniel kachhap
2013-04-24 14:44 ` Zhang, Rui
2013-04-24 16:31 ` Zhang, Rui
2013-04-24 16:38 ` Zhang, Rui
2013-04-17 17:11 ` [PATCH 02/30] thermal: cpu_cooling: remove trailing white spaces Eduardo Valentin
2013-04-17 17:11 ` Eduardo Valentin
2013-04-24 14:48 ` Zhang, Rui
2013-04-24 15:13 ` Zhang, Rui
2013-04-24 17:44 ` Eduardo Valentin
2013-04-17 17:11 ` [PATCH 03/30] thermal: cpu_cooling: fix kernel_doc for cpufreq_cooling_device Eduardo Valentin
2013-04-17 17:11 ` Eduardo Valentin
2013-04-22 2:18 ` amit kachhap
2013-04-24 14:49 ` Zhang, Rui
2013-04-17 17:11 ` [PATCH 04/30] thermal: cpu_cooling: use EXPORT_SYMBOL_GPL Eduardo Valentin
2013-04-17 17:11 ` Eduardo Valentin
2013-04-24 14:50 ` Zhang, Rui
2013-04-17 17:11 ` [PATCH 05/30] thermal: cpu_cooling: remove compiler warning Eduardo Valentin
2013-04-17 17:11 ` Eduardo Valentin
2013-04-17 17:11 ` [PATCH 06/30] thermal: cpu_cooling: standardize end of function Eduardo Valentin
2013-04-17 17:11 ` Eduardo Valentin
2013-04-17 17:12 ` [PATCH 07/30] thermal: cpu_cooling: fix kernel doc for is_cpufreq_valid Eduardo Valentin
2013-04-17 17:12 ` Eduardo Valentin
2013-04-17 17:12 ` [PATCH 08/30] thermal: cpu_cooling: add documentation for get_property Eduardo Valentin
2013-04-17 17:12 ` Eduardo Valentin
2013-04-17 17:12 ` [PATCH 09/30] thermal: cpu_cooling: standardize comment style Eduardo Valentin
2013-04-17 17:12 ` Eduardo Valentin
2013-04-17 17:12 ` [PATCH 10/30] thermal: cpu_cooling: align on open parenthesis Eduardo Valentin
2013-04-17 17:12 ` Eduardo Valentin
2013-04-17 17:12 ` [PATCH 11/30] thermal: cpu_cooling: remove trailing blank line Eduardo Valentin
2013-04-17 17:12 ` Eduardo Valentin
2013-04-17 17:12 ` [PATCH 12/30] thermal: cpu_cooling: document cpufreq_get_cooling_level Eduardo Valentin
2013-04-17 17:12 ` Eduardo Valentin
2013-04-17 17:12 ` [PATCH 13/30] thermal: cpu_cooling: remove checkpatch.pl warning Eduardo Valentin
2013-04-17 17:12 ` Eduardo Valentin
2013-04-17 17:12 ` [PATCH 14/30] thermal: cpu_cooling: improve documentation for get_cpu_frequency Eduardo Valentin
2013-04-17 17:12 ` Eduardo Valentin
2013-04-17 17:12 ` [PATCH 15/30] thermal: cpu_cooling: update documentation for cpufreq_apply_cooling Eduardo Valentin
2013-04-17 17:12 ` Eduardo Valentin
2013-04-17 17:12 ` [PATCH 16/30] thermal: cpu_cooling: update documentation for cpufreq_thermal_notifier Eduardo Valentin
2013-04-17 17:12 ` Eduardo Valentin
2013-04-17 17:12 ` [PATCH 17/30] thermal: cpu_cooling: update Kconfig entry Eduardo Valentin
2013-04-17 17:12 ` Eduardo Valentin
2013-04-17 17:12 ` [PATCH 18/30] thermal: cpu_cooling: alignment improvements Eduardo Valentin
2013-04-17 17:12 ` Eduardo Valentin
2013-04-17 17:12 ` [PATCH 19/30] thermal: cpu_cooling: update documentation for cpufreq_get_max_state Eduardo Valentin
2013-04-17 17:12 ` Eduardo Valentin
2013-04-17 17:12 ` [PATCH 20/30] thermal: cpu_cooling: update documentation for cpufreq_get_cur_state Eduardo Valentin
2013-04-17 17:12 ` Eduardo Valentin
2013-04-17 17:12 ` [PATCH 21/30] thermal: cpu_cooling: update documentation for cpufreq_set_cur_state Eduardo Valentin
2013-04-17 17:12 ` Eduardo Valentin
2013-04-17 17:12 ` [PATCH 22/30] thermal: cpu_cooling: update kernel-doc for cpufreq_cooling_register Eduardo Valentin
2013-04-17 17:12 ` Eduardo Valentin
2013-04-17 17:12 ` [PATCH 23/30] thermal: cpu_cooling: update kernel-doc comment for cpufreq_cooling_unregister Eduardo Valentin
2013-04-17 17:12 ` Eduardo Valentin
2013-04-17 17:12 ` [PATCH 24/30] thermal: cpu_cooling: use snprintf instead of sprintf Eduardo Valentin
2013-04-17 17:12 ` Eduardo Valentin
2013-04-17 17:12 ` [PATCH 25/30] thermal: cpu_cooling: remove not needed curl brackets Eduardo Valentin
2013-04-17 17:12 ` Eduardo Valentin
2013-04-17 17:12 ` [PATCH 26/30] thermal: cpu_cooling: remove unused symbols Eduardo Valentin
2013-04-17 17:12 ` Eduardo Valentin
2013-04-24 14:52 ` Zhang, Rui
2013-04-24 17:33 ` Eduardo Valentin
2013-04-17 17:12 ` [PATCH 27/30] thermal: cpu_cooling: add needed header for cpu_cooling.h Eduardo Valentin
2013-04-17 17:12 ` [PATCH 28/30] MAINTAINERS: update thermal entry by adding file cpu_cooling.h Eduardo Valentin
2013-04-17 17:12 ` Eduardo Valentin
2013-04-24 17:34 ` Eduardo Valentin
2013-04-24 17:34 ` Eduardo Valentin
2013-04-24 23:40 ` Zhang Rui
2013-04-17 17:12 ` [PATCH 29/30] thermal: cpu_cooling: remove unused symbols on cpu_cooling.h Eduardo Valentin
2013-04-17 17:12 ` Eduardo Valentin
2013-04-17 17:12 ` [PATCH 30/30] thermal: cpu_cooling: improve line breaking Eduardo Valentin
2013-04-17 17:12 ` Eduardo Valentin
2013-04-17 20:32 ` Eduardo Valentin [this message]
2013-04-17 20:32 ` [PATCH 00/30] thermal: cpu_cooling: code improvements Eduardo Valentin
2013-04-22 2:34 ` amit daniel kachhap
2013-04-22 13:07 ` Eduardo Valentin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=516F06F5.9060200@ti.com \
--to=eduardo.valentin@ti.com \
--cc=amit.daniel@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rui.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.