From: Alex Shi <alex.shi@intel.com>
To: "Rafael J. Wysocki" <rjw@sisk.pl>
Cc: Linux PM list <linux-pm@vger.kernel.org>,
"Brown, Len" <len.brown@intel.com>,
"Wysocki, Rafael J" <rafael.j.wysocki@intel.com>,
Arjan van de Ven <arjan@linux.intel.com>,
LKP ML <lkp@linux.intel.com>,
Viresh Kumar <viresh.kumar@linaro.org>
Subject: Re: bltk-game regressions on snb laptop
Date: Thu, 18 Apr 2013 08:23:45 +0800 [thread overview]
Message-ID: <516F3D11.1020404@intel.com> (raw)
In-Reply-To: <4800526.1vKQhy36XA@vostro.rjw.lan>
On 04/18/2013 12:34 AM, Rafael J. Wysocki wrote:
> On Tuesday, April 16, 2013 03:14:31 PM Alex Shi wrote:
>> LKP found a performance and performance/watt regression on commit
>> aa77a52764a92216b61, acpi-cpufreq: Don't set policy->related_cpus from
>> .init.
>>
>> The commit removed the related_cpus setting, plus Our laptop has no
>> coordinate type setting in BIOS. So the related_cpus is only include the
>> cpu self, then the policy->cpus are impacted and only has self too.
>>
>> With ondemand governor, the bad commit cause bltk-game benchmark drop to
>> 18fps from 50fps, the performance/watt value also dropped a lot.
>> bltk-game runs 9 thread on the 4core*HT laptop.
>>
>> As Arjan and Len mentioned, the commit is correct in logical,
>> policy->cpus should only include the cpu self.
>> So I don't know where is the problem, maybe ondemand or some place
>> others. Anyway, I just report the issue to you.
>
> Have you verified that reverting the commit in question causes the problem to
> go away?
yes, after revert, the fps is back to about 50fps from 18fps.
>
> Rafael
>
>
--
Thanks Alex
next prev parent reply other threads:[~2013-04-18 0:24 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-16 7:14 bltk-game regressions on snb laptop Alex Shi
2013-04-17 16:34 ` Rafael J. Wysocki
2013-04-18 0:23 ` Alex Shi [this message]
2013-04-17 16:46 ` Viresh Kumar
2013-04-18 0:48 ` Alex Shi
2013-04-18 4:26 ` Viresh Kumar
2013-04-18 4:36 ` Viresh Kumar
2013-04-18 5:24 ` Alex Shi
2013-04-18 5:16 ` Alex Shi
2013-04-18 5:37 ` Viresh Kumar
2013-04-18 6:16 ` Alex Shi
2013-04-18 8:54 ` Alex Shi
2013-04-18 10:01 ` Viresh Kumar
2013-04-19 10:00 ` Alex Shi
2013-04-19 12:23 ` Viresh Kumar
2013-04-19 14:43 ` Alex Shi
2013-04-19 15:44 ` Arjan van de Ven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=516F3D11.1020404@intel.com \
--to=alex.shi@intel.com \
--cc=arjan@linux.intel.com \
--cc=len.brown@intel.com \
--cc=linux-pm@vger.kernel.org \
--cc=lkp@linux.intel.com \
--cc=rafael.j.wysocki@intel.com \
--cc=rjw@sisk.pl \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.