Re: [Qemu-devel] [PATCH 11/11] savevm: remove backward compatibility from bdrv_snapshot_find()

[Wenchao Xia <xiawenc@linux.vnet.ibm.com>]

>> So, was I convincing enough in arguing that we want something different
>> from the approach of both existing patch series?
>>
>    Plenty of details, thanks, Eric. I think Pavel's logic is better,
> which increase the capability of it, and I don't think a more complex
> logic should be there, since it is an internal function need clear
> meaning.
>
>
>>>
>>
>    I understand it helps, but now I need just a good
> bdrv_snapshot_find() to use, so could this improvement work
> be postponded later? I think neither my or Pavel's work
> is depending on it.
>    Pavel, to make us progress, I'd like a small serial change
> bdrv_snapshot_find() first, then we can rebase on it, are u OK
> with it?
>
> block/qapi.c:
> int bdrv_snapshot_find(BlockDriverState *bs, QEMUSnapshotInfo *sn_info,
>                         const char *name, const char *id)
>
>
>
   Actually my serial, two condition are "or" relationship,
but in Pavel's they are "and" relationship. From caller,
I think "and" is better, and taking two parameter in one function
make caller easier to use, in most case.
   I'd like a clean serial go for it, hope to know Pavel and
Markus's idea.

-- 
Best Regards

Wenchao Xia