All of lore.kernel.org
 help / color / mirror / Atom feed
From: Pavel Hrdina <phrdina@redhat.com>
To: qemu-devel@nongnu.org
Cc: phrdina@redhat.com, armbru@redhat.com, lcapitulino@redhat.com
Subject: [Qemu-devel] [PATCH 00/11] covert savevm, loadvm and delvm into qapi
Date: Tue, 16 Apr 2013 18:05:12 +0200	[thread overview]
Message-ID: <cover.1366127809.git.phrdina@redhat.com> (raw)

I'm sending patches for all commands in one patch series because the
savevm command depends on delvm command.

This patch series introduces new design of these commands:

* QMP vm-snapshot-save:
    - { 'command': 'vm-snapshot-save',
        'data': { 'name': 'str' },
        'returns': 'SnapshotInfo' }
    - vm-snapshot-save returns an error if there is an existing snapshot with
      the same name
    - you cannot provide an id for a new snapshot
    - all information about created snapshot will be returned

* QMP vm-snapshot-load
    - { 'command': 'vm-snapshot-load',
        'data': { '*name': 'str', '*id': 'str' },
        'returns': 'SnapshotInfo' }
    - one of the name or id must be provided
    - if both are provided they will match only the snapshot with the same name
      and id
    - returns SnapshotInfo only if the snapshot exists.

* QMP vm-snapshot-delete:
    - { 'command': 'vm-snapshot-delete',
        'data': { '*name': 'str', '*id': 'str' },
        'returns': 'SnapshotInfo' }
    - same rules as vm-snapshot-load

* HMP savevm:
    - args_type = "force:-f,name:s?",
    - if the name is not provided the HMP command will generates new one for QMP
      command
    - if there is already a snapshot with provided or generated name it will
      fails
    - there will be an optional -f parameter to force saving requested snapshot
      and it will internally use vm-snapshot-delete and then vm-snapshot-save
    - all information about created snapshot will be printed

* HMP loadvm:
    - args_type = "id:-i,name:s",
    - follow the same behavior as the QMP command
    - it load snapshot that match the provided name
    - if an id flag is provided, it load snapshot that match the name parameter
      as an id of snapshot

* HMP delvm:
    - args_type = "id:-i,name:s"
    - same rules as loadvm

Pavel Hrdina (11):
  qemu-img: introduce qemu_img_handle_error()
  block: update error reporting for bdrv_snapshot_delete() and related
    functions
  savevm: update bdrv_snapshot_find() to find snapshot by id or name
  qapi: Convert delvm
  block: update error reporting for bdrv_snapshot_goto() and related
    functions
  savevm: update error reporting for qemu_loadvm_state()
  qapi: Convert loadvm
  block: update error reporting for bdrv_snapshot_create() and related
    functions
  savevm: update error reporting off qemu_savevm_state() and related
    functions
  qapi: Convert savevm
  savevm: remove backward compatibility from bdrv_snapshot_find()

 block.c                   | 100 +++++++------
 block/qcow2-snapshot.c    |  71 ++++++---
 block/qcow2.h             |  16 +-
 block/rbd.c               |  50 ++++---
 block/sheepdog.c          |  61 ++++----
 hmp-commands.hx           |  48 +++---
 hmp.c                     | 119 +++++++++++++++
 hmp.h                     |   3 +
 include/block/block.h     |  17 ++-
 include/block/block_int.h |  17 ++-
 include/sysemu/sysemu.h   |  12 +-
 migration.c               |  15 +-
 monitor.c                 |  12 --
 qapi-schema.json          |  54 +++++++
 qemu-img.c                |  54 ++++---
 qmp-commands.hx           | 127 +++++++++++++++-
 savevm.c                  | 363 +++++++++++++++++++++++++---------------------
 vl.c                      |   7 +-
 18 files changed, 782 insertions(+), 364 deletions(-)

-- 
1.8.1.4

             reply	other threads:[~2013-04-16 16:05 UTC|newest]

Thread overview: 48+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-04-16 16:05 Pavel Hrdina [this message]
2013-04-16 16:05 ` [Qemu-devel] [PATCH 01/11] qemu-img: introduce qemu_img_handle_error() Pavel Hrdina
2013-04-16 16:46   ` Eric Blake
2013-04-18 11:44   ` Kevin Wolf
2013-04-18 11:52     ` Pavel Hrdina
2013-04-18 12:59       ` Kevin Wolf
2013-04-18 13:09         ` Pavel Hrdina
2013-04-18 15:23           ` Luiz Capitulino
2013-04-16 16:05 ` [Qemu-devel] [PATCH 02/11] block: update error reporting for bdrv_snapshot_delete() and related functions Pavel Hrdina
2013-04-16 17:14   ` Eric Blake
2013-04-18 12:55   ` Kevin Wolf
2013-04-18 13:09     ` Eric Blake
2013-04-18 13:51       ` Kevin Wolf
2013-04-18 13:19     ` Pavel Hrdina
2013-04-18 13:41       ` Kevin Wolf
2013-04-16 16:05 ` [Qemu-devel] [PATCH 03/11] savevm: update bdrv_snapshot_find() to find snapshot by id or name Pavel Hrdina
2013-04-16 17:34   ` Eric Blake
2013-04-18 13:17   ` Kevin Wolf
2013-04-16 16:05 ` [Qemu-devel] [PATCH 04/11] qapi: Convert delvm Pavel Hrdina
2013-04-16 19:39   ` Eric Blake
2013-04-18 13:28   ` Kevin Wolf
2013-04-16 16:05 ` [Qemu-devel] [PATCH 05/11] block: update error reporting for bdrv_snapshot_goto() and related functions Pavel Hrdina
2013-04-16 20:48   ` Eric Blake
2013-04-23 14:08   ` Kevin Wolf
2013-04-16 16:05 ` [Qemu-devel] [PATCH 06/11] savevm: update error reporting for qemu_loadvm_state() Pavel Hrdina
2013-04-16 21:42   ` Eric Blake
2013-04-16 16:05 ` [Qemu-devel] [PATCH 07/11] qapi: Convert loadvm Pavel Hrdina
2013-04-16 23:43   ` Eric Blake
2013-04-18 10:34     ` Pavel Hrdina
2013-04-16 16:05 ` [Qemu-devel] [PATCH 08/11] block: update error reporting for bdrv_snapshot_create() and related functions Pavel Hrdina
2013-04-16 23:54   ` Eric Blake
2013-04-16 16:05 ` [Qemu-devel] [PATCH 09/11] savevm: update error reporting off qemu_savevm_state() " Pavel Hrdina
2013-04-17  0:02   ` Eric Blake
2013-04-16 16:05 ` [Qemu-devel] [PATCH 10/11] qapi: Convert savevm Pavel Hrdina
2013-04-16 16:05 ` [Qemu-devel] [PATCH 11/11] savevm: remove backward compatibility from bdrv_snapshot_find() Pavel Hrdina
2013-04-17  2:53   ` Wenchao Xia
2013-04-17  7:52     ` Pavel Hrdina
2013-04-17 10:19       ` Wenchao Xia
2013-04-17 10:51         ` Pavel Hrdina
2013-04-17 18:14           ` Eric Blake
2013-04-17 18:22             ` Eric Blake
2013-04-18  4:31             ` Wenchao Xia
2013-04-18  7:20               ` Wenchao Xia
2013-04-18 10:22               ` Pavel Hrdina
2013-04-19  0:28                 ` Wenchao Xia
2013-04-24  3:51                   ` Wenchao Xia
2013-04-24  9:37                     ` Pavel Hrdina
2013-04-16 16:33 ` [Qemu-devel] [PATCH 00/11] covert savevm, loadvm and delvm into qapi Eric Blake

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cover.1366127809.git.phrdina@redhat.com \
    --to=phrdina@redhat.com \
    --cc=armbru@redhat.com \
    --cc=lcapitulino@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.