All of lore.kernel.org
 help / color / mirror / Atom feed
From: Matt Porter <mporter@ti.com>
To: Christian Eggers <ceggers@gmx.de>
Cc: <linux-kernel@vger.kernel.org>,
	<spi-devel-general@lists.sourceforge.net>
Subject: Re: spi: spi-davinci: Fix direction in dma_map_single()
Date: Thu, 18 Apr 2013 15:53:16 -0400	[thread overview]
Message-ID: <51704F2C.6060901@ti.com> (raw)
In-Reply-To: <2298140.4jrJLRXeBJ@p2400>

On 04/18/2013 03:31 PM, Christian Eggers wrote:
> Commit 048177ce3b3962852fd34a7e04938959271c7e70 (spi: spi-davinci:
>
> convert to DMA engine API) introduced a regression: dma_map_single()
>
> is called with direction DMA_FROM_DEVICE for rx and for tx.
>
> Signed-off-by: Christian Eggers <ceggers@gmx.de>
>
> Cc: stable@vger.kernel.org

Cc: stable@vger.kernel.org # v3.7.x+
will get this applied to the correct stable kernels.

I'm wearing the brown bag for this one so other than fixing the Cc: it 
looks good.

Acked-by: Matt Porter <mporter@ti.com>

> --- drivers/spi/spi-davinci.c.orig 2013-04-18 20:54:02.728719412 +0200
>
> +++ drivers/spi/spi-davinci.c 2013-04-18 20:54:51.900623956 +0200
>
> @@ -608,7 +608,7 @@ static int davinci_spi_bufs(struct spi_d
>
> else
>
> buf = (void *)t->tx_buf;
>
> t->tx_dma = dma_map_single(&spi->dev, buf,
>
> - t->len, DMA_FROM_DEVICE);
>
> + t->len, DMA_TO_DEVICE);
>
> if (!t->tx_dma) {
>
> ret = -EFAULT;
>
> goto err_tx_map;
>

  reply	other threads:[~2013-04-18 19:53 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-04-18 19:31 spi: spi-davinci: Fix direction in dma_map_single() Christian Eggers
2013-04-18 19:53 ` Matt Porter [this message]
  -- strict thread matches above, loose matches on Subject: below --
2013-04-18 19:44 Christian Eggers
2013-04-18 19:44 ` Christian Eggers

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51704F2C.6060901@ti.com \
    --to=mporter@ti.com \
    --cc=ceggers@gmx.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=spi-devel-general@lists.sourceforge.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.