* spi: spi-davinci: Fix direction in dma_map_single()
@ 2013-04-18 19:31 Christian Eggers
2013-04-18 19:53 ` Matt Porter
0 siblings, 1 reply; 4+ messages in thread
From: Christian Eggers @ 2013-04-18 19:31 UTC (permalink / raw)
To: Matt Porter
Cc: spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f,
linux-kernel-u79uwXL29TY76Z2rM5mHXA
Commit 048177ce3b3962852fd34a7e04938959271c7e70 (spi: spi-davinci:
convert to DMA engine API) introduced a regression: dma_map_single()
is called with direction DMA_FROM_DEVICE for rx and for tx.
Signed-off-by: Christian Eggers <ceggers-Mmb7MZpHnFY@public.gmane.org>
Cc: stable-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
---
--- drivers/spi/spi-davinci.c.orig 2013-04-18 20:54:02.728719412 +0200
+++ drivers/spi/spi-davinci.c 2013-04-18 20:54:51.900623956 +0200
@@ -608,7 +608,7 @@ static int davinci_spi_bufs(struct spi_d
else
buf = (void *)t->tx_buf;
t->tx_dma = dma_map_single(&spi->dev, buf,
- t->len, DMA_FROM_DEVICE);
+ t->len, DMA_TO_DEVICE);
if (!t->tx_dma) {
ret = -EFAULT;
goto err_tx_map;
------------------------------------------------------------------------------
Precog is a next-generation analytics platform capable of advanced
analytics on semi-structured data. The platform includes APIs for building
apps and a phenomenal toolset for data science. Developers can use
our toolset for easy data analysis & visualization. Get a free account!
http://www2.precog.com/precogplatform/slashdotnewsletter
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: spi: spi-davinci: Fix direction in dma_map_single()
2013-04-18 19:31 spi: spi-davinci: Fix direction in dma_map_single() Christian Eggers
@ 2013-04-18 19:53 ` Matt Porter
0 siblings, 0 replies; 4+ messages in thread
From: Matt Porter @ 2013-04-18 19:53 UTC (permalink / raw)
To: Christian Eggers; +Cc: linux-kernel, spi-devel-general
On 04/18/2013 03:31 PM, Christian Eggers wrote:
> Commit 048177ce3b3962852fd34a7e04938959271c7e70 (spi: spi-davinci:
>
> convert to DMA engine API) introduced a regression: dma_map_single()
>
> is called with direction DMA_FROM_DEVICE for rx and for tx.
>
> Signed-off-by: Christian Eggers <ceggers@gmx.de>
>
> Cc: stable@vger.kernel.org
Cc: stable@vger.kernel.org # v3.7.x+
will get this applied to the correct stable kernels.
I'm wearing the brown bag for this one so other than fixing the Cc: it
looks good.
Acked-by: Matt Porter <mporter@ti.com>
> --- drivers/spi/spi-davinci.c.orig 2013-04-18 20:54:02.728719412 +0200
>
> +++ drivers/spi/spi-davinci.c 2013-04-18 20:54:51.900623956 +0200
>
> @@ -608,7 +608,7 @@ static int davinci_spi_bufs(struct spi_d
>
> else
>
> buf = (void *)t->tx_buf;
>
> t->tx_dma = dma_map_single(&spi->dev, buf,
>
> - t->len, DMA_FROM_DEVICE);
>
> + t->len, DMA_TO_DEVICE);
>
> if (!t->tx_dma) {
>
> ret = -EFAULT;
>
> goto err_tx_map;
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* spi: spi-davinci: Fix direction in dma_map_single()
@ 2013-04-18 19:44 ` Christian Eggers
0 siblings, 0 replies; 4+ messages in thread
From: Christian Eggers @ 2013-04-18 19:44 UTC (permalink / raw)
To: Matt Porter
Cc: spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f,
linux-kernel-u79uwXL29TY76Z2rM5mHXA
Commit 048177ce3b3962852fd34a7e04938959271c7e70 (spi: spi-davinci:
convert to DMA engine API) introduced a regression: dma_map_single()
is called with direction DMA_FROM_DEVICE for rx and for tx.
Signed-off-by: Christian Eggers <ceggers-Mmb7MZpHnFY@public.gmane.org>
Cc: stable-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
---
--- drivers/spi/spi-davinci.c.orig 2013-04-18 20:54:02.728719412 +0200
+++ drivers/spi/spi-davinci.c 2013-04-18 20:54:51.900623956 +0200
@@ -608,7 +608,7 @@ static int davinci_spi_bufs(struct spi_d
else
buf = (void *)t->tx_buf;
t->tx_dma = dma_map_single(&spi->dev, buf,
- t->len, DMA_FROM_DEVICE);
+ t->len, DMA_TO_DEVICE);
if (!t->tx_dma) {
ret = -EFAULT;
goto err_tx_map;
------------------------------------------------------------------------------
Precog is a next-generation analytics platform capable of advanced
analytics on semi-structured data. The platform includes APIs for building
apps and a phenomenal toolset for data science. Developers can use
our toolset for easy data analysis & visualization. Get a free account!
http://www2.precog.com/precogplatform/slashdotnewsletter
^ permalink raw reply [flat|nested] 4+ messages in thread* spi: spi-davinci: Fix direction in dma_map_single()
@ 2013-04-18 19:44 ` Christian Eggers
0 siblings, 0 replies; 4+ messages in thread
From: Christian Eggers @ 2013-04-18 19:44 UTC (permalink / raw)
To: Matt Porter; +Cc: linux-kernel, spi-devel-general
Commit 048177ce3b3962852fd34a7e04938959271c7e70 (spi: spi-davinci:
convert to DMA engine API) introduced a regression: dma_map_single()
is called with direction DMA_FROM_DEVICE for rx and for tx.
Signed-off-by: Christian Eggers <ceggers@gmx.de>
Cc: stable@vger.kernel.org
---
--- drivers/spi/spi-davinci.c.orig 2013-04-18 20:54:02.728719412 +0200
+++ drivers/spi/spi-davinci.c 2013-04-18 20:54:51.900623956 +0200
@@ -608,7 +608,7 @@ static int davinci_spi_bufs(struct spi_d
else
buf = (void *)t->tx_buf;
t->tx_dma = dma_map_single(&spi->dev, buf,
- t->len, DMA_FROM_DEVICE);
+ t->len, DMA_TO_DEVICE);
if (!t->tx_dma) {
ret = -EFAULT;
goto err_tx_map;
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2013-04-18 19:53 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-04-18 19:31 spi: spi-davinci: Fix direction in dma_map_single() Christian Eggers
2013-04-18 19:53 ` Matt Porter
-- strict thread matches above, loose matches on Subject: below --
2013-04-18 19:44 Christian Eggers
2013-04-18 19:44 ` Christian Eggers
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.