From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v3 4/4] ARM: shmobile: BOCK-W: enable USB in defconfig
Date: Thu, 18 Apr 2013 22:50:05 +0000 [thread overview]
Message-ID: <5170789D.5020108@cogentembedded.com> (raw)
In-Reply-To: <20130418140552.GO20929@verge.net.au>
Hello.
On 04/18/2013 06:05 PM, Simon Horman wrote:
>
>> Enable USB platform EHCI/OHCI and common PHY drivers in 'bockw_defconfig'.
>> Enable USB storage driver and SCSI disk driver that it needs as well...
>>
>> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
> I realise that this is not going to be useful until the rest
> of the series has been merged. But regardless I have pre-emptively
> queued it up for v3.11 in the defconfig-bockw branch.
>> ---
>> arch/arm/configs/bockw_defconfig | 11 ++++++++++-
>> 1 file changed, 10 insertions(+), 1 deletion(-)
>>
>> Index: renesas/arch/arm/configs/bockw_defconfig
>> =================================>> --- renesas.orig/arch/arm/configs/bockw_defconfig
>> +++ renesas/arch/arm/configs/bockw_defconfig
>> @@ -48,6 +48,8 @@ CONFIG_DEVTMPFS_MOUNT=y
>> # CONFIG_STANDALONE is not set
>> # CONFIG_PREVENT_FIRMWARE_BUILD is not set
>> # CONFIG_FW_LOADER is not set
>> +CONFIG_SCSI=y
>> +CONFIG_BLK_DEV_SD=y
>> CONFIG_NETDEVICES=y
>> # CONFIG_NET_CADENCE is not set
>> # CONFIG_NET_VENDOR_BROADCOM is not set
>> @@ -71,7 +73,14 @@ CONFIG_SERIAL_SH_SCI_NR_UARTS=6
>> CONFIG_SERIAL_SH_SCI_CONSOLE=y
>> # CONFIG_HW_RANDOM is not set
>> # CONFIG_HWMON is not set
>> -# CONFIG_USB_SUPPORT is not set
>> +CONFIG_USB=y
>> +CONFIG_USB_ANNOUNCE_NEW_DEVICES=y
>> +CONFIG_USB_EHCI_HCD=y
>> +CONFIG_USB_OHCI_HCD=y
>> +CONFIG_USB_OHCI_HCD_PLATFORM=y
>> +CONFIG_USB_EHCI_HCD_PLATFORM=y
>> +CONFIG_USB_STORAGE=y
>> +CONFIG_USB_RCAR_PHY=y
>>
Unfortunately, you've made a mistake in this last line of the patch:
you've truncated it to just "CONFIG_USB_RCAR". :-(
Will you correct it?
WBR, Sergei
WARNING: multiple messages have this Message-ID (diff)
From: sergei.shtylyov@cogentembedded.com (Sergei Shtylyov)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 4/4] ARM: shmobile: BOCK-W: enable USB in defconfig
Date: Fri, 19 Apr 2013 02:50:05 +0400 [thread overview]
Message-ID: <5170789D.5020108@cogentembedded.com> (raw)
In-Reply-To: <20130418140552.GO20929@verge.net.au>
Hello.
On 04/18/2013 06:05 PM, Simon Horman wrote:
>
>> Enable USB platform EHCI/OHCI and common PHY drivers in 'bockw_defconfig'.
>> Enable USB storage driver and SCSI disk driver that it needs as well...
>>
>> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
> I realise that this is not going to be useful until the rest
> of the series has been merged. But regardless I have pre-emptively
> queued it up for v3.11 in the defconfig-bockw branch.
>> ---
>> arch/arm/configs/bockw_defconfig | 11 ++++++++++-
>> 1 file changed, 10 insertions(+), 1 deletion(-)
>>
>> Index: renesas/arch/arm/configs/bockw_defconfig
>> ===================================================================
>> --- renesas.orig/arch/arm/configs/bockw_defconfig
>> +++ renesas/arch/arm/configs/bockw_defconfig
>> @@ -48,6 +48,8 @@ CONFIG_DEVTMPFS_MOUNT=y
>> # CONFIG_STANDALONE is not set
>> # CONFIG_PREVENT_FIRMWARE_BUILD is not set
>> # CONFIG_FW_LOADER is not set
>> +CONFIG_SCSI=y
>> +CONFIG_BLK_DEV_SD=y
>> CONFIG_NETDEVICES=y
>> # CONFIG_NET_CADENCE is not set
>> # CONFIG_NET_VENDOR_BROADCOM is not set
>> @@ -71,7 +73,14 @@ CONFIG_SERIAL_SH_SCI_NR_UARTS=6
>> CONFIG_SERIAL_SH_SCI_CONSOLE=y
>> # CONFIG_HW_RANDOM is not set
>> # CONFIG_HWMON is not set
>> -# CONFIG_USB_SUPPORT is not set
>> +CONFIG_USB=y
>> +CONFIG_USB_ANNOUNCE_NEW_DEVICES=y
>> +CONFIG_USB_EHCI_HCD=y
>> +CONFIG_USB_OHCI_HCD=y
>> +CONFIG_USB_OHCI_HCD_PLATFORM=y
>> +CONFIG_USB_EHCI_HCD_PLATFORM=y
>> +CONFIG_USB_STORAGE=y
>> +CONFIG_USB_RCAR_PHY=y
>>
Unfortunately, you've made a mistake in this last line of the patch:
you've truncated it to just "CONFIG_USB_RCAR". :-(
Will you correct it?
WBR, Sergei
next prev parent reply other threads:[~2013-04-18 22:50 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-16 21:35 [PATCH v3 4/4] ARM: shmobile: BOCK-W: enable USB in defconfig Sergei Shtylyov
2013-04-16 21:35 ` Sergei Shtylyov
2013-04-18 14:05 ` Simon Horman
2013-04-18 14:05 ` Simon Horman
2013-04-18 22:50 ` Sergei Shtylyov [this message]
2013-04-18 22:50 ` Sergei Shtylyov
2013-04-19 2:14 ` Simon Horman
2013-04-19 2:14 ` Simon Horman
2013-04-19 20:23 ` Sergei Shtylyov
2013-04-19 20:23 ` Sergei Shtylyov
2013-04-22 4:00 ` Simon Horman
2013-04-22 4:00 ` Simon Horman
2013-04-23 18:00 ` Sergei Shtylyov
2013-04-23 18:00 ` Sergei Shtylyov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5170789D.5020108@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.