All of lore.kernel.org
 help / color / mirror / Atom feed
From: sboyd@codeaurora.org (Stephen Boyd)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/2] clocksource: arm_arch_timer: unify sched_clock init
Date: Thu, 18 Apr 2013 17:00:24 -0700	[thread overview]
Message-ID: <51708918.1070501@codeaurora.org> (raw)
In-Reply-To: <1366313410-16692-1-git-send-email-robherring2@gmail.com>

On 04/18/13 12:30, Rob Herring wrote:
> diff --git a/drivers/clocksource/arm_arch_timer.c b/drivers/clocksource/arm_arch_timer.c
> index 122ff05..17ed8e4 100644
> --- a/drivers/clocksource/arm_arch_timer.c
> +++ b/drivers/clocksource/arm_arch_timer.c
> @@ -266,6 +266,15 @@ static struct notifier_block arch_timer_cpu_nb __cpuinitdata = {
>  	.notifier_call = arch_timer_cpu_notify,
>  };
>  
> +static u64 sched_clock_mult __read_mostly;
> +
> +unsigned long long notrace arch_timer_sched_clock(void)
> +{
> +	return arch_timer_read_counter() * sched_clock_mult;
> +}
> +unsigned long long sched_clock(void) \
> +	__attribute__((weak, alias("arch_timer_sched_clock")));

I'm still lost, how does this prevent the timer in ARM's 32 bit
sched_clock code from getting setup in sched_clock_postinit()? That
print is still there right? Who owns sched_clock() in multi-target builds?

Why can't we play along with the sched_clock code that lives in arm?
Maybe we should resurrect those clocksource sched_clock patches again.
Or maybe we should add support for setup_sched_clock_64() in arm's sched
clock code.

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
hosted by The Linux Foundation

WARNING: multiple messages have this Message-ID (diff)
From: Stephen Boyd <sboyd@codeaurora.org>
To: Rob Herring <robherring2@gmail.com>
Cc: linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, arm@kernel.org,
	Rob Herring <rob.herring@calxeda.com>,
	Russell King <linux@arm.linux.org.uk>,
	Catalin Marinas <catalin.marinas@arm.com>,
	Will Deacon <will.deacon@arm.com>,
	John Stultz <john.stultz@linaro.org>,
	Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [PATCH 1/2] clocksource: arm_arch_timer: unify sched_clock init
Date: Thu, 18 Apr 2013 17:00:24 -0700	[thread overview]
Message-ID: <51708918.1070501@codeaurora.org> (raw)
In-Reply-To: <1366313410-16692-1-git-send-email-robherring2@gmail.com>

On 04/18/13 12:30, Rob Herring wrote:
> diff --git a/drivers/clocksource/arm_arch_timer.c b/drivers/clocksource/arm_arch_timer.c
> index 122ff05..17ed8e4 100644
> --- a/drivers/clocksource/arm_arch_timer.c
> +++ b/drivers/clocksource/arm_arch_timer.c
> @@ -266,6 +266,15 @@ static struct notifier_block arch_timer_cpu_nb __cpuinitdata = {
>  	.notifier_call = arch_timer_cpu_notify,
>  };
>  
> +static u64 sched_clock_mult __read_mostly;
> +
> +unsigned long long notrace arch_timer_sched_clock(void)
> +{
> +	return arch_timer_read_counter() * sched_clock_mult;
> +}
> +unsigned long long sched_clock(void) \
> +	__attribute__((weak, alias("arch_timer_sched_clock")));

I'm still lost, how does this prevent the timer in ARM's 32 bit
sched_clock code from getting setup in sched_clock_postinit()? That
print is still there right? Who owns sched_clock() in multi-target builds?

Why can't we play along with the sched_clock code that lives in arm?
Maybe we should resurrect those clocksource sched_clock patches again.
Or maybe we should add support for setup_sched_clock_64() in arm's sched
clock code.

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
hosted by The Linux Foundation


  parent reply	other threads:[~2013-04-19  0:00 UTC|newest]

Thread overview: 59+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-04-18 19:30 [PATCH 1/2] clocksource: arm_arch_timer: unify sched_clock init Rob Herring
2013-04-18 19:30 ` Rob Herring
2013-04-18 19:30 ` [PATCH 2/2] clocksource: arm_arch_timer: add boot and suspend sched_clock offset Rob Herring
2013-04-18 19:30   ` Rob Herring
2013-04-19 14:46   ` Catalin Marinas
2013-04-19 14:46     ` Catalin Marinas
2013-04-19  0:00 ` Stephen Boyd [this message]
2013-04-19  0:00   ` [PATCH 1/2] clocksource: arm_arch_timer: unify sched_clock init Stephen Boyd
2013-04-19  1:37   ` Rob Herring
2013-04-19  1:37     ` Rob Herring
2013-04-19 17:34     ` Stephen Boyd
2013-04-19 17:34       ` Stephen Boyd
2013-04-20  0:29     ` [PATCH 0/4] ARM 64 bit sched_clock take #2 Stephen Boyd
2013-04-20  0:29       ` Stephen Boyd
2013-04-20  0:29       ` [PATCH 1/4] ARM: sched_clock: Remove unused needs_suspend member Stephen Boyd
2013-04-20  0:29         ` Stephen Boyd
2013-04-20  0:29       ` [PATCH 2/4] ARM: sched_clock: Return suspended count earlier Stephen Boyd
2013-04-20  0:29         ` Stephen Boyd
2013-04-20  0:29       ` [PATCH 3/4] ARM: sched_clock: Add support for >32 bit sched_clock Stephen Boyd
2013-04-20  0:29         ` Stephen Boyd
2013-04-20  0:29         ` Stephen Boyd
2013-04-22 10:48         ` Will Deacon
2013-04-22 10:48           ` Will Deacon
2013-04-22 15:35           ` Stephen Boyd
2013-04-22 15:35             ` Stephen Boyd
2013-04-20  0:29       ` [PATCH 4/4] ARM: arch_timer: Move to setup_sched_clock_64() Stephen Boyd
2013-04-20  0:29         ` Stephen Boyd
2013-04-22 15:16       ` [PATCH 0/4] ARM 64 bit sched_clock take #2 Arnd Bergmann
2013-04-22 15:16         ` Arnd Bergmann
2013-04-22 15:34       ` Mark Rutland
2013-04-22 15:34         ` Mark Rutland
2013-04-22 15:36         ` Stephen Boyd
2013-04-22 15:36           ` Stephen Boyd
2013-04-22 15:51           ` Mark Rutland
2013-04-22 15:51             ` Mark Rutland
2013-04-22 15:51             ` Mark Rutland
2013-04-22 17:00       ` John Stultz
2013-04-22 17:00         ` John Stultz
2013-04-22 20:46         ` Rob Herring
2013-04-22 20:46           ` Rob Herring
2013-04-22 20:46           ` Rob Herring
2013-04-23 16:34           ` Stephen Boyd
2013-04-23 16:34             ` Stephen Boyd
2013-05-01  0:54       ` [PATCH 5/4] sched: Make ARM's sched_clock generic for all architectures Stephen Boyd
2013-05-01  0:54         ` Stephen Boyd
2013-05-01  0:54         ` [PATCH 6/4] arm64: Move to generic sched_clock infrastructure Stephen Boyd
2013-05-01  0:54           ` Stephen Boyd
2013-05-01  9:11           ` Catalin Marinas
2013-05-01  9:11             ` Catalin Marinas
2013-05-01 14:44             ` Christopher Covington
2013-05-01 14:44               ` Christopher Covington
2013-05-31 20:40         ` [PATCH 5/4] sched: Make ARM's sched_clock generic for all architectures John Stultz
2013-05-31 20:40           ` John Stultz
2013-05-31 22:13           ` Stephen Boyd
2013-05-31 22:13             ` Stephen Boyd
2013-05-31 23:50             ` John Stultz
2013-05-31 23:50               ` John Stultz
2013-04-19 14:45 ` [PATCH 1/2] clocksource: arm_arch_timer: unify sched_clock init Catalin Marinas
2013-04-19 14:45   ` Catalin Marinas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51708918.1070501@codeaurora.org \
    --to=sboyd@codeaurora.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.