All of lore.kernel.org
 help / color / mirror / Atom feed
From: Richard Henderson <rth@twiddle.net>
To: liguang <lig.fnst@cn.fujitsu.com>
Cc: peter.maydell@linaro.org, aliguori@us.ibm.com,
	qemu-devel@nongnu.org, blauwirbel@gmail.com, pbonzini@redhat.com,
	afaerber@suse.de
Subject: Re: [Qemu-devel] [PATCH 1/6] target-i386/seg_helper: replace env->eip with EIP
Date: Fri, 19 Apr 2013 09:48:35 +0200	[thread overview]
Message-ID: <5170F6D3.4020006@twiddle.net> (raw)
In-Reply-To: <1366339945-17151-2-git-send-email-lig.fnst@cn.fujitsu.com>

On 2013-04-19 04:52, liguang wrote:
> Signed-off-by: liguang <lig.fnst@cn.fujitsu.com>
> ---
>   target-i386/seg_helper.c |   46 +++++++++++++++++++++++-----------------------
>   1 files changed, 23 insertions(+), 23 deletions(-)
>
> diff --git a/target-i386/seg_helper.c b/target-i386/seg_helper.c
> index 906e4f3..5f7f99d 100644
> --- a/target-i386/seg_helper.c
> +++ b/target-i386/seg_helper.c
> @@ -388,7 +388,7 @@ static void switch_tss(CPUX86State *env, int tss_selector,
>
>       /* load all registers without an exception, then reload them with
>          possible exception */
> -    env->eip = new_eip;
> +    EIP = new_eip;

IMO this is not a cleanup, and we should in fact be doing the exact opposite,
getting rid of those silly macros.


r~

  reply	other threads:[~2013-04-19  7:48 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-04-19  2:52 [Qemu-devel] [PATCH 0/6] target-i386:do some cleanups liguang
2013-04-19  2:52 ` [Qemu-devel] [PATCH 1/6] target-i386/seg_helper: replace env->eip with EIP liguang
2013-04-19  7:48   ` Richard Henderson [this message]
2013-04-19  7:55     ` li guang
2013-04-19  8:08       ` Richard Henderson
2013-04-19  2:52 ` [Qemu-devel] [PATCH 2/6] target-i386/smm_helper: " liguang
2013-04-19  2:52 ` [Qemu-devel] [PATCH 3/6] target-i386/svm_helper: " liguang
2013-04-19  2:52 ` [Qemu-devel] [PATCH 4/6] target-i386/svm_helper: remove redundant assignment liguang
2013-04-19  2:52 ` [Qemu-devel] [PATCH 5/6] target-i386/seg_helper: refactor 4 helper functions liguang
2013-04-19  2:52 ` [Qemu-devel] [PATCH 6/6] target-i386/seg_helper: define names for code/data segment types liguang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5170F6D3.4020006@twiddle.net \
    --to=rth@twiddle.net \
    --cc=afaerber@suse.de \
    --cc=aliguori@us.ibm.com \
    --cc=blauwirbel@gmail.com \
    --cc=lig.fnst@cn.fujitsu.com \
    --cc=pbonzini@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.