From: gang.chen@asianux.com (Chen Gang)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM64: kernel: compiling issue, duplicate definition of early_console
Date: Fri, 19 Apr 2013 18:53:07 +0800 [thread overview]
Message-ID: <51712213.4060607@asianux.com> (raw)
In-Reply-To: <516E66F9.9070904@asianux.com>
when compiling with allmodconfig.
early_console is already defined as an extern global pointer.
need let it point to the object which we intend to (like ARM32 done).
Signed-off-by: Chen Gang <gang.chen@asianux.com>
---
arch/arm64/kernel/early_printk.c | 5 +++--
1 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/arch/arm64/kernel/early_printk.c
b/arch/arm64/kernel/early_printk.c
index ac974f4..fbb6e18 100644
--- a/arch/arm64/kernel/early_printk.c
+++ b/arch/arm64/kernel/early_printk.c
@@ -95,7 +95,7 @@ static void early_write(struct console *con, const
char *s, unsigned n)
}
}
-static struct console early_console = {
+static struct console early_console_dev = {
.name = "earlycon",
.write = early_write,
.flags = CON_PRINTBUFFER | CON_BOOT,
@@ -145,7 +145,8 @@ static int __init setup_early_printk(char *buf)
early_base = early_io_map(paddr, EARLYCON_IOBASE);
printch = match->printch;
- register_console(&early_console);
+ early_console = &early_console_dev;
+ register_console(&early_console_dev);
return 0;
}
--
1.7.7.6
WARNING: multiple messages have this Message-ID (diff)
From: Chen Gang <gang.chen@asianux.com>
To: Christopher Covington <cov@codeaurora.org>,
Catalin Marinas <catalin.marinas@arm.com>
Cc: "anup.patel@linaro.org" <anup.patel@linaro.org>,
Arnd Bergmann <arnd@arndb.de>,
Marc Zyngier <Marc.Zyngier@arm.com>,
Will Deacon <Will.Deacon@arm.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: [PATCH] ARM64: kernel: compiling issue, duplicate definition of early_console
Date: Fri, 19 Apr 2013 18:53:07 +0800 [thread overview]
Message-ID: <51712213.4060607@asianux.com> (raw)
In-Reply-To: <516E66F9.9070904@asianux.com>
when compiling with allmodconfig.
early_console is already defined as an extern global pointer.
need let it point to the object which we intend to (like ARM32 done).
Signed-off-by: Chen Gang <gang.chen@asianux.com>
---
arch/arm64/kernel/early_printk.c | 5 +++--
1 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/arch/arm64/kernel/early_printk.c
b/arch/arm64/kernel/early_printk.c
index ac974f4..fbb6e18 100644
--- a/arch/arm64/kernel/early_printk.c
+++ b/arch/arm64/kernel/early_printk.c
@@ -95,7 +95,7 @@ static void early_write(struct console *con, const
char *s, unsigned n)
}
}
-static struct console early_console = {
+static struct console early_console_dev = {
.name = "earlycon",
.write = early_write,
.flags = CON_PRINTBUFFER | CON_BOOT,
@@ -145,7 +145,8 @@ static int __init setup_early_printk(char *buf)
early_base = early_io_map(paddr, EARLYCON_IOBASE);
printch = match->printch;
- register_console(&early_console);
+ early_console = &early_console_dev;
+ register_console(&early_console_dev);
return 0;
}
--
1.7.7.6
next prev parent reply other threads:[~2013-04-19 10:53 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-27 11:44 [Suggestion] ARM64:kernel: compiling issue for early_console Chen Gang
2013-03-27 11:44 ` Chen Gang
2013-03-27 11:55 ` Catalin Marinas
2013-03-27 11:55 ` Catalin Marinas
2013-03-27 12:02 ` Chen Gang
2013-03-27 12:02 ` Chen Gang
2013-04-03 8:13 ` Chen Gang
2013-04-03 8:13 ` Chen Gang
2013-04-03 11:39 ` Christopher Covington
2013-04-03 11:39 ` Christopher Covington
2013-04-03 13:00 ` Chen Gang
2013-04-03 13:00 ` Chen Gang
2013-04-17 9:10 ` Chen Gang
2013-04-17 9:10 ` Chen Gang
2013-04-19 10:53 ` Chen Gang [this message]
2013-04-19 10:53 ` [PATCH] ARM64: kernel: compiling issue, duplicate definition of early_console Chen Gang
2013-04-19 12:15 ` Arnd Bergmann
2013-04-19 12:15 ` Arnd Bergmann
2013-04-20 1:55 ` Chen Gang
2013-04-20 1:55 ` Chen Gang
2013-04-19 12:31 ` Catalin Marinas
2013-04-19 12:31 ` Catalin Marinas
2013-04-20 1:54 ` Chen Gang
2013-04-20 1:54 ` Chen Gang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51712213.4060607@asianux.com \
--to=gang.chen@asianux.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.