[meta-raspberrypi][PATCH] Fix FILESEXTRAPATHS, dir is "netbase-5.0"

[meta-raspberrypi][PATCH] Fix FILESEXTRAPATHS, dir is "netbase-5.0"

[Robert P. J. Day]

The actual files subdirectory name is "netbase-5.0", not "netbase".

Signed-off-by: Robert P. J. Day <rpjday@crashcourse.ca>

---

  same fix was once applied to exactly the same recipe bbappend file
under meta-ti layer.

diff --git a/recipes-core/netbase/netbase_5.0.bbappend b/recipes-core/netbase/netbase_5.0.bbappend
index 36432f5..a3fbd33 100644
--- a/recipes-core/netbase/netbase_5.0.bbappend
+++ b/recipes-core/netbase/netbase_5.0.bbappend
@@ -1,3 +1,3 @@
-FILESEXTRAPATHS_prepend := "${THISDIR}/${PN}:"
+FILESEXTRAPATHS_prepend := "${THISDIR}/${PN}-${PV}:"
 # Don't forget to bump PRINC if you update the extra files.
 PRINC = "1"

-- 

========================================================================
Robert P. J. Day                                 Ottawa, Ontario, CANADA
                        http://crashcourse.ca

Twitter:                                       http://twitter.com/rpjday
LinkedIn:                               http://ca.linkedin.com/in/rpjday
========================================================================

Re: [meta-raspberrypi][PATCH] Fix FILESEXTRAPATHS, dir is "netbase-5.0"

[Martin Jansa]

[-- Attachment #1: Type: text/plain, Size: 884 bytes --]

On Fri, Apr 19, 2013 at 09:35:18AM -0400, Robert P. J. Day wrote:
> 
> The actual files subdirectory name is "netbase-5.0", not "netbase".
> 
> Signed-off-by: Robert P. J. Day <rpjday@crashcourse.ca>
> 
> ---
> 
>   same fix was once applied to exactly the same recipe bbappend file
> under meta-ti layer.
> 
> diff --git a/recipes-core/netbase/netbase_5.0.bbappend b/recipes-core/netbase/netbase_5.0.bbappend
> index 36432f5..a3fbd33 100644
> --- a/recipes-core/netbase/netbase_5.0.bbappend
> +++ b/recipes-core/netbase/netbase_5.0.bbappend
> @@ -1,3 +1,3 @@
> -FILESEXTRAPATHS_prepend := "${THISDIR}/${PN}:"
> +FILESEXTRAPATHS_prepend := "${THISDIR}/${PN}-${PV}:"
>  # Don't forget to bump PRINC if you update the extra files.
>  PRINC = "1"

that's P or use BP, and fix PRINC when you're there..

-- 
Martin 'JaMa' Jansa     jabber: Martin.Jansa@gmail.com

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 205 bytes --]

Re: [meta-raspberrypi][PATCH] Fix FILESEXTRAPATHS, dir is "netbase-5.0"

[Robert P. J. Day]

On Fri, 19 Apr 2013, Martin Jansa wrote:

> On Fri, Apr 19, 2013 at 09:35:18AM -0400, Robert P. J. Day wrote:
> >
> > The actual files subdirectory name is "netbase-5.0", not "netbase".
> >
> > Signed-off-by: Robert P. J. Day <rpjday@crashcourse.ca>
> >
> > ---
> >
> >   same fix was once applied to exactly the same recipe bbappend file
> > under meta-ti layer.
> >
> > diff --git a/recipes-core/netbase/netbase_5.0.bbappend b/recipes-core/netbase/netbase_5.0.bbappend
> > index 36432f5..a3fbd33 100644
> > --- a/recipes-core/netbase/netbase_5.0.bbappend
> > +++ b/recipes-core/netbase/netbase_5.0.bbappend
> > @@ -1,3 +1,3 @@
> > -FILESEXTRAPATHS_prepend := "${THISDIR}/${PN}:"
> > +FILESEXTRAPATHS_prepend := "${THISDIR}/${PN}-${PV}:"
> >  # Don't forget to bump PRINC if you update the extra files.
> >  PRINC = "1"
>
> that's P or use BP, and fix PRINC when you're there..

  ok, but i was just working off of *exactly* the same patch format
that went into meta-ti.

rday

-- 

========================================================================
Robert P. J. Day                                 Ottawa, Ontario, CANADA
                        http://crashcourse.ca

Twitter:                                       http://twitter.com/rpjday
LinkedIn:                               http://ca.linkedin.com/in/rpjday
========================================================================

Re: [meta-raspberrypi][PATCH] Fix FILESEXTRAPATHS, dir is "netbase-5.0"

[Robert P. J. Day]

On Fri, 19 Apr 2013, Martin Jansa wrote:

> On Fri, Apr 19, 2013 at 09:35:18AM -0400, Robert P. J. Day wrote:
> >
> > The actual files subdirectory name is "netbase-5.0", not "netbase".
> >
> > Signed-off-by: Robert P. J. Day <rpjday@crashcourse.ca>
> >
> > ---
> >
> >   same fix was once applied to exactly the same recipe bbappend file
> > under meta-ti layer.
> >
> > diff --git a/recipes-core/netbase/netbase_5.0.bbappend b/recipes-core/netbase/netbase_5.0.bbappend
> > index 36432f5..a3fbd33 100644
> > --- a/recipes-core/netbase/netbase_5.0.bbappend
> > +++ b/recipes-core/netbase/netbase_5.0.bbappend
> > @@ -1,3 +1,3 @@
> > -FILESEXTRAPATHS_prepend := "${THISDIR}/${PN}:"
> > +FILESEXTRAPATHS_prepend := "${THISDIR}/${PN}-${PV}:"
> >  # Don't forget to bump PRINC if you update the extra files.
> >  PRINC = "1"
>
> that's P or use BP, and fix PRINC when you're there..

  ok, pedantic question -- the comment suggests you're supposed to
increment PRINC "if you update the extra files". but i didn't, i just
made sure they're now being included. i guess that still counts, yes?

rday

-- 

========================================================================
Robert P. J. Day                                 Ottawa, Ontario, CANADA
                        http://crashcourse.ca

Twitter:                                       http://twitter.com/rpjday
LinkedIn:                               http://ca.linkedin.com/in/rpjday
========================================================================

Re: [meta-raspberrypi][PATCH] Fix FILESEXTRAPATHS, dir is "netbase-5.0"

[Martin Jansa]

[-- Attachment #1: Type: text/plain, Size: 1354 bytes --]

On Fri, Apr 19, 2013 at 10:17:10AM -0400, Robert P. J. Day wrote:
> On Fri, 19 Apr 2013, Martin Jansa wrote:
> 
> > On Fri, Apr 19, 2013 at 09:35:18AM -0400, Robert P. J. Day wrote:
> > >
> > > The actual files subdirectory name is "netbase-5.0", not "netbase".
> > >
> > > Signed-off-by: Robert P. J. Day <rpjday@crashcourse.ca>
> > >
> > > ---
> > >
> > >   same fix was once applied to exactly the same recipe bbappend file
> > > under meta-ti layer.
> > >
> > > diff --git a/recipes-core/netbase/netbase_5.0.bbappend b/recipes-core/netbase/netbase_5.0.bbappend
> > > index 36432f5..a3fbd33 100644
> > > --- a/recipes-core/netbase/netbase_5.0.bbappend
> > > +++ b/recipes-core/netbase/netbase_5.0.bbappend
> > > @@ -1,3 +1,3 @@
> > > -FILESEXTRAPATHS_prepend := "${THISDIR}/${PN}:"
> > > +FILESEXTRAPATHS_prepend := "${THISDIR}/${PN}-${PV}:"
> > >  # Don't forget to bump PRINC if you update the extra files.
> > >  PRINC = "1"
> >
> > that's P or use BP, and fix PRINC when you're there..
> 
>   ok, pedantic question -- the comment suggests you're supposed to
> increment PRINC "if you update the extra files". but i didn't, i just
> made sure they're now being included. i guess that still counts, yes?

I was talking about PRINC := "${@int(PRINC) + 1}"

-- 
Martin 'JaMa' Jansa     jabber: Martin.Jansa@gmail.com

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 205 bytes --]

Re: [meta-raspberrypi][PATCH] Fix FILESEXTRAPATHS, dir is "netbase-5.0"

[Robert P. J. Day]

On Fri, 19 Apr 2013, Martin Jansa wrote:

> On Fri, Apr 19, 2013 at 10:17:10AM -0400, Robert P. J. Day wrote:
> > On Fri, 19 Apr 2013, Martin Jansa wrote:
> >
> > > On Fri, Apr 19, 2013 at 09:35:18AM -0400, Robert P. J. Day wrote:
> > > >
> > > > The actual files subdirectory name is "netbase-5.0", not "netbase".
> > > >
> > > > Signed-off-by: Robert P. J. Day <rpjday@crashcourse.ca>
> > > >
> > > > ---
> > > >
> > > >   same fix was once applied to exactly the same recipe bbappend file
> > > > under meta-ti layer.
> > > >
> > > > diff --git a/recipes-core/netbase/netbase_5.0.bbappend b/recipes-core/netbase/netbase_5.0.bbappend
> > > > index 36432f5..a3fbd33 100644
> > > > --- a/recipes-core/netbase/netbase_5.0.bbappend
> > > > +++ b/recipes-core/netbase/netbase_5.0.bbappend
> > > > @@ -1,3 +1,3 @@
> > > > -FILESEXTRAPATHS_prepend := "${THISDIR}/${PN}:"
> > > > +FILESEXTRAPATHS_prepend := "${THISDIR}/${PN}-${PV}:"
> > > >  # Don't forget to bump PRINC if you update the extra files.
> > > >  PRINC = "1"
> > >
> > > that's P or use BP, and fix PRINC when you're there..
> >
> >   ok, pedantic question -- the comment suggests you're supposed to
> > increment PRINC "if you update the extra files". but i didn't, i just
> > made sure they're now being included. i guess that still counts, yes?
>
> I was talking about PRINC := "${@int(PRINC) + 1}"

  i think i'll just leave this to the rpi folks. :-)

rday

-- 

========================================================================
Robert P. J. Day                                 Ottawa, Ontario, CANADA
                        http://crashcourse.ca

Twitter:                                       http://twitter.com/rpjday
LinkedIn:                               http://ca.linkedin.com/in/rpjday
========================================================================

Re: [meta-raspberrypi][PATCH] Fix FILESEXTRAPATHS, dir is "netbase-5.0"

[Paul Barker]

On 19 April 2013 15:39, Robert P. J. Day <rpjday@crashcourse.ca> wrote:
>
>   i think i'll just leave this to the rpi folks. :-)
>

I'm building for raspberrypi so I'll add this to my queue of things to look at.

--
Paul Barker

Email: paul@paulbarker.me.uk
http://www.paulbarker.me.uk

Re: [meta-raspberrypi][PATCH] Fix FILESEXTRAPATHS, dir is "netbase-5.0"

[Saul Wold]

On 04/19/2013 07:45 AM, Paul Barker wrote:
> On 19 April 2013 15:39, Robert P. J. Day <rpjday@crashcourse.ca> wrote:
>>
>>    i think i'll just leave this to the rpi folks. :-)
>>
>
> I'm building for raspberrypi so I'll add this to my queue of things to look at.
>
Just another note about the netbase, for 1.4 the interfaces file moved 
to init-ifupdown, so that file should move to a new recipe with 
bbappends for init-ifupdown-1.0.

We just fixed meta-yocto for the beagleboard  in the final 1.4 release.

Sau!

> --
> Paul Barker
>
> Email: paul@paulbarker.me.uk
> http://www.paulbarker.me.uk
> _______________________________________________
> yocto mailing list
> yocto@yoctoproject.org
> https://lists.yoctoproject.org/listinfo/yocto
>
>

Re: [meta-raspberrypi][PATCH] Fix FILESEXTRAPATHS, dir is "netbase-5.0"

[Paul Barker]

On 19 April 2013 17:23, Saul Wold <sgw@linux.intel.com> wrote:
> Just another note about the netbase, for 1.4 the interfaces file moved to
> init-ifupdown, so that file should move to a new recipe with bbappends for
> init-ifupdown-1.0.
>
> We just fixed meta-yocto for the beagleboard  in the final 1.4 release.
>

Ok, had a look at this now.

As originally pointed out by Robert, the hosts and interfaces files
are not picked up as the wrong directory is named in
netbase_5.0.bbappend. However, the image I've just built works fine
with the stock files in openembedded-core. Both eth0 and lo interfaces
come up fine. Other interfaces listed in the stock files don't have an
"auto" line so no attempt is made to bring them up at boot.

If we look at the interfaces file in meta-raspberrypi
(http://git.yoctoproject.org/cgit/cgit.cgi/meta-raspberrypi/tree/recipes-core/netbase/netbase-5.0/raspberrypi/interfaces),
it doesn't even list eth0 so I can't see how it would work.

The hosts file (http://git.yoctoproject.org/cgit/cgit.cgi/meta-raspberrypi/tree/recipes-core/netbase/netbase-5.0/raspberrypi/hosts)
just adds the names 'raspberrypi' and 'rpi' as aliases for localhost,
which I don't see the purpose of myself.

So I'd recommend dropping these from meta-raspberrypi completely. Just
my opinion though, anyone else got any thoughts on this?

--
Paul Barker

Email: paul@paulbarker.me.uk
http://www.paulbarker.me.uk

Re: [meta-raspberrypi][PATCH] Fix FILESEXTRAPATHS, dir is "netbase-5.0"

[Andrei Gherzan]

[-- Attachment #1: Type: text/plain, Size: 1771 bytes --]

On Sat, Apr 20, 2013 at 4:05 PM, Paul Barker <paul@paulbarker.me.uk> wrote:

> On 19 April 2013 17:23, Saul Wold <sgw@linux.intel.com> wrote:
> > Just another note about the netbase, for 1.4 the interfaces file moved to
> > init-ifupdown, so that file should move to a new recipe with bbappends
> for
> > init-ifupdown-1.0.
> >
> > We just fixed meta-yocto for the beagleboard  in the final 1.4 release.
> >
>
> Ok, had a look at this now.
>
> As originally pointed out by Robert, the hosts and interfaces files
> are not picked up as the wrong directory is named in
> netbase_5.0.bbappend. However, the image I've just built works fine
> with the stock files in openembedded-core. Both eth0 and lo interfaces
> come up fine. Other interfaces listed in the stock files don't have an
> "auto" line so no attempt is made to bring them up at boot.
>
> If we look at the interfaces file in meta-raspberrypi
> (
> http://git.yoctoproject.org/cgit/cgit.cgi/meta-raspberrypi/tree/recipes-core/netbase/netbase-5.0/raspberrypi/interfaces
> ),
> it doesn't even list eth0 so I can't see how it would work.
>
> The hosts file (
> http://git.yoctoproject.org/cgit/cgit.cgi/meta-raspberrypi/tree/recipes-core/netbase/netbase-5.0/raspberrypi/hosts
> )
> just adds the names 'raspberrypi' and 'rpi' as aliases for localhost,
> which I don't see the purpose of myself.
>
> So I'd recommend dropping these from meta-raspberrypi completely. Just
> my opinion though, anyone else got any thoughts on this?
>
>
Hello guys. Probably dropping would be the best thing here. I don't think
that the issue is reproduced anymore with netbase on rpi. If you submit
patch I can give it a try.

-- 
*Andrei Gherzan*
m: +40.744.478.414 |  f: +40.31.816.28.12

[-- Attachment #2: Type: text/html, Size: 3026 bytes --]

Re: [meta-raspberrypi][PATCH] Fix FILESEXTRAPATHS, dir is "netbase-5.0"

[Paul Barker]

On 20 April 2013 21:35, Andrei Gherzan <andrei@gherzan.ro> wrote:
> On Sat, Apr 20, 2013 at 4:05 PM, Paul Barker <paul@paulbarker.me.uk> wrote:
>>
>> So I'd recommend dropping these from meta-raspberrypi completely. Just
>> my opinion though, anyone else got any thoughts on this?
>>
>
> Hello guys. Probably dropping would be the best thing here. I don't think
> that the issue is reproduced anymore with netbase on rpi. If you submit
> patch I can give it a try.
>

I've thrown a patch together, will send it to the list. Not sure if
you want to elaborate on the commit message a little though before it
goes into the main repo, I'm not quite up to speed with the history of
some of these recipes.

(I must learn to check my reply/reply-all selection!)

Thanks,

--
Paul Barker

Email: paul@paulbarker.me.uk
http://www.paulbarker.me.uk