minor patch to cmds-restore.c

minor patch to cmds-restore.c

[Jon Nelson]

The following is a minor patch to cmds-restore.c


diff --git a/cmds-restore.c b/cmds-restore.c
index c75e187..273c813 100644
--- a/cmds-restore.c
+++ b/cmds-restore.c
@@ -917,14 +917,16 @@ out:
 }

 const char * const cmd_restore_usage[] = {
-       "btrfs restore [options] <device>",
+       "btrfs restore [options] <device> [destination]",
        "Try to restore files from a damaged filesystem (unmounted)",
        "",
+       "-l              list roots",
        "-s              get snapshots",
        "-v              verbose",
        "-i              ignore errors",
        "-o              overwrite",
-       "-t              tree location",
+       "-r <rootid>     root location",
+       "-t <treeid>     tree location",
        "-f <offset>     filesystem location",
        "-u <block>      super mirror",
        "-d              find dir",


--
Jon
Software Blacksmith

Re: minor patch to cmds-restore.c

[Eric Sandeen]

On 4/19/13 7:11 PM, Jon Nelson wrote:
> The following is a minor patch to cmds-restore.c
> 

Hi Jon - just a note -

When sending a patch like this, it's best to follow the standard
patch format, which closely mimics the kernel patch submission
guidelines:

Subject: [PATCH] btrfs-progs: <descriptive summary>

<longer description of change, if needed>

Signed-off-by: <you> <you@your.email.com>
---

<patch itself>

i.e. like:

Subject: [PATCH] btrfs-progs: fix btrfs restore command usage text

The built-in command help for btrfs restore was incorrect;
some options were missing and/or incorrect, and the destination
argument was not shown.

Signed-off-by: Jon Nelson <jnelson@jamponi.net>
---

That way it's clear to the reviewer as well as making the source
control history more descriptive.

Hum, it'd be nice to have it in the manpage too...

Thanks,
-Eric

> diff --git a/cmds-restore.c b/cmds-restore.c
> index c75e187..273c813 100644
> --- a/cmds-restore.c
> +++ b/cmds-restore.c
> @@ -917,14 +917,16 @@ out:
>  }
> 
>  const char * const cmd_restore_usage[] = {
> -       "btrfs restore [options] <device>",
> +       "btrfs restore [options] <device> [destination]",
>         "Try to restore files from a damaged filesystem (unmounted)",
>         "",
> +       "-l              list roots",
>         "-s              get snapshots",
>         "-v              verbose",
>         "-i              ignore errors",
>         "-o              overwrite",
> -       "-t              tree location",
> +       "-r <rootid>     root location",
> +       "-t <treeid>     tree location",
>         "-f <offset>     filesystem location",
>         "-u <block>      super mirror",
>         "-d              find dir",
> 
> 
> --
> Jon
> Software Blacksmith
> --
> To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 

Re: minor patch to cmds-restore.c

[Jon Nelson]

On Fri, Apr 19, 2013 at 11:48 PM, Eric Sandeen <sandeen@redhat.com> wrote:
> On 4/19/13 7:11 PM, Jon Nelson wrote:
>> The following is a minor patch to cmds-restore.c
>>
>
> Hi Jon - just a note -
>
> When sending a patch like this, it's best to follow the standard
> patch format, which closely mimics the kernel patch submission
> guidelines:

...
> That way it's clear to the reviewer as well as making the source
> control history more descriptive.
>
> Hum, it'd be nice to have it in the manpage too...

Thank you for the constructive and polite feedback! I will try to
adhere the next time I send a patch. If I can find some time later,
I'll update the manpage, too.

Before I do that, is the verbiage in the patch acceptable?

--
Jon
Software Blacksmith