All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: mchehab@redhat.com, linux-media@vger.kernel.org
Cc: linux-sh@vger.kernel.org, matsu@igel.co.jp,
	vladimir.barinov@cogentembedded.com
Subject: Re: [PATCH 1/5] V4L2: I2C: ML86V7667 video decoder driver
Date: Sat, 20 Apr 2013 21:59:42 +0000	[thread overview]
Message-ID: <51730FCE.8000604@cogentembedded.com> (raw)
In-Reply-To: <201304210016.33720.sergei.shtylyov@cogentembedded.com>

Hello.

On 04/21/2013 12:16 AM, Sergei Shtylyov wrote:

> From: Vladimir Barinov <vladimir.barinov@cogentembedded.com>
>
> Add OKI Semiconductor ML86V7667 video decoder driver.
>
> Signed-off-by: Vladimir Barinov <vladimir.barinov@cogentembedded.com>
> [Sergei: added v4l2_device_unregister_subdev() call to the error cleanup path of
> ml86v7667_probe(); some cleanup.]
> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>

[...]

> Index: renesas/drivers/media/i2c/ml86v7667.c
> =================================> --- /dev/null
> +++ renesas/drivers/media/i2c/ml86v7667.c
> @@ -0,0 +1,504 @@

[...]

> +/* ACC Loop filter & Chrominance control register bits */
> +#define ACCC_CHROMA_CR_SHIFT	3
> +#define ACCC_CHROMA_CR_MASK	(7 << 3)
> +#define ACCC_CHROMA_CB_SHIFT	0
> +#define ACCC_CHROMA_CB_MASK	(7 << 3)

     Should be (7 << 0), of course. My fault. :-(

WBR, Sergei



WARNING: multiple messages have this Message-ID (diff)
From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: mchehab@redhat.com, linux-media@vger.kernel.org
Cc: linux-sh@vger.kernel.org, matsu@igel.co.jp,
	vladimir.barinov@cogentembedded.com
Subject: Re: [PATCH 1/5] V4L2: I2C: ML86V7667 video decoder driver
Date: Sun, 21 Apr 2013 01:59:42 +0400	[thread overview]
Message-ID: <51730FCE.8000604@cogentembedded.com> (raw)
In-Reply-To: <201304210016.33720.sergei.shtylyov@cogentembedded.com>

Hello.

On 04/21/2013 12:16 AM, Sergei Shtylyov wrote:

> From: Vladimir Barinov <vladimir.barinov@cogentembedded.com>
>
> Add OKI Semiconductor ML86V7667 video decoder driver.
>
> Signed-off-by: Vladimir Barinov <vladimir.barinov@cogentembedded.com>
> [Sergei: added v4l2_device_unregister_subdev() call to the error cleanup path of
> ml86v7667_probe(); some cleanup.]
> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>

[...]

> Index: renesas/drivers/media/i2c/ml86v7667.c
> ===================================================================
> --- /dev/null
> +++ renesas/drivers/media/i2c/ml86v7667.c
> @@ -0,0 +1,504 @@

[...]

> +/* ACC Loop filter & Chrominance control register bits */
> +#define ACCC_CHROMA_CR_SHIFT	3
> +#define ACCC_CHROMA_CR_MASK	(7 << 3)
> +#define ACCC_CHROMA_CB_SHIFT	0
> +#define ACCC_CHROMA_CB_MASK	(7 << 3)

     Should be (7 << 0), of course. My fault. :-(

WBR, Sergei



  parent reply	other threads:[~2013-04-20 21:59 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-04-20 20:13 [PATCH 0/5] OKI ML86V7667 driver and R8A7778/BOCK-W VIN support Sergei Shtylyov
2013-04-20 20:13 ` Sergei Shtylyov
2013-04-20 20:13 ` Sergei Shtylyov
2013-04-20 20:16 ` [PATCH 1/5] V4L2: I2C: ML86V7667 video decoder driver Sergei Shtylyov
2013-04-20 20:16   ` Sergei Shtylyov
2013-04-20 21:05   ` Sylwester Nawrocki
2013-04-20 21:05     ` Sylwester Nawrocki
2013-04-21 10:23     ` Vladimir Barinov
2013-04-21 10:23       ` Vladimir Barinov
2013-04-20 21:50   ` Hans Verkuil
2013-04-20 21:50     ` Hans Verkuil
2013-04-20 21:59   ` Sergei Shtylyov [this message]
2013-04-20 21:59     ` Sergei Shtylyov
2013-04-20 20:28 ` [PATCH 3/5] ARM: shmobile: r8a7778: add VIN support Sergei Shtylyov
2013-04-20 20:28   ` Sergei Shtylyov
2013-04-20 20:28   ` Sergei Shtylyov
2013-04-20 20:36 ` [PATCH 4/5] ARM: shmobile: BOCK-W: add VIN and ML86V7667 support Sergei Shtylyov
2013-04-20 20:36   ` Sergei Shtylyov
2013-04-20 20:36   ` Sergei Shtylyov
2013-04-20 20:38 ` [PATCH 5/5] ARM: shmobile: BOCK-W: enable VIN and ML86V7667 in defconfig Sergei Shtylyov
2013-04-20 20:38   ` Sergei Shtylyov
2013-04-20 20:38   ` Sergei Shtylyov
2013-04-20 20:43 ` [PATCH 0/5] OKI ML86V7667 driver and R8A7778/BOCK-W VIN support Sergei Shtylyov
2013-04-20 20:43   ` Sergei Shtylyov
2013-04-20 20:43   ` Sergei Shtylyov
2013-04-22  4:21 ` Simon Horman
2013-04-22  4:21   ` Simon Horman
2013-04-22  4:21   ` Simon Horman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51730FCE.8000604@cogentembedded.com \
    --to=sergei.shtylyov@cogentembedded.com \
    --cc=linux-media@vger.kernel.org \
    --cc=linux-sh@vger.kernel.org \
    --cc=matsu@igel.co.jp \
    --cc=mchehab@redhat.com \
    --cc=vladimir.barinov@cogentembedded.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.