From: Maxime Ripard <maxime.ripard@free-electrons.com>
To: linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH RESEND] video: mxsfb: Fix colors display on lower color depth
Date: Mon, 22 Apr 2013 10:15:39 +0000 [thread overview]
Message-ID: <51750DCB.3060306@free-electrons.com> (raw)
In-Reply-To: <201304221108.17339.jbe@pengutronix.de>
Hi Juergen,
Le 22/04/2013 11:08, Juergen Beisert a écrit :
> Hi Maxime,
>
> Maxime Ripard wrote:
>> The current code always registers as a 32 bits display, and uses the
>> hardware to drop the MSB of each color to abjust to the interface width
>> used by the panel.
>>
>> This results on 18 bits (and probably 16 bits display as well) in colors
>> being displayed poorly, because the MSB are obviously the most important
>> bits for each color definition.
>
> But the "def_rgb666" bitfield description reports correctly to use bit 0..5
> for each colour component in this mode. Maybe your userland program has a bug
> and forgets to honor the bitfield description?
Hmmm, that might be the case actually, yes, I'll check into this and let
you know. Thanks!
--
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
WARNING: multiple messages have this Message-ID (diff)
From: maxime.ripard@free-electrons.com (Maxime Ripard)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH RESEND] video: mxsfb: Fix colors display on lower color depth
Date: Mon, 22 Apr 2013 12:15:39 +0200 [thread overview]
Message-ID: <51750DCB.3060306@free-electrons.com> (raw)
In-Reply-To: <201304221108.17339.jbe@pengutronix.de>
Hi Juergen,
Le 22/04/2013 11:08, Juergen Beisert a ?crit :
> Hi Maxime,
>
> Maxime Ripard wrote:
>> The current code always registers as a 32 bits display, and uses the
>> hardware to drop the MSB of each color to abjust to the interface width
>> used by the panel.
>>
>> This results on 18 bits (and probably 16 bits display as well) in colors
>> being displayed poorly, because the MSB are obviously the most important
>> bits for each color definition.
>
> But the "def_rgb666" bitfield description reports correctly to use bit 0..5
> for each colour component in this mode. Maybe your userland program has a bug
> and forgets to honor the bitfield description?
Hmmm, that might be the case actually, yes, I'll check into this and let
you know. Thanks!
--
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
WARNING: multiple messages have this Message-ID (diff)
From: Maxime Ripard <maxime.ripard@free-electrons.com>
To: Juergen Beisert <jbe@pengutronix.de>
Cc: linux-arm-kernel@lists.infradead.org,
Shawn Guo <shawn.guo@linaro.org>,
Fabio Estevam <fabio.estevam@freescale.com>,
Marek Vasut <marex@denx.de>,
linux-fbdev@vger.kernel.org, Brian Lilly <brian@crystalfontz.com>,
Florian Tobias Schandinat <FlorianSchandinat@gmx.de>,
Thomas Petazzoni <thomas@free-electrons.com>,
Sascha Hauer <s.hauer@pengutronix.de>,
linux-kernel@vger.kernel.org,
Alexandre Belloni <alexandre.belloni@free-electrons.com>
Subject: Re: [PATCH RESEND] video: mxsfb: Fix colors display on lower color depth
Date: Mon, 22 Apr 2013 12:15:39 +0200 [thread overview]
Message-ID: <51750DCB.3060306@free-electrons.com> (raw)
In-Reply-To: <201304221108.17339.jbe@pengutronix.de>
Hi Juergen,
Le 22/04/2013 11:08, Juergen Beisert a écrit :
> Hi Maxime,
>
> Maxime Ripard wrote:
>> The current code always registers as a 32 bits display, and uses the
>> hardware to drop the MSB of each color to abjust to the interface width
>> used by the panel.
>>
>> This results on 18 bits (and probably 16 bits display as well) in colors
>> being displayed poorly, because the MSB are obviously the most important
>> bits for each color definition.
>
> But the "def_rgb666" bitfield description reports correctly to use bit 0..5
> for each colour component in this mode. Maybe your userland program has a bug
> and forgets to honor the bitfield description?
Hmmm, that might be the case actually, yes, I'll check into this and let
you know. Thanks!
--
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2013-04-22 10:15 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-22 8:11 [PATCH RESEND] video: mxsfb: Fix colors display on lower color depth Maxime Ripard
2013-04-22 8:11 ` Maxime Ripard
2013-04-22 8:11 ` Maxime Ripard
2013-04-22 9:08 ` Juergen Beisert
2013-04-22 9:08 ` Juergen Beisert
2013-04-22 9:08 ` Juergen Beisert
2013-04-22 10:15 ` Maxime Ripard [this message]
2013-04-22 10:15 ` Maxime Ripard
2013-04-22 10:15 ` Maxime Ripard
2013-04-22 9:16 ` Marek Vasut
2013-04-22 9:16 ` Marek Vasut
2013-04-22 9:16 ` Marek Vasut
2013-04-22 10:19 ` Maxime Ripard
2013-04-22 10:19 ` Maxime Ripard
2013-04-22 10:19 ` Maxime Ripard
2013-04-22 14:30 ` Marek Vasut
2013-04-22 14:30 ` Marek Vasut
2013-04-22 14:30 ` Marek Vasut
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51750DCB.3060306@free-electrons.com \
--to=maxime.ripard@free-electrons.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.