From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 2/4] ARM: shmobile: r8a7779: add VIN support
Date: Mon, 22 Apr 2013 12:37:33 +0000 [thread overview]
Message-ID: <51752F0D.6080805@cogentembedded.com> (raw)
In-Reply-To: <20130422045758.GP15680@verge.net.au>
Hello.
On 22-04-2013 8:57, Simon Horman wrote:
>>> From: Vladimir Barinov <vladimir.barinov@cogentembedded.com>
>>> Add VIN clocks and platform devices for R8A7779 SoC; add function to register
>>> the VIN platform devices.
>>> Signed-off-by: Vladimir Barinov <vladimir.barinov@cogentembedded.com>
>>> [Sergei: added 'id' parameter check to r8a7779_add_vin_device(), renamed some
>>> variables.]
>>> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
>> [...]
>>> Index: renesas/arch/arm/mach-shmobile/setup-r8a7779.c
>>> =================================>>> --- renesas.orig/arch/arm/mach-shmobile/setup-r8a7779.c
>>> +++ renesas/arch/arm/mach-shmobile/setup-r8a7779.c
>>> @@ -559,6 +559,33 @@ static struct resource ether_resources[]
>>> },
>>> };
>>> +#define R8A7779_VIN(idx) \
>>> +static struct resource vin##idx##_resources[] = { \
>>> + DEFINE_RES_MEM(0xffc50000 + 0x1000 * (idx), 0x1000), \
>>> + DEFINE_RES_IRQ(gic_iid(0x5f + (idx))), \
>>> +}; \
>>> + \
>>> +static struct platform_device_info vin##idx##_info = { \
>> Hm, probably should have marked this as '__initdata'... maybe
>> the resources too.
> That doesn't seem to be the case for other devices in
> that or other shmobile files. Am I missing something
> or should numerous other devices be updated?
If the device is registered using platform_device_register_*(), it seems
worth marking the resources, the platfrom data and 'struct
platform_device_info' as '__initdata' as they're copied to the memory
allocated from heap anyway and hence not needed past the init phase...
WBR, Sergei
WARNING: multiple messages have this Message-ID (diff)
From: sergei.shtylyov@cogentembedded.com (Sergei Shtylyov)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 2/4] ARM: shmobile: r8a7779: add VIN support
Date: Mon, 22 Apr 2013 16:37:33 +0400 [thread overview]
Message-ID: <51752F0D.6080805@cogentembedded.com> (raw)
In-Reply-To: <20130422045758.GP15680@verge.net.au>
Hello.
On 22-04-2013 8:57, Simon Horman wrote:
>>> From: Vladimir Barinov <vladimir.barinov@cogentembedded.com>
>>> Add VIN clocks and platform devices for R8A7779 SoC; add function to register
>>> the VIN platform devices.
>>> Signed-off-by: Vladimir Barinov <vladimir.barinov@cogentembedded.com>
>>> [Sergei: added 'id' parameter check to r8a7779_add_vin_device(), renamed some
>>> variables.]
>>> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
>> [...]
>>> Index: renesas/arch/arm/mach-shmobile/setup-r8a7779.c
>>> ===================================================================
>>> --- renesas.orig/arch/arm/mach-shmobile/setup-r8a7779.c
>>> +++ renesas/arch/arm/mach-shmobile/setup-r8a7779.c
>>> @@ -559,6 +559,33 @@ static struct resource ether_resources[]
>>> },
>>> };
>>> +#define R8A7779_VIN(idx) \
>>> +static struct resource vin##idx##_resources[] = { \
>>> + DEFINE_RES_MEM(0xffc50000 + 0x1000 * (idx), 0x1000), \
>>> + DEFINE_RES_IRQ(gic_iid(0x5f + (idx))), \
>>> +}; \
>>> + \
>>> +static struct platform_device_info vin##idx##_info = { \
>> Hm, probably should have marked this as '__initdata'... maybe
>> the resources too.
> That doesn't seem to be the case for other devices in
> that or other shmobile files. Am I missing something
> or should numerous other devices be updated?
If the device is registered using platform_device_register_*(), it seems
worth marking the resources, the platfrom data and 'struct
platform_device_info' as '__initdata' as they're copied to the memory
allocated from heap anyway and hence not needed past the init phase...
WBR, Sergei
WARNING: multiple messages have this Message-ID (diff)
From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Simon Horman <horms@verge.net.au>
Cc: magnus.damm@gmail.com, linux@arm.linux.org.uk,
linux-sh@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-media@vger.kernel.org, matsu@igel.co.jp,
Vladimir Barinov <vladimir.barinov@cogentembedded.com>
Subject: Re: [PATCH v2 2/4] ARM: shmobile: r8a7779: add VIN support
Date: Mon, 22 Apr 2013 16:37:33 +0400 [thread overview]
Message-ID: <51752F0D.6080805@cogentembedded.com> (raw)
In-Reply-To: <20130422045758.GP15680@verge.net.au>
Hello.
On 22-04-2013 8:57, Simon Horman wrote:
>>> From: Vladimir Barinov <vladimir.barinov@cogentembedded.com>
>>> Add VIN clocks and platform devices for R8A7779 SoC; add function to register
>>> the VIN platform devices.
>>> Signed-off-by: Vladimir Barinov <vladimir.barinov@cogentembedded.com>
>>> [Sergei: added 'id' parameter check to r8a7779_add_vin_device(), renamed some
>>> variables.]
>>> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
>> [...]
>>> Index: renesas/arch/arm/mach-shmobile/setup-r8a7779.c
>>> ===================================================================
>>> --- renesas.orig/arch/arm/mach-shmobile/setup-r8a7779.c
>>> +++ renesas/arch/arm/mach-shmobile/setup-r8a7779.c
>>> @@ -559,6 +559,33 @@ static struct resource ether_resources[]
>>> },
>>> };
>>> +#define R8A7779_VIN(idx) \
>>> +static struct resource vin##idx##_resources[] = { \
>>> + DEFINE_RES_MEM(0xffc50000 + 0x1000 * (idx), 0x1000), \
>>> + DEFINE_RES_IRQ(gic_iid(0x5f + (idx))), \
>>> +}; \
>>> + \
>>> +static struct platform_device_info vin##idx##_info = { \
>> Hm, probably should have marked this as '__initdata'... maybe
>> the resources too.
> That doesn't seem to be the case for other devices in
> that or other shmobile files. Am I missing something
> or should numerous other devices be updated?
If the device is registered using platform_device_register_*(), it seems
worth marking the resources, the platfrom data and 'struct
platform_device_info' as '__initdata' as they're copied to the memory
allocated from heap anyway and hence not needed past the init phase...
WBR, Sergei
next prev parent reply other threads:[~2013-04-22 12:37 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-19 22:32 [PATCH v2 2/4] ARM: shmobile: r8a7779: add VIN support Sergei Shtylyov
2013-04-19 22:32 ` Sergei Shtylyov
2013-04-19 22:32 ` Sergei Shtylyov
2013-04-20 0:10 ` Sergei Shtylyov
2013-04-20 0:10 ` Sergei Shtylyov
2013-04-20 0:10 ` Sergei Shtylyov
2013-04-22 4:57 ` Simon Horman
2013-04-22 4:57 ` Simon Horman
2013-04-22 4:57 ` Simon Horman
2013-04-22 12:37 ` Sergei Shtylyov [this message]
2013-04-22 12:37 ` Sergei Shtylyov
2013-04-22 12:37 ` Sergei Shtylyov
2013-04-23 1:19 ` Simon Horman
2013-04-23 1:19 ` Simon Horman
2013-04-23 1:19 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51752F0D.6080805@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.