All of lore.kernel.org
 help / color / mirror / Atom feed
From: Gerd Hoffmann <kraxel@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: Amos Kong <akong@redhat.com>,
	qemu-devel@nongnu.org, Luiz Capitulino <lcapitulino@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] monitor: intervally send down events to guest in hold time
Date: Mon, 22 Apr 2013 15:35:07 +0200	[thread overview]
Message-ID: <51753C8B.5080504@redhat.com> (raw)
In-Reply-To: <51753505.9020107@redhat.com>

  Hi,

>> But isn't this patch the equivalent of repeatedly pressing and releasing a
>> key? Shouldn't this be implemented at a lower-level layer like the input
>> subsystem?

ps/2 keyboard emulation would probably the place to do it.

I'm pretty sure not all keyboard types have auto-repeat.  The linux
kernel input layer has code to generate the auto-repeat kbd events in
software, and that code is there for a reason I guess ...

> No, this patch is implementing what the microcontroller does, i.e. 10
> presses + 1 release.  I'm not sure it is the right level to do it (the
> rate/delay should be at least customizable from the board), but the
> logic is right and if someone else needs more configurability we can add
> it later.

IIRC the (ps/2) kbd controller can be programmed with rate+delay.

cheers,
  Gerd

  reply	other threads:[~2013-04-22 13:35 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-04-19  4:44 [Qemu-devel] [PATCH] monitor: intervally send down events to guest in hold time Amos Kong
2013-04-20 16:06 ` Eric Blake
2013-04-22  7:32   ` Amos Kong
2013-04-22  8:09     ` Amos Kong
2013-04-22  9:33       ` Paolo Bonzini
2013-04-22 12:43         ` Luiz Capitulino
2013-04-22 13:03           ` Paolo Bonzini
2013-04-22 13:35             ` Gerd Hoffmann [this message]
2013-04-22 14:32               ` Paolo Bonzini
2013-04-22 15:20                 ` Gerd Hoffmann
2013-04-22 15:41                   ` Paolo Bonzini
2013-04-22 14:02             ` Anthony Liguori
2013-04-22 14:22               ` Luiz Capitulino
2013-04-23  2:24               ` Amos Kong
2013-04-22  8:25     ` [Qemu-devel] [PATCH] ui/input.c: replace magic numbers by macros Amos Kong
2013-04-22 16:25     ` [Qemu-devel] [PATCH] monitor: intervally send down events to guest in hold time Eric Blake
2013-05-14 12:42 ` Laszlo Ersek
2013-05-14 14:55   ` Anthony Liguori
2013-05-15  8:13     ` Amos Kong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51753C8B.5080504@redhat.com \
    --to=kraxel@redhat.com \
    --cc=akong@redhat.com \
    --cc=lcapitulino@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.