Re: [Qemu-devel] [PATCH] monitor: intervally send down events to guest in hold time

[Anthony Liguori <anthony@codemonkey.ws>]

Laszlo Ersek <lersek@redhat.com> writes:

> Hi,
>
> On 04/19/13 06:44, Amos Kong wrote:
>> (qemu) sendkey a 1000
>> 
>> Current design is that qemu only send one down event to guest,
>> and delay sometime, then send one up event. In this case, only
>> key can be identified by guest.
>> 
>> This patch changed qemu to intervally send down events to guest
>> in the hold time, the interval is 100ms.
>> 
>> (qemu) sendkey a 1000
>> 
>> qemu will send 9 down events, 1 up event to guest, we can see
>> 9 'a' in guest screen.
>> 
>> Signed-off-by: Amos Kong <akong@redhat.com>
>> ---
>> This patch based on Luiz's qmp-unstable/queue/qmp
>> 
>> Signed-off-by: Amos Kong <akong@redhat.com>
>> ---
>>  hmp-commands.hx |    4 +++-
>>  qmp-commands.hx |    3 ++-
>>  ui/input.c      |   38 ++++++++++++++++++++++++++------------
>>  3 files changed, 31 insertions(+), 14 deletions(-)
>
> What's the status of this patch if I may ask?

1) It's unclear if this is the right solution.  If key repeat is done in
the PS/2 controller, then that's where the logic here should be.

2) It's a compat breaker from a QMP perspective.

Regards,

Anthony Liguori

>
> Thanks,
> Laszlo