Re: [PATCH] clocksource: add samsung pwm timer driver

[Kukjin Kim <kgene.kim@samsung.com>]

On 04/21/13 07:01, Arnd Bergmann wrote:
> From: Tomasz Figa<t.figa@samsung.com>
>
> This adds a new clocksource driver for the PWM timer that is
> present in most Samsung SoCs, based on the existing driver in
> arch/arm/plat-samsung/samsung-time.c and many changes implemented by
> Tomasz Figa.
>
> Originally, the conversion of all Samsung machines to the new driver was
> planned for 3.10, but that work ended up being too late and too invasive
> just before the merge window.
>
> Unfortunately, other changes in the Exynos platform resulted in some
> Exynos4 setups, particularly the Universal C210 board to be broken. In
> order to fix that with minimum risk, so we now leave the existing pwm
> clocksource driver in place for all older platforms and use the new
> driver only for device tree enabled boards. This way, we can get the
> broken machines running again using DT descriptions.
>
> All clocksource changes were implemented by Tomasz, while the DT
> registration was rewritten by Arnd.
>
> Signed-off-by: Arnd Bergmann<arnd@arndb.de>
> Cc: Tomasz Figa<t.figa@samsung.com>
> Cc: Kyungmin Park<kyungmin.park@samsung.com>
> Cc: Kukjin Kim<kgene.kim@samsung.com>

Acked-by: Kukjin Kim <kgene.kim@samsung.com>

Thanks.

- Kukjin

> Cc: Ben Dooks<ben-linux@fluff.org>
> Cc: John Stultz<john.stultz@linaro.org>
> Cc: Thomas Gleixner<tglx@linutronix.de>
> ---
> This is my final attempt to fix the Exynos4 regressions we have, since
> Tomasz put a lot of work into getting this running, and I gave him a
> hard time about some of the earlier patches.
>
> Tomasz, can you have a look at this to see if it would actually help?
> I have removed all the non-DT registration from your code, as well
> as the interface to the pwm subsystem, since I assume the existing
> code will work for all users we care about.