From: Chen Gang <gang.chen@asianux.com>
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: "sfr@canb.auug.org.au" <sfr@canb.auug.org.au>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"paulus@samba.org" <paulus@samba.org>,
Al Viro <viro@zeniv.linux.org.uk>,
"linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>
Subject: Re: [Suggestion] PowerPC: kernel: memory access violation when rtas_data_buf contents are more than 1026
Date: Tue, 23 Apr 2013 09:48:15 +0800 [thread overview]
Message-ID: <5175E85F.1040509@asianux.com> (raw)
In-Reply-To: <1366677081.2886.7.camel@pasglop>
On 2013年04月23日 08:31, Benjamin Herrenschmidt wrote:
> On Thu, 2013-04-18 at 12:45 +0800, Chen Gang wrote:
>> Hello Maintainers:
>>
>>
>> in arch/powerpc/kernel/lparcfg.c, parse_system_parameter_string()
>>
>> need set '\0' for 'local_buffer'.
>>
>> the reason is:
>> SPLPAR_MAXLENGTH is 1026, RTAS_DATA_BUF_SIZE is 4096
>> the contents of rtas_data_buf may truncated in memcpy (line 301).
>>
>> if contents are truncated.
>> the splpar_strlen is more than 1026 (line 321)
>> the while loop checking will not find the end of buffer (line 326)
>> it will cause memory access violation.
>>
>>
>> I find it by reading code, so please help check.
>
> And a signed-off-by please ?
>
ok, thanks, I should send the related patch.
--
Chen Gang
Asianux Corporation
WARNING: multiple messages have this Message-ID (diff)
From: Chen Gang <gang.chen@asianux.com>
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: "paulus@samba.org" <paulus@samba.org>,
Al Viro <viro@zeniv.linux.org.uk>,
"linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Michael Ellerman <michael@ellerman.id.au>,
"sfr@canb.auug.org.au" <sfr@canb.auug.org.au>
Subject: Re: [Suggestion] PowerPC: kernel: memory access violation when rtas_data_buf contents are more than 1026
Date: Tue, 23 Apr 2013 09:48:15 +0800 [thread overview]
Message-ID: <5175E85F.1040509@asianux.com> (raw)
In-Reply-To: <1366677081.2886.7.camel@pasglop>
On 2013年04月23日 08:31, Benjamin Herrenschmidt wrote:
> On Thu, 2013-04-18 at 12:45 +0800, Chen Gang wrote:
>> Hello Maintainers:
>>
>>
>> in arch/powerpc/kernel/lparcfg.c, parse_system_parameter_string()
>>
>> need set '\0' for 'local_buffer'.
>>
>> the reason is:
>> SPLPAR_MAXLENGTH is 1026, RTAS_DATA_BUF_SIZE is 4096
>> the contents of rtas_data_buf may truncated in memcpy (line 301).
>>
>> if contents are truncated.
>> the splpar_strlen is more than 1026 (line 321)
>> the while loop checking will not find the end of buffer (line 326)
>> it will cause memory access violation.
>>
>>
>> I find it by reading code, so please help check.
>
> And a signed-off-by please ?
>
ok, thanks, I should send the related patch.
--
Chen Gang
Asianux Corporation
next prev parent reply other threads:[~2013-04-23 1:49 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-18 4:45 [Suggestion] PowerPC: kernel: memory access violation when rtas_data_buf contents are more than 1026 Chen Gang
2013-04-18 4:45 ` Chen Gang
2013-04-23 0:31 ` Benjamin Herrenschmidt
2013-04-23 0:31 ` Benjamin Herrenschmidt
2013-04-23 1:48 ` Chen Gang [this message]
2013-04-23 1:48 ` Chen Gang
2013-04-23 3:12 ` [PATCH] " Chen Gang
2013-04-23 3:12 ` Chen Gang
2013-04-24 6:28 ` Vasant Hegde
2013-04-24 6:28 ` Vasant Hegde
2013-04-24 7:03 ` Chen Gang
2013-04-24 7:03 ` Chen Gang
2013-04-24 7:23 ` Vasant Hegde
2013-04-24 7:23 ` Vasant Hegde
2013-04-24 7:40 ` Chen Gang
2013-04-24 7:40 ` Chen Gang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5175E85F.1040509@asianux.com \
--to=gang.chen@asianux.com \
--cc=benh@kernel.crashing.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=paulus@samba.org \
--cc=sfr@canb.auug.org.au \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.